Bug 1324003 - /usr/lib/rpm/redhat/find-requires not matching Perl scripts properly
Summary: /usr/lib/rpm/redhat/find-requires not matching Perl scripts properly
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: redhat-rpm-config
Version: 7.2
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Florian Festi
QA Contact: Karel Srot
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-05 10:29 UTC by Karel Srot
Modified: 2016-11-04 04:47 UTC (History)
2 users (show)

Fixed In Version: redhat-rpm-config-9.1.0-69.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1324032 (view as bug list)
Environment:
Last Closed: 2016-11-04 04:47:08 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:2372 0 normal SHIPPED_LIVE redhat-rpm-config bug fix and enhancement update 2016-11-03 13:51:20 UTC

Description Karel Srot 2016-04-05 10:29:21 UTC
Description of problem:

/usr/lib/rpm/redhat/find-requires contain at two places following grep pattern:

  ":.* (commands|script) "

The problem is that file is identifying Perl scrips as follows:

  test.pl: Perl script, ASCII text executable

Therefore /usr/lib/rpm/find-requires from rpm rather uses

  ":.* (commands|script)[, ]"


Beside this problem there is also the same problem as described in bug 1275551.


Version-Release number of selected component (if applicable):
redhat-rpm-config-9.1.0-68.el7.noarch

How reproducible:
alwyas

Steps to Reproduce:

# cat > test.pl <<EOF
#!/usr/bin/perl

use AAA;
use BBB;

# use CCC is a comment and should not be part of requires
sub get_help
{
        return <<EOT;
This text is a help an if it contains something like
use DDD , it should not be part of requires
or like
        use EEE , it should not be part of requires
EOT
}
EOF

# chmod a+x test.pl
# echo test.pl | /usr/lib/rpm/redhat/find-requires
objdump: test.pl: File format not recognized


Expected results:

/usr/bin/perl
perl(AAA)
perl(BBB)

See also bug 1275551.

Comment 3 Ľuboš Kardoš 2016-04-05 12:27:29 UTC
The file find-requires is not used for generating autodeps any more, it is replaced with internal implementation inside rpm. Yes, there is macro  %_use_internal_dependency_generator which when it set to "0" then the file find-requires is used for dependency generation but it is set to "1" by default and it is highly recommended not to set it to "1". The macro exists only to enable preserving backward compatibility if it is necessary.

There is no sense in fixing that regex. If we want to do something we can replace content of /usr/lib/rpm/find-requires with calling of /usr/lib/rpmdeps tool as it is already done in fedora. The tool rpmdes uses the same code which is used in rpmbuild internally for generating autodeps. So we won't have two implementations of the same thing.

Comment 4 Ľuboš Kardoš 2016-04-05 12:28:31 UTC
s/it is highly recommended not to set it to "1"/it is highly recommended not to set it to "0"/

Comment 5 Ľuboš Kardoš 2016-04-05 12:34:10 UTC
I meant replace the content of /usr/lib/rpm/find-requires and probably remove /usr/lib/rpm/redhat/find-requires completely.

Comment 6 Florian Festi 2016-06-14 07:06:15 UTC
Fixed the ":.* (commands|script) " part.

The wrong perl Requires from #1275551 is caused by calling the broken script from the rpm package and needs to be fixed there.

Comment 10 errata-xmlrpc 2016-11-04 04:47:08 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2372.html


Note You need to log in before you can comment on or make changes to this bug.