Bug 1324018 - Traceback ERRORs display during NGN yum update
Summary: Traceback ERRORs display during NGN yum update
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-node
Classification: oVirt
Component: Installation & Update
Version: 4.0
Hardware: Unspecified
OS: Unspecified
high
high vote
Target Milestone: ovirt-4.0.0-beta
: 4.0
Assignee: Douglas Schilling Landgraf
QA Contact: cshao
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-05 10:51 UTC by cshao
Modified: 2016-07-05 08:00 UTC (History)
9 users (show)

Fixed In Version: ovirt-node-ng-installer-ovirt-4.0-2016040707.iso
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-05 08:00:36 UTC
oVirt Team: Node
rule-engine: ovirt-4.0.0+
rule-engine: planning_ack+
fdeutsch: devel_ack+
cshao: testing_ack+


Attachments (Terms of Use)
/var/log/*.* (250.87 KB, application/x-gzip)
2016-04-05 10:51 UTC, cshao
no flags Details
yum_update.log (39.78 KB, text/plain)
2016-05-05 10:35 UTC, cshao
no flags Details

Description cshao 2016-04-05 10:51:02 UTC
Description of problem:
NGN4.0 upgrade failed via repo.

Version-Release number of selected component (if applicable):
ovirt-node-ng-nightly-boot-20160323.iso
squashfs.20160323
ovirt-node-ng-image-update-placeholder-005-1.el7.noarch  
imgbased-0.5-0.201603181316git77345d3.el7.centos.noarch                         
ovirt-release-host-node-005-1.el7.noarch   
RHEV-M 3.6.4-4 (rhevm-3.6.4.1-0.1el6).
vdsm-4.17.23-1.el7.noarch
ovirt-node-ng-image-update-4.0.0-0.999.master.20160404.0.el7.noarch.rpm	

How reproducible:
100%

Steps to Reproduce:
1. Install NGN 4.0 build (squashfs.20160323) via anaconda.
2. Download package ovirt-node-ng-image-update-4.0.0-0.999.master.20160404.0.el7.noarch.rpm
3. rpm -ivh ovirt-node-ng-image-update-4.0.0-0.999.master.20160404.0.el7.noarch.rpm	

Actual results:
NGN4.0 upgrade failed via repo

==============================================
]# rpm -ivh ovirt-node-ng-image-update-4.0.0-0.999.master.20160404.0.el7.noarch.rpm
Preparing...                          ################################# [100%]
Updating / installing...
   1:ovirt-node-ng-image-update-4.0.0-################################# [100%]
[DEBUG] Arguments: Namespace(FILENAME='/usr/share/ovirt-node-ng/image//ovirt-node-ng-4.0.0-0.999.master.20160404.0.el7.squashfs.img', NVR='ovirt-node-ng-4.0.0-0.999.master.20160404.0.el7', command='update', debug=True, experimental=False, format='liveimg', stream='Image')
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7f132e4091d0>
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7f132e4091d0>
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7f132e4091d0>
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7f132e4091d0>
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7f132e4091d0>
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7f132e4091d0>
[INFO] Extracting image '/usr/share/ovirt-node-ng/image//ovirt-node-ng-4.0.0-0.999.master.20160404.0.el7.squashfs.img'
[DEBUG] Calling binary: (['mktemp', '-d', '--tmpdir', 'mnt.XXXXX'],) {}
[DEBUG] Calling: (['mktemp', '-d', '--tmpdir', 'mnt.XXXXX'],) {'close_fds': True}
[DEBUG] Returned: /tmp/mnt.9bQmc
[DEBUG] Calling binary: (['mount', '/usr/share/ovirt-node-ng/image//ovirt-node-ng-4.0.0-0.999.master.20160404.0.el7.squashfs.img', u'/tmp/mnt.9bQmc'],) {}
[DEBUG] Calling: (['mount', '/usr/share/ovirt-node-ng/image//ovirt-node-ng-4.0.0-0.999.master.20160404.0.el7.squashfs.img', u'/tmp/mnt.9bQmc'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Mounted squashfs
[DEBUG] Found fsimage at '/tmp/mnt.9bQmc/LiveOS/rootfs.img'
[DEBUG] Calling binary: (['mktemp', '-d', '--tmpdir', 'mnt.XXXXX'],) {}
[DEBUG] Calling: (['mktemp', '-d', '--tmpdir', 'mnt.XXXXX'],) {'close_fds': True}
[DEBUG] Returned: /tmp/mnt.5ojwf
[DEBUG] Calling binary: (['mount', u'/tmp/mnt.9bQmc/LiveOS/rootfs.img', u'/tmp/mnt.5ojwf'],) {}
[DEBUG] Calling: (['mount', u'/tmp/mnt.9bQmc/LiveOS/rootfs.img', u'/tmp/mnt.5ojwf'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Calling binary: (['du', '-sxb', u'/tmp/mnt.5ojwf'],) {}
[DEBUG] Calling: (['du', '-sxb', u'/tmp/mnt.5ojwf'],) {'close_fds': True}
[DEBUG] Returned: 1559299869	/tmp/mnt.5ojwf
[DEBUG] Recommeneded base size: 4677899776
[INFO] Starting base creation
[INFO] New base will be: ovirt-node-ng-4.0.0-0.999.master.20160404.0.el7
[DEBUG] Calling binary: (['vgs', '--noheadings', '@imgbased:pool', '-o', 'lv_full_name'],) {}
[DEBUG] Calling: (['vgs', '--noheadings', '@imgbased:pool', '-o', 'lv_full_name'],) {'close_fds': True}
[DEBUG] Returned: centos_dhcp-11-123/pool00
[DEBUG] Pool: <LV 'centos_dhcp-11-123/pool00' />
[DEBUG] Calling binary: (['lvcreate', '--thin', '--virtualsize', '4677899776B', '--name', 'ovirt-node-ng-4.0.0-0.999.master.20160404.0.el7', u'centos_dhcp-11-123/pool00'],) {}
[DEBUG] Calling: (['lvcreate', '--thin', '--virtualsize', '4677899776B', '--name', 'ovirt-node-ng-4.0.0-0.999.master.20160404.0.el7', u'centos_dhcp-11-123/pool00'],) {'close_fds': True}
  Logical volume "ovirt-node-ng-4.0.0-0.999.master.20160404.0.el7" already exists in volume group "centos_dhcp-11-123"
[DEBUG] Calling binary: (['umount', u'/tmp/mnt.5ojwf'],) {}
[DEBUG] Calling: (['umount', u'/tmp/mnt.5ojwf'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Calling binary: (['rmdir', u'/tmp/mnt.5ojwf'],) {}
[DEBUG] Calling: (['rmdir', u'/tmp/mnt.5ojwf'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Calling binary: (['umount', u'/tmp/mnt.9bQmc'],) {}
[DEBUG] Calling: (['umount', u'/tmp/mnt.9bQmc'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Calling binary: (['rmdir', u'/tmp/mnt.9bQmc'],) {}
[DEBUG] Calling: (['rmdir', u'/tmp/mnt.9bQmc'],) {'close_fds': True}
[DEBUG] Returned: 
Traceback (most recent call last):
  File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/lib/python2.7/site-packages/imgbased/__main__.py", line 47, in <module>
    CliApplication()
  File "/usr/lib/python2.7/site-packages/imgbased/__init__.py", line 80, in CliApplication
    app.hooks.emit("post-arg-parse", args)
  File "/usr/lib/python2.7/site-packages/imgbased/hooks.py", line 120, in emit
    cb(self.context, *args)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/update.py", line 39, in check_argparse
    args.NVR)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/update.py", line 94, in extract
    "%sB" % size, nvr)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/update.py", line 63, in add_base_with_tree
    lvs)
  File "/usr/lib/python2.7/site-packages/imgbased/imgbase.py", line 249, in add_base
    new_base_lv = pool.create_thinvol(new_base.lv_name, size)
  File "/usr/lib/python2.7/site-packages/imgbased/lvm.py", line 254, in create_thinvol
    self.lvm_name])
  File "/usr/lib/python2.7/site-packages/imgbased/utils.py", line 251, in lvcreate
    return self.call(["lvcreate"] + args, **kwargs)
  File "/usr/lib/python2.7/site-packages/imgbased/utils.py", line 240, in call
    stdout = call(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/imgbased/utils.py", line 104, in call
    return subprocess.check_output(*args, **kwargs).strip()
  File "/usr/lib64/python2.7/subprocess.py", line 575, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '['lvcreate', '--thin', '--virtualsize', '4677899776B', '--name', 'ovirt-node-ng-4.0.0-0.999.master.20160404.0.el7', u'centos_dhcp-11-123/pool00']' returned non-zero exit status 5
warning: %post(ovirt-node-ng-image-update-4.0.0-0.999.master.20160404.0.el7.noarch) scriptlet failed, exit status 1
===============================================

Expected results:
NGN4.0 upgrade successful via repo

Additional info:

Comment 1 cshao 2016-04-05 10:51:26 UTC
Created attachment 1143775 [details]
/var/log/*.*

Comment 2 wanghui 2016-04-06 12:10:15 UTC
Test verison:
ovirt-node-ng-installer-master-20160405.iso
squashfs.20160405
ovirt-node-ng-image-update-placeholder-4.0.0-0.2.alpha1.20160405123556.gitbd184ec.el7.noarch
imgbased-0.5-0.201604040928gitd6a85f8.el7.centos.noarch
ovirt-release-host-node-4.0.0-0.2.alpha1.20160405123556.gitbd184ec.el7.noarch

Yum update also encounter error like follows.

# yum update
Loaded plugins: fastestmirror, imgbased-warning
Warning: yum operations are not persisted across upgrades!
ovirt-node-nightly                                                                                                                                                                                                    | 2.9 kB  00:00:00     
ovirt-node-nightly/primary_db                                                                                                                                                                                         | 2.5 kB  00:00:00     
Loading mirror speeds from cached hostfile
Resolving Dependencies
--> Running transaction check
---> Package ovirt-node-ng-image-update.noarch 0:4.0.0-0.999.master.20160406.0.el7 will be obsoleting
---> Package ovirt-node-ng-image-update-placeholder.noarch 0:4.0.0-0.2.alpha1.20160405123556.gitbd184ec.el7 will be obsoleted
--> Finished Dependency Resolution

Dependencies Resolved

=============================================================================================================================================================================================================================================
 Package                                                       Arch                                      Version                                                                 Repository                                             Size
=============================================================================================================================================================================================================================================
Installing:
 ovirt-node-ng-image-update                                    noarch                                    4.0.0-0.999.master.20160406.0.el7                                       ovirt-node-nightly                                    498 M
     replacing  ovirt-node-ng-image-update-placeholder.noarch 4.0.0-0.2.alpha1.20160405123556.gitbd184ec.el7

Transaction Summary
=============================================================================================================================================================================================================================================
Install  1 Package

Total download size: 498 M
Is this ok [y/d/N]: y
Downloading packages:
Delta RPMs disabled because /usr/bin/applydeltarpm not installed.
ovirt-node-ng-image-update-4.0.0-0.999.master.20160406.0.el7.noarch.rpm                                 43% [=====================ovirt-node-ng-image-update-4.0.0-0.999.master.20160406.0.el7.noarch.rpm                                                                                                                                               | 498 MB  00:02:05     
Running transaction check
Running transaction test
Transaction test succeeded
Running transaction
  Installing : ovirt-node-ng-image-update-4.0.0-0.999.master.20160406.0.el7.noarch                                                                                                                                                       1/2 
[DEBUG] Arguments: Namespace(FILENAME='/usr/share/ovirt-node-ng/image//ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7.squashfs.img', NVR='ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7', command='update', debug=True, experimental=False, format='liveimg', stream='Image')
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7f0dde7c0750>
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7f0dde7c0750>
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7f0dde7c0750>
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7f0dde7c0750>
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7f0dde7c0750>
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7f0dde7c0750>
[INFO] Extracting image '/usr/share/ovirt-node-ng/image//ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7.squashfs.img'
[DEBUG] Calling binary: (['mktemp', '-d', '--tmpdir', 'mnt.XXXXX'],) {}
[DEBUG] Calling: (['mktemp', '-d', '--tmpdir', 'mnt.XXXXX'],) {'close_fds': True}
[DEBUG] Returned: /tmp/mnt.eI4zU
[DEBUG] Calling binary: (['mount', '/usr/share/ovirt-node-ng/image//ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7.squashfs.img', u'/tmp/mnt.eI4zU'],) {}
[DEBUG] Calling: (['mount', '/usr/share/ovirt-node-ng/image//ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7.squashfs.img', u'/tmp/mnt.eI4zU'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Mounted squashfs
[DEBUG] Found fsimage at '/tmp/mnt.eI4zU/LiveOS/rootfs.img'
[DEBUG] Calling binary: (['mktemp', '-d', '--tmpdir', 'mnt.XXXXX'],) {}
[DEBUG] Calling: (['mktemp', '-d', '--tmpdir', 'mnt.XXXXX'],) {'close_fds': True}
[DEBUG] Returned: /tmp/mnt.HGFFB
[DEBUG] Calling binary: (['mount', u'/tmp/mnt.eI4zU/LiveOS/rootfs.img', u'/tmp/mnt.HGFFB'],) {}
[DEBUG] Calling: (['mount', u'/tmp/mnt.eI4zU/LiveOS/rootfs.img', u'/tmp/mnt.HGFFB'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Calling binary: (['du', '-sxb', u'/tmp/mnt.HGFFB'],) {}
[DEBUG] Calling: (['du', '-sxb', u'/tmp/mnt.HGFFB'],) {'close_fds': True}
[DEBUG] Returned: 1557272213	/tmp/mnt.HGFFB
[DEBUG] Recommeneded base size: 4671816704
[INFO] Starting base creation
[INFO] New base will be: ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7
[DEBUG] Calling binary: (['vgs', '--noheadings', '@imgbased:pool', '-o', 'lv_full_name'],) {}
[DEBUG] Calling: (['vgs', '--noheadings', '@imgbased:pool', '-o', 'lv_full_name'],) {'close_fds': True}
[DEBUG] Returned: centos_dhcp-8-110/pool00
[DEBUG] Pool: <LV 'centos_dhcp-8-110/pool00' />
[DEBUG] Calling binary: (['lvcreate', '--thin', '--virtualsize', '4671816704B', '--name', 'ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7', u'centos_dhcp-8-110/pool00'],) {}
[DEBUG] Calling: (['lvcreate', '--thin', '--virtualsize', '4671816704B', '--name', 'ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7', u'centos_dhcp-8-110/pool00'],) {'close_fds': True}
  WARNING: Sum of all thin volume sizes (965.54 GiB) exceeds the size of thin pool centos_dhcp-8-110/pool00 and the size of whole volume group (931.02 GiB)!
[DEBUG] Returned: Rounding up size to full physical extent 4.35 GiB
  For thin pool auto extension activation/thin_pool_autoextend_threshold should be below 100.
  Logical volume "ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7" created.
[DEBUG] Calling binary: (['lvchange', '--addtag', 'imgbased:base', u'centos_dhcp-8-110/ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7'],) {}
[DEBUG] Calling: (['lvchange', '--addtag', 'imgbased:base', u'centos_dhcp-8-110/ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7'],) {'close_fds': True}
[DEBUG] Returned: Logical volume "ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7" changed.
[INFO] New LV is: <LV 'centos_dhcp-8-110/ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7' />
[DEBUG] Calling binary: (['lvchange', '--permission', 'r', u'centos_dhcp-8-110/ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7'],) {}
[DEBUG] Calling: (['lvchange', '--permission', 'r', u'centos_dhcp-8-110/ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7'],) {'close_fds': True}
[DEBUG] Returned: Logical volume "ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7" changed.
[DEBUG] Calling binary: (['lvchange', '--setactivationskip', 'y', u'centos_dhcp-8-110/ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7'],) {}
[DEBUG] Calling: (['lvchange', '--setactivationskip', 'y', u'centos_dhcp-8-110/ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7'],) {'close_fds': True}
[DEBUG] Returned: Logical volume "ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7" changed.
[DEBUG] Calling binary: (['lvchange', '--activate', 'n', u'centos_dhcp-8-110/ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7', '--ignoreactivationskip'],) {}
[DEBUG] Calling: (['lvchange', '--activate', 'n', u'centos_dhcp-8-110/ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7', '--ignoreactivationskip'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Calling binary: (['vgs', '--noheadings', '--select', 'vg_tags = imgbased:vg', '-o', 'vg_name'],) {}
[DEBUG] Calling: (['vgs', '--noheadings', '--select', 'vg_tags = imgbased:vg', '-o', 'vg_name'],) {'close_fds': True}
[DEBUG] Returned: centos_dhcp-8-110
[DEBUG] Calling binary: (['lvchange', '--permission', 'rw', u'centos_dhcp-8-110/ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7'],) {}
[DEBUG] Calling: (['lvchange', '--permission', 'rw', u'centos_dhcp-8-110/ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7'],) {'close_fds': True}
[DEBUG] Returned: Logical volume "ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7" changed.
[DEBUG] Calling binary: (['lvchange', '--setactivationskip', 'n', u'centos_dhcp-8-110/ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7'],) {}
[DEBUG] Calling: (['lvchange', '--setactivationskip', 'n', u'centos_dhcp-8-110/ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7'],) {'close_fds': True}
[DEBUG] Returned: Logical volume "ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7" changed.
[DEBUG] Calling binary: (['lvchange', '--activate', 'y', u'centos_dhcp-8-110/ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7', '--ignoreactivationskip'],) {}
[DEBUG] Calling: (['lvchange', '--activate', 'y', u'centos_dhcp-8-110/ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7', '--ignoreactivationskip'],) {'close_fds': True}
[DEBUG] Returned: 
[INFO] Creating new filesystem on base
[DEBUG] Calling binary: (['findmnt', '--noheadings', '-o', 'SOURCE', '/'],) {}
[DEBUG] Calling: (['findmnt', '--noheadings', '-o', 'SOURCE', '/'],) {'close_fds': True}
[DEBUG] Returned: /dev/mapper/centos_dhcp--8--110-root
[DEBUG] Calling binary: (['lvchange', '--permission', 'r', u'centos_dhcp-8-110/ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7'],) {}
[DEBUG] Calling: (['lvchange', '--permission', 'r', u'centos_dhcp-8-110/ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7'],) {'close_fds': True}
[DEBUG] Returned: Logical volume "ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7" changed.
[DEBUG] Calling binary: (['lvchange', '--setactivationskip', 'y', u'centos_dhcp-8-110/ovirt-node-ng-4.0.0-0.999.master.20160406.0#yum update#yum update.el7'],) {}
[DEBUG] Calling: (['lvchange', '--setactivationskip', 'y', u'centos_dhcp-8-110/ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7'],) {'close_fds': True}
[DEBUG] Returned: Logical volume "ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7" changed.
[DEBUG] Calling binary: (['lvchange', '--activate', 'n', u'centos_dhcp-8-110/ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7', '--ignoreactivationskip'],) {}
[DEBUG] Calling: (['lvchange', '--activate', 'n', u'centos_dhcp-8-110/ovirt-node-ng-4.0.0-0.999.master.20160406.0.el7', '--ignoreactivationskip'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Calling binary: (['umount', u'/tmp/mnt.HGFFB'],) {}
[DEBUG] Calling: (['umount', u'/tmp/mnt.HGFFB'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Calling binary: (['rmdir', u'/tmp/mnt.HGFFB'],) {}
[DEBUG] Calling: (['rmdir', u'/tmp/mnt.HGFFB'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Calling binary: (['umount', u'/tmp/mnt.eI4zU'],) {}
[DEBUG] Calling: (['umount', u'/tmp/mnt.eI4zU'],) {'close_fds': True}
[DEBUG] Returned: #yum update#yum update#yum update
[DEBUG] Calling binary: (['rmdir', u'/tmp/mnt.eI4zU'],) {}
[DEBUG] Calling: (['rmdir', u'/tmp/mnt.eI4zU'],) {'close_fds': True}
[DEBUG] Returned: 
Traceback (most recent call last):
  File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/lib/python2.7/site-packages/imgbased/__main__.py", line 42, in <module>
    CliApplication()
  File "/usr/lib/python2.7/site-packages/imgbased/__init__.py", line 80, in CliApplication
    app.hooks.emit("post-arg-parse", args)
  File "/usr/lib/python2.7/site-packages/imgbased/hooks.py", line 120, in emit
    cb(self.context, *args)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/update.py", line 39, in check_argparse
    args.NVR)#yum update#yum update#yum update
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/update.py", line 94, in extract
    "%sB" % size, nvr)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/update.py", line 68, in add_base_with_tree
    Filesystem.from_mountpoint("/").mkfs(new_base_lv.path)
  File "/usr/lib/python2.7/site-packages/imgbased/utils.py", line 236, in from_mountpoint
    return cls.from_device(source)
  File "/usr/lib/python2.7/site-packages/imgbased/utils.py", line 229, in from_device
    raise RuntimeError("Unknown filesystem %s on %s" % (typ, path))
RuntimeError: Unknown filesystem xfs
 on /dev/mapper/centos_dhcp--8--110-root
warning: %post(ovirt-node-ng-image-update-4.0.0-0.999.master.20160406.0.el7.noarch) scriptlet failed, exit status 1
Non-fatal POSTIN scriptlet failure in rpm package ovirt-node-ng-image-update-4.0.0-0.999.master.20160406.0.el7.noarch
  Erasing    : ovirt-node-ng-image-update-placeholder-4.0.0-0.2.alpha1.20160405123556.gitbd184ec.el7.noarch                                                                                                                              2/2 
  Verifying  : ovirt-node-ng-image-update-4.0.0-0.999.master.20160406.0.el7.noarch                                                                                                                                                       1/2 
  Verifying  : ovirt-node-ng-image-update-placeholder-4.0.0-0.2.alpha1.20160405123556.gitbd184ec.el7.noarch                                                                                                                              2/2 

Installed:
  ovirt-node-ng-image-update.noarch 0:4.0.0-0.999.master.20160406.0.el7                                                                                                                                                                      

Replaced:
  ovirt-node-ng-image-update-placeholder.noarch 0:4.0.0-0.2.alpha1.20160405123556.gitbd184ec.el7                                                                                                                                             

Complete!

Comment 3 Fabian Deutsch 2016-04-06 20:02:01 UTC
Mightbe gone on tomorrows builds

Comment 4 Fabian Deutsch 2016-04-07 15:44:47 UTC
This worked for me with todays build

Comment 5 cshao 2016-04-14 09:55:44 UTC
Hi fabian,

  Seems it can work fine now, but there still met some minor error.
Can we verify this bug?

usage: imgbase update [-h] [--format FORMAT] NAME-VERSION-RELEASE FILENAME
imgbase update: error: too few arguments
warning: %post(ovirt-node-ng-image-update-4.0.0-0.999.master.20160413.0.el7.noarch) scriptlet failed, exit status 2
Non-fatal POSTIN scriptlet failure in rpm package ovirt-node-ng-image-update-4.0.0-0.999.master.20160413.0.el7.noarch



Test version:
ovirt-node-ng-installer-master-2016041020.iso
ovirt-node-ng-image-update-placeholder-4.0.0-0.3.master.20160330132038.git9d1a64e.el7.noarch
imgbased-0.5-0.201604062114git5eae1f9.el7.centos.noarch
ovirt-release-host-node-4.0.0-0.3.master.20160330132038.git9d1a64e.el7.noarch

# yum update
Loaded plugins: fastestmirror, imgbased-warning
Warning: yum operations are not persisted across upgrades!
ovirt-node-nightly                                                                                                                                                                          | 2.9 kB  00:00:00     
ovirt-node-nightly/primary_db                                                                                                                                                               | 2.4 kB  00:00:00     
Loading mirror speeds from cached hostfile
Resolving Dependencies
--> Running transaction check
---> Package ovirt-node-ng-image-update.noarch 0:4.0.0-0.999.master.20160413.0.el7 will be obsoleting
---> Package ovirt-node-ng-image-update-placeholder.noarch 0:4.0.0-0.3.master.20160330132038.git9d1a64e.el7 will be obsoleted
--> Finished Dependency Resolution

Dependencies Resolved

===================================================================================================================================================================================================================
 Package                                                 Arch                                Version                                                         Repository                                       Size
===================================================================================================================================================================================================================
Installing:
 ovirt-node-ng-image-update                              noarch                              4.0.0-0.999.master.20160413.0.el7                               ovirt-node-nightly                              503 M
     replacing  ovirt-node-ng-image-update-placeholder.noarch 4.0.0-0.3.master.20160330132038.git9d1a64e.el7

Transaction Summary
===================================================================================================================================================================================================================
Install  1 Package

Total download size: 503 M
Is this ok [y/d/N]: y
Downloading packages:
ovirt-node-ng-image-update-4.0.0-0.999.master.20160413.0.el7.noarch.rpm                                                                                                                     | 503 MB  00:07:55     
Running transaction check
Running transaction test
Transaction test succeeded
Running transaction
  Installing : ovirt-node-ng-image-update-4.0.0-0.999.master.20160413.0.el7.noarch                                                                                                                             1/2 
usage: imgbase update [-h] [--format FORMAT] NAME-VERSION-RELEASE FILENAME
imgbase update: error: too few arguments
warning: %post(ovirt-node-ng-image-update-4.0.0-0.999.master.20160413.0.el7.noarch) scriptlet failed, exit status 2
Non-fatal POSTIN scriptlet failure in rpm package ovirt-node-ng-image-update-4.0.0-0.999.master.20160413.0.el7.noarch
  Erasing    : ovirt-node-ng-image-update-placeholder-4.0.0-0.3.master.20160330132038.git9d1a64e.el7.noarch                                                                                                    2/2 
  Verifying  : ovirt-node-ng-image-update-4.0.0-0.999.master.20160413.0.el7.noarch                                                                                                                             1/2 
  Verifying  : ovirt-node-ng-image-update-placeholder-4.0.0-0.3.master.20160330132038.git9d1a64e.el7.noarch                                                                                                    2/2 

Installed:
  ovirt-node-ng-image-update.noarch 0:4.0.0-0.999.master.20160413.0.el7                                                                                                                                            

Replaced:
  ovirt-node-ng-image-update-placeholder.noarch 0:4.0.0-0.3.master.20160330132038.git9d1a64e.el7                                                                                                                   

Complete!

Comment 6 Fabian Deutsch 2016-04-14 10:07:29 UTC
Yes, this is anothe rbug with a similar symptom. Let's keep this on modified, I'm just rebuilding the branches to fix this issue.

Comment 7 Huijuan Zhao 2016-04-21 05:27:56 UTC
Is this bug only modified on master build? Still encounter this issue same as comment 0 on 3.6 build.

Version-Release number of selected component (if applicable):
squashfs.20160415
imgbased-0.6-0.201604150305git1e3b28f.el7.centos.noarch
ovirt-node-ng-image-update-placeholder-007-1.el7.noarch
ovirt-release-host-node-007-1.el7.noarch

ovirt-node-ng-image-update-3.6.5-1.20160419.0.el7.noarch.rpm
ovirt-node-ng-image-update-3.6.5-1.20160420.0.el7.noarch.rpm


How reproducible:
100%


Steps to Reproduce:
1. Install NGN 4.0 build (squashfs.20160415) via anaconda.
2. Download package ovirt-node-ng-image-update-3.6.5-1.20160419.0.el7.noarch
3. yum install ovirt-node-ng-image-update-3.6.5-1.20160419.0.el7.noarch.rpm
4. Download package ovirt-node-ng-image-update-3.6.5-1.20160420.0.el7.noarch
5. rpm -ivh ovirt-node-ng-image-update-3.6.5-1.20160420.0.el7.noarch.rpm


Actual result:
1. After step 3, 
[root@dhcp-10-125 home]# yum install ovirt-node-ng-image-update-3.6.5-1.20160419.0.el7.noarch.rpm
Loaded plugins: fastestmirror, imgbased-warning
Warning: yum operations are not persisted across upgrades!
Examining ovirt-node-ng-image-update-3.6.5-1.20160419.0.el7.noarch.rpm: 1:ovirt-node-ng-image-update-3.6.5-1.20160419.0.el7.noarch
Marking ovirt-node-ng-image-update-3.6.5-1.20160419.0.el7.noarch.rpm to be installed
Resolving Dependencies
--> Running transaction check
---> Package ovirt-node-ng-image-update.noarch 1:3.6.5-1.20160419.0.el7 will be obsoleting
---> Package ovirt-node-ng-image-update-placeholder.noarch 0:007-1.el7 will be obsoleted
--> Finished Dependency Resolution

Dependencies Resolved

======================================================================================================================================================================
 Package                              Arch             Version                              Repository                                                           Size
======================================================================================================================================================================
Installing:
 ovirt-node-ng-image-update           noarch           1:3.6.5-1.20160419.0.el7             /ovirt-node-ng-image-update-3.6.5-1.20160419.0.el7.noarch           499 M
     replacing  ovirt-node-ng-image-update-placeholder.noarch 007-1.el7

Transaction Summary
======================================================================================================================================================================
Install  1 Package

Total size: 499 M
Is this ok [y/d/N]: y
Downloading packages:
Running transaction check
Running transaction test
Transaction test succeeded
Running transaction
  Installing : 1:ovirt-node-ng-image-update-3.6.5-1.20160419.0.el7.noarch                                                                                         1/2 
[DEBUG] Arguments: Namespace(FILENAME='/usr/share/ovirt-node-ng/image//ovirt-node-ng-3.6.5-1.20160419.0.el7.squashfs.img', command='update', debug=True, experimental=False, format='liveimg', stream='Image')
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7faa47e1d890>
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7faa47e1d890>
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7faa47e1d890>
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7faa47e1d890>
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7faa47e1d890>
[INFO] Extracting image '/usr/share/ovirt-node-ng/image//ovirt-node-ng-3.6.5-1.20160419.0.el7.squashfs.img'
[DEBUG] Calling binary: (['mktemp', '-d', '--tmpdir', 'mnt.XXXXX'],) {}
[DEBUG] Calling: (['mktemp', '-d', '--tmpdir', 'mnt.XXXXX'],) {'close_fds': True}
[DEBUG] Returned: /tmp/mnt.rv4uA
[DEBUG] Calling binary: (['mount', '/usr/share/ovirt-node-ng/image//ovirt-node-ng-3.6.5-1.20160419.0.el7.squashfs.img', u'/tmp/mnt.rv4uA'],) {}
[DEBUG] Calling: (['mount', '/usr/share/ovirt-node-ng/image//ovirt-node-ng-3.6.5-1.20160419.0.el7.squashfs.img', u'/tmp/mnt.rv4uA'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Mounted squashfs
[DEBUG] Found fsimage at '/tmp/mnt.rv4uA/LiveOS/rootfs.img'
[DEBUG] Calling binary: (['mktemp', '-d', '--tmpdir', 'mnt.XXXXX'],) {}
[DEBUG] Calling: (['mktemp', '-d', '--tmpdir', 'mnt.XXXXX'],) {'close_fds': True}
[DEBUG] Returned: /tmp/mnt.pYLSR
[DEBUG] Calling binary: (['mount', u'/tmp/mnt.rv4uA/LiveOS/rootfs.img', u'/tmp/mnt.pYLSR'],) {}
[DEBUG] Calling: (['mount', u'/tmp/mnt.rv4uA/LiveOS/rootfs.img', u'/tmp/mnt.pYLSR'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Using nvr: ovirt-node-ng-3.6.5-0.20160419.0
[DEBUG] Calling binary: (['du', '-sxb', u'/tmp/mnt.pYLSR'],) {}
[DEBUG] Calling: (['du', '-sxb', u'/tmp/mnt.pYLSR'],) {'close_fds': True}
[DEBUG] Returned: 1558403236	/tmp/mnt.pYLSR
[DEBUG] Recommeneded base size: 4675209728
[INFO] Starting base creation
[INFO] New base will be: ovirt-node-ng-3.6.5-0.20160419.0
[DEBUG] Calling binary: (['vgs', '--noheadings', '@imgbased:pool', '-o', 'lv_full_name'],) {}
[DEBUG] Calling: (['vgs', '--noheadings', '@imgbased:pool', '-o', 'lv_full_name'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Calling binary: (['umount', u'/tmp/mnt.pYLSR'],) {}
[DEBUG] Calling: (['umount', u'/tmp/mnt.pYLSR'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Calling binary: (['rmdir', u'/tmp/mnt.pYLSR'],) {}
[DEBUG] Calling: (['rmdir', u'/tmp/mnt.pYLSR'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Calling binary: (['umount', u'/tmp/mnt.rv4uA'],) {}
[DEBUG] Calling: (['umount', u'/tmp/mnt.rv4uA'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Calling binary: (['rmdir', u'/tmp/mnt.rv4uA'],) {}
[DEBUG] Calling: (['rmdir', u'/tmp/mnt.rv4uA'],) {'close_fds': True}
[DEBUG] Returned: 
Traceback (most recent call last):
  File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/lib/python2.7/site-packages/imgbased/__main__.py", line 42, in <module>
    CliApplication()
  File "/usr/lib/python2.7/site-packages/imgbased/__init__.py", line 80, in CliApplication
    app.hooks.emit("post-arg-parse", args)
  File "/usr/lib/python2.7/site-packages/imgbased/hooks.py", line 120, in emit
    cb(self.context, *args)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/update.py", line 85, in check_argparse
    .extract(args.FILENAME)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/update.py", line 142, in extract
    "%sB" % size, nvr)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/update.py", line 109, in add_base_with_tree
    lvs)
  File "/usr/lib/python2.7/site-packages/imgbased/imgbase.py", line 246, in add_base
    pool = self._thinpool()
  File "/usr/lib/python2.7/site-packages/imgbased/imgbase.py", line 100, in _thinpool
    return LVM.Thinpool.from_tag(self.thinpool_tag)
  File "/usr/lib/python2.7/site-packages/imgbased/lvm.py", line 169, in from_tag
    assert len(lvs) == 1
AssertionError
warning: %post(ovirt-node-ng-image-update-1:3.6.5-1.20160419.0.el7.noarch) scriptlet failed, exit status 1
Non-fatal POSTIN scriptlet failure in rpm package 1:ovirt-node-ng-image-update-3.6.5-1.20160419.0.el7.noarch
  Erasing    : ovirt-node-ng-image-update-placeholder-007-1.el7.noarch                                                                                            2/2 
  Verifying  : 1:ovirt-node-ng-image-update-3.6.5-1.20160419.0.el7.noarch                                                                                         1/2 
  Verifying  : ovirt-node-ng-image-update-placeholder-007-1.el7.noarch                                                                                            2/2 

Installed:
  ovirt-node-ng-image-update.noarch 1:3.6.5-1.20160419.0.el7                                                                                                          

Replaced:
  ovirt-node-ng-image-update-placeholder.noarch 0:007-1.el7                                                                                                           

Complete!


2. After step5,
[root@dhcp-10-125 home]# rpm -ivh ovirt-node-ng-image-update-3.6.5-1.20160420.0.el7.noarch.rpm
Preparing...                          ################################# [100%]
Updating / installing...
   1:ovirt-node-ng-image-update-1:3.6.################################# [100%]
[DEBUG] Arguments: Namespace(FILENAME='/usr/share/ovirt-node-ng/image//ovirt-node-ng-3.6.5-1.20160420.0.el7.squashfs.img', command='update', debug=True, experimental=False, format='liveimg', stream='Image')
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7f7cd9663890>
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7f7cd9663890>
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7f7cd9663890>
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7f7cd9663890>
[DEBUG] Operating on: <imgbased.imgbase.ImageLayers object at 0x7f7cd9663890>
[INFO] Extracting image '/usr/share/ovirt-node-ng/image//ovirt-node-ng-3.6.5-1.20160420.0.el7.squashfs.img'
[DEBUG] Calling binary: (['mktemp', '-d', '--tmpdir', 'mnt.XXXXX'],) {}
[DEBUG] Calling: (['mktemp', '-d', '--tmpdir', 'mnt.XXXXX'],) {'close_fds': True}
[DEBUG] Returned: /tmp/mnt.otxu2
[DEBUG] Calling binary: (['mount', '/usr/share/ovirt-node-ng/image//ovirt-node-ng-3.6.5-1.20160420.0.el7.squashfs.img', u'/tmp/mnt.otxu2'],) {}
[DEBUG] Calling: (['mount', '/usr/share/ovirt-node-ng/image//ovirt-node-ng-3.6.5-1.20160420.0.el7.squashfs.img', u'/tmp/mnt.otxu2'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Mounted squashfs
[DEBUG] Found fsimage at '/tmp/mnt.otxu2/LiveOS/rootfs.img'
[DEBUG] Calling binary: (['mktemp', '-d', '--tmpdir', 'mnt.XXXXX'],) {}
[DEBUG] Calling: (['mktemp', '-d', '--tmpdir', 'mnt.XXXXX'],) {'close_fds': True}
[DEBUG] Returned: /tmp/mnt.pPlkn
[DEBUG] Calling binary: (['mount', u'/tmp/mnt.otxu2/LiveOS/rootfs.img', u'/tmp/mnt.pPlkn'],) {}
[DEBUG] Calling: (['mount', u'/tmp/mnt.otxu2/LiveOS/rootfs.img', u'/tmp/mnt.pPlkn'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Using nvr: ovirt-node-ng-3.6.5-0.20160420.0
[DEBUG] Calling binary: (['du', '-sxb', u'/tmp/mnt.pPlkn'],) {}
[DEBUG] Calling: (['du', '-sxb', u'/tmp/mnt.pPlkn'],) {'close_fds': True}
[DEBUG] Returned: 1556518035	/tmp/mnt.pPlkn
[DEBUG] Recommeneded base size: 4669554176
[INFO] Starting base creation
[INFO] New base will be: ovirt-node-ng-3.6.5-0.20160420.0
[DEBUG] Calling binary: (['vgs', '--noheadings', '@imgbased:pool', '-o', 'lv_full_name'],) {}
[DEBUG] Calling: (['vgs', '--noheadings', '@imgbased:pool', '-o', 'lv_full_name'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Calling binary: (['umount', u'/tmp/mnt.pPlkn'],) {}
[DEBUG] Calling: (['umount', u'/tmp/mnt.pPlkn'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Calling binary: (['rmdir', u'/tmp/mnt.pPlkn'],) {}
[DEBUG] Calling: (['rmdir', u'/tmp/mnt.pPlkn'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Calling binary: (['umount', u'/tmp/mnt.otxu2'],) {}
[DEBUG] Calling: (['umount', u'/tmp/mnt.otxu2'],) {'close_fds': True}
[DEBUG] Returned: 
[DEBUG] Calling binary: (['rmdir', u'/tmp/mnt.otxu2'],) {}
[DEBUG] Calling: (['rmdir', u'/tmp/mnt.otxu2'],) {'close_fds': True}
[DEBUG] Returned: 
Traceback (most recent call last):
  File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/lib/python2.7/site-packages/imgbased/__main__.py", line 42, in <module>
    CliApplication()
  File "/usr/lib/python2.7/site-packages/imgbased/__init__.py", line 80, in CliApplication
    app.hooks.emit("post-arg-parse", args)
  File "/usr/lib/python2.7/site-packages/imgbased/hooks.py", line 120, in emit
    cb(self.context, *args)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/update.py", line 85, in check_argparse
    .extract(args.FILENAME)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/update.py", line 142, in extract
    "%sB" % size, nvr)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/update.py", line 109, in add_base_with_tree
    lvs)
  File "/usr/lib/python2.7/site-packages/imgbased/imgbase.py", line 246, in add_base
    pool = self._thinpool()
  File "/usr/lib/python2.7/site-packages/imgbased/imgbase.py", line 100, in _thinpool
    return LVM.Thinpool.from_tag(self.thinpool_tag)
  File "/usr/lib/python2.7/site-packages/imgbased/lvm.py", line 169, in from_tag
    assert len(lvs) == 1
AssertionError
warning: %post(ovirt-node-ng-image-update-1:3.6.5-1.20160420.0.el7.noarch) scriptlet failed, exit status 1


Excepted result:
After step3 and step5, can upgrade successfully via update.rpm without error report.

Comment 8 Fabian Deutsch 2016-05-03 10:16:16 UTC
Is this fixed now?

Comment 9 cshao 2016-05-05 10:35:52 UTC
Created attachment 1154159 [details]
yum_update.log

Lots of debug info appear during yum_update.

Test version:
ovirt-node-ng-installer-master-2016050300.iso
imgbased-0.6-0.201604241653git1e3b28f.el7.centos.noarch
ovirt-release-host-node-4.0.0-0.3.master.20160428135304.git037679a.el7.noarch
ovirt-node-ng-image-update-placeholder-4.0.0-0.3.master.20160428135304.git037679a.el7.noarch

Target version:
ovirt-node-ng-image-update.noarch 1:4.0.0-999.20160504.0.el7
ovirt-node-ng-installer-ovirt-3.6-2016050400.iso

Comment 10 Fabian Deutsch 2016-05-06 08:36:39 UTC
Right - debug is okay, we keep this on for now, but is the traceback (which this bug is about) gone?

Comment 11 cshao 2016-05-06 09:38:20 UTC
(In reply to Fabian Deutsch from comment #10)
> Right - debug is okay, we keep this on for now, but is the traceback (which
> this bug is about) gone?

Yes, so can I verify the bug due to the original issue has gone?
If so, I will file a new bug for the debug issue.

Comment 12 Fabian Deutsch 2016-05-06 10:10:33 UTC
Yes

Comment 13 cshao 2016-05-06 10:54:27 UTC
Verify this bug according #c10-c12.

Comment 14 cshao 2016-05-06 12:01:52 UTC
Bug 1333776 can trace the debug issue.

Comment 15 Sandro Bonazzola 2016-07-05 08:00:36 UTC
oVirt 4.0.0 has been released, closing current release.


Note You need to log in before you can comment on or make changes to this bug.