Bug 1324233 - Review Request: python-toolz - A functional standard library for Python
Summary: Review Request: python-toolz - A functional standard library for Python
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-05 22:14 UTC by Orion Poplawski
Modified: 2016-04-11 14:59 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-04-11 14:59:29 UTC
Type: ---
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Orion Poplawski 2016-04-05 22:14:53 UTC
Spec URL: http://www.cora.nwra.com/~orion/fedora/python-toolz.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/python-toolz-0.7.4-1.fc25.src.rpm
Description:

Toolz provides a set of utility functions for iterators, functions, and
dictionaries. These functions interoperate well and form the building blocks
of common data analytic operations. They extend the standard libraries
itertools and functools and borrow heavily from the standard libraries of
 contemporary functional languages.

Toolz provides a suite of functions which have the following functional
virtues:

    Composable: They interoperate due to their use of core data structures.
    Pure: They don’t change their inputs or rely on external state.
    Lazy: They don’t run until absolutely necessary, allowing them to support
          large streaming data sets.

Toolz functions are pragmatic. They understand that most programmers have
deadlines.

    Low Tech: They’re just functions, no syntax or magic tricks to learn
    Tuned: They’re profiled and optimized
    Serializable: They support common solutions for parallel computing

This gives developers the power to write powerful programs to solve complex
problems with relatively simple code. This code can be easy to understand
without sacrificing performance. Toolz enables this approach, commonly
associated with functional programming, within a natural Pythonic style
suitable for most developers.

Fedora Account System Username: orion

Comment 1 Zbigniew Jędrzejewski-Szmek 2016-04-10 23:25:19 UTC
Great that you're packaging that, it's a very nice library. I'm rather surprised that it's not in Fedora yet.

There's a strange indentation in " contemporary functional languages".

Can you add %global _description, and use it in the three places? The description is quite long.

+ license is acceptable (BSD)
+ license file is present, %license is used
+ builds and installs OK
+ requires and provides look sane
+ %python_provide is used
+ standard python template is used
+ no scriptlets present or necessary
+ rpmlint: only bogus spelling errors and missing documentation warnings

Package is APPROVED.

Comment 2 Orion Poplawski 2016-04-11 03:35:09 UTC
Thanks for the review.  I'll use the global for the description.

Comment 3 Gwyn Ciesla 2016-04-11 12:43:14 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-toolz

Comment 4 Orion Poplawski 2016-04-11 14:59:29 UTC
Checked in and built.


Note You need to log in before you can comment on or make changes to this bug.