Hide Forgot
Description of problem: Docker daemon crashed trying to set the mcs label when creating a new container Version-Release number of selected component (if applicable): docker-1.9.1-9.gitee06d03.fc23.x86_64 How reproducible: only ever seen it happen once Steps to Reproduce: 1. sudo _output/local/bin/linux/amd64/openshift start --write-config=openshift.local.config --latest-images 2. sudo _output/local/bin/linux/amd64/openshift start --master-config openshift.local.config/master/master-config.yaml --node-config openshift.local.config/node-f23/node-config.yaml 3. ./test/extended/core.sh -ginkgo.focus "Kubectl client.*Update Demo.*should scale a replication controller" Actual results: Docker daemon crashed Expected results: Docker daemon shouldn't crash Additional info: The test creates 2 pods, scales down to 1, and then back up to 2. I'm guessing that it ends up creating 2 containers at the same time, and because mcsList is a package-level map without a mutex guarding access, there's a race condition - does that sound right? fatal error: bad map state goroutine 29735 [running]: runtime.throw(0x14aa960, 0xd) /usr/lib/golang/src/runtime/panic.go:527 +0x90 fp=0xc821f0c950 sp=0xc821f0c938 runtime.evacuate(0x103e1e0, 0xc82015dd40, 0x4) /usr/lib/golang/src/runtime/hashmap.go:825 +0x3b1 fp=0xc821f0ca10 sp=0xc821f0c950 runtime.growWork(0x103e1e0, 0xc82015dd40, 0xc) /usr/lib/golang/src/runtime/hashmap.go:791 +0x57 fp=0xc821f0ca30 sp=0xc821f0ca10 runtime.mapassign1(0x103e1e0, 0xc82015dd40, 0xc821f0cb18, 0xc821f0cb17) /usr/lib/golang/src/runtime/hashmap.go:433 +0x176 fp=0xc821f0cad8 sp=0xc821f0ca30 github.com/opencontainers/runc/libcontainer/selinux.mcsAdd(0xc820eaf770, 0xc, 0x0, 0x0) /builddir/build/BUILD/docker-ee06d03a4f2e006d94e5de3d246b84713d66daee/vendor/src/github.com/opencontainers/runc/libcontainer/selinux/selinux.go:263 +0xfd fp=0xc821f0cb40 sp=0xc821f0cad8 github.com/opencontainers/runc/libcontainer/selinux.uniqMcs(0x400, 0x0, 0x0) /builddir/build/BUILD/docker-ee06d03a4f2e006d94e5de3d246b84713d66daee/vendor/src/github.com/opencontainers/runc/libcontainer/selinux/selinux.go:313 +0x36a fp=0xc821f0cc10 sp=0xc821f0cb40 github.com/opencontainers/runc/libcontainer/selinux.GetLxcContexts(0xc821c867cb, 0x24, 0xc821c86848, 0x29) /builddir/build/BUILD/docker-ee06d03a4f2e006d94e5de3d246b84713d66daee/vendor/src/github.com/opencontainers/runc/libcontainer/selinux/selinux.go:381 +0x44c fp=0xc821f0ce70 sp=0xc821f0cc10 github.com/opencontainers/runc/libcontainer/label.InitLabels(0xc820eaf6c0, 0x1, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0) /builddir/build/BUILD/docker-ee06d03a4f2e006d94e5de3d246b84713d66daee/vendor/src/github.com/opencontainers/runc/libcontainer/label/label_selinux.go:31 +0xa9 fp=0xc821f0cf98 sp=0xc821f0ce70 github.com/docker/docker/daemon.parseSecurityOpt(0xc821a41400, 0xc820dd4a00, 0x0, 0x0) /builddir/build/BUILD/docker-ee06d03a4f2e006d94e5de3d246b84713d66daee/_build/src/github.com/docker/docker/daemon/daemon_unix.go:64 +0x3be fp=0xc821f0d0d0 sp=0xc821f0cf98 github.com/docker/docker/daemon.(*Daemon).setHostConfig(0xc8201dc640, 0xc821a41400, 0xc820dd4a00, 0x0, 0x0) /builddir/build/BUILD/docker-ee06d03a4f2e006d94e5de3d246b84713d66daee/_build/src/github.com/docker/docker/daemon/daemon.go:1201 +0x5b fp=0xc821f0d130 sp=0xc821f0d0d0 github.com/docker/docker/daemon.(*Daemon).Create(0xc8201dc640, 0xc821b98000, 0xc820dd4a00, 0xc82100a15d, 0x71, 0x0, 0x0, 0x0) /builddir/build/BUILD/docker-ee06d03a4f2e006d94e5de3d246b84713d66daee/_build/src/github.com/docker/docker/daemon/create.go:99 +0x525 fp=0xc821f0d278 sp=0xc821f0d130 github.com/docker/docker/daemon.(*Daemon).ContainerCreate(0xc8201dc640, 0xc82100a15d, 0x71, 0xc821b98000, 0xc820dd4a00, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
Upstream PR https://github.com/opencontainers/runc/pull/735.
https://github.com/projectatomic/docker/pull/94 for backport to rhel 7 docker 1.9
This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component.
This message is a reminder that Fedora 23 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 23. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '23'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 23 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.