Bug 1325648 - Run *.png through zopflipng to save some space
Summary: Run *.png through zopflipng to save some space
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: fedora-logos
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-10 11:22 UTC by Ville Skyttä
Modified: 2016-04-12 17:27 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-04-12 17:27:52 UTC
Type: Bug


Attachments (Terms of Use)
Run *.png through zopflipng -m (3.10 MB, application/x-gzip)
2016-04-10 11:22 UTC, Ville Skyttä
no flags Details
Use zopflipng, add make optimize target (1.00 KB, patch)
2016-04-12 15:43 UTC, Ville Skyttä
no flags Details | Diff

Description Ville Skyttä 2016-04-10 11:22:48 UTC
Created attachment 1145650 [details]
Run *.png through zopflipng -m

Before:
    $ find -name "*.png" | xargs du -cb | tail -n 1
    5290526 total
After:
    $ find -name "*.png" | xargs du -cb | tail -n 1
    5086383 total

"git am"able patch against upstream git attached. It's 3M+ gzipped due to image changes in it.

Comment 1 Tom "spot" Callaway 2016-04-11 14:56:32 UTC
I've committed this change to upstream git for fedora-logos. Is there a need to get this into Fedora 24? It does save some space, but not a huge amount.

Comment 2 Ville Skyttä 2016-04-12 06:52:19 UTC
You be the judge whether to ship it in F24, no strong opinions here.

But the change applied upstream just changes the png's, it lacks the Makefile changes from my patch. (Applying it with "git am" would not have missed it, and would have also preserved authorship information... :))

Comment 3 Tom "spot" Callaway 2016-04-12 15:24:29 UTC
Since I have the habit of wanting to review changes in patchsets manually, I did the conversion locally and then committed the change. I didn't even download the big gz version. Sorry for missing the Makefile changes. If you are willing to make those bits into a git am patch, I'll apply it properly. :)

Also, since I suspect that the Makefile changes actually run zopflipng, please be sure the zopfli package with that binary is on all stable branches first. :)

Comment 4 Ville Skyttä 2016-04-12 15:43:40 UTC
Created attachment 1146525 [details]
Use zopflipng, add make optimize target

Here goes the Makefile patch, just extracted from the original one.

I'm currently building zopfli with zopflipng for F-24. Not sure when or if I will do that to earlier distro versions.

Comment 5 Tom "spot" Callaway 2016-04-12 17:27:52 UTC
Merged. Thanks.


Note You need to log in before you can comment on or make changes to this bug.