Bug 1325816 - 'Run Puppet Once' should use --color false
Summary: 'Run Puppet Once' should use --color false
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Remote Execution
Version: 6.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: Unspecified
Assignee: satellite6-bugs
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-11 09:47 UTC by Maxim Burgerhout
Modified: 2016-04-11 11:47 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-04-11 11:47:16 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Maxim Burgerhout 2016-04-11 09:47:46 UTC
Description of problem:
The 'Run Puppet Once' Job template uses --onetime by default. It's probably a good idea to pass it the (undocumented) option "--color false".

Otherwise, Puppet logs will have ANSI color codes in them, like:

[0;32mInfo: Loading facts in /var/lib/puppet/lib/facter/java_major_version.rb[0m

instead of:

Info: Loading facts in /var/lib/puppet/lib/facter/java_major_version.rb

Apart from that, it might make sense to pass '--test' instead of '--onetime --no-cacheonfailure'. 

The '--test' flag includes '--onetime' and '--no-cacheonfailure', but also gives more detailed logging and enables show_diffs, which is probably what you want if you run manually.

Version-Release number of selected component (if applicable):
SNAP 7.1

How reproducible:


Steps to Reproduce:
1. Run the REX 'Run Puppet Once' job template
2. Check output
3.

Actual results:
Output has ANSI color codes in it

Expected results:
Output should be plain text, without ANSI codes, since we do not parse those in Satellite / Foreman

Additional info:

Comment 1 Maxim Burgerhout 2016-04-11 09:52:39 UTC
Please ignore part about '--test' flag about. This flag also includes '--detailed-exit-codes' which will make Foreman interpret a run with changed resources as failed.

Comment 2 Maxim Burgerhout 2016-04-11 11:47:16 UTC
Argh. Should drink coffee before filing bugs :/


Note You need to log in before you can comment on or make changes to this bug.