Bug 1326151 - Review Request: xfce4-calculator-plugin - A calculator plugin for the Xfce4 panel
Summary: Review Request: xfce4-calculator-plugin - A calculator plugin for the Xfce4 p...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-12 01:13 UTC by Mukundan Ragavan
Modified: 2016-04-24 20:52 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-04-18 17:25:22 UTC
Type: ---
Embargoed:
rdieter: fedora-review+


Attachments (Terms of Use)

Description Mukundan Ragavan 2016-04-12 01:13:19 UTC
Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/xfce4-calculator-plugin/xfce4-calculator-plugin.spec
SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/xfce4-calculator-plugin/xfce4-calculator-plugin-0.5.1-1.fc24.src.rpm

Description:

xfce4-calculator-plugin is a calculator plugin for the Xfce4 panel.

Place the plugin in your panel, enter your calculation into the text field 
and press Enter to calculate the result.

The plugin supports common mathematical operators (+, -, *, /, ^) with usual 
precedence rules and some basic functions (e.g., trigonometric functions) 
and constants.


Fedora Account System Username: nonamedotc

Comment 1 Mukundan Ragavan 2016-04-12 01:20:34 UTC
Some points about review - 

1/
When running fedora-review, this will give an error about .desktop file which is bogus.

.desktop file is installed under %{_datadir}/xfce4/panel-plugins


2/
fedora-review will also complain about FSF address on the license file. I have already reported it upstream.

https://bugzilla.xfce.org/show_bug.cgi?id=12543


3/ 
The package also uses old autotools macros. I am yet to contact upstream about it. The package works without issues though. It also uses old xfce "conventions".

4/
koji scratch build - 

https://koji.fedoraproject.org/koji/taskinfo?taskID=13628690

Comment 2 Rex Dieter 2016-04-12 01:28:07 UTC
I can review (probably tomorrow).

If you're able/willing to swap, would be swell to get bug #1325469 done

Comment 3 Mukundan Ragavan 2016-04-12 01:50:23 UTC
Thanks Rex,

Taken #1325469

Comment 4 Rex Dieter 2016-04-13 17:20:41 UTC
$ rpmlint *.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

naming: ok

sources: ok
8d7bf07a669a2884a409a7b03f89be5c  xfce4-calculator-plugin-0.5.1.tar.bz2

licensing: GPLv2 (current) is mostly OK, but all the source code headers also include:
... either version 2 of the License, or
 *  (at your option) any later version.

1.  SHOULD update license to
License: GPLv2+

macros: ok

scriptlets: ok (icons)

2.  SHOULD review if this is needed
BuildRequires:  xorg-x11-server-devel
(as far as I can tell, it is not)

dir/file ownership: ok



APPROVED.

Consider reviewing the 2 non-blocker SHOULD items.

Comment 5 Mukundan Ragavan 2016-04-13 17:25:05 UTC
You are right. xorg-x11-server-devel is indeed not needed. 

I will fix both items before import. Thanks for the review.

Comment 6 Gwyn Ciesla 2016-04-14 13:06:07 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/xfce4-calculator-plugin

Comment 7 Fedora Update System 2016-04-14 14:28:36 UTC
xfce4-calculator-plugin-0.5.1-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-22503799c6

Comment 8 Fedora Update System 2016-04-14 14:28:42 UTC
xfce4-calculator-plugin-0.5.1-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-2bd13f1360

Comment 9 Fedora Update System 2016-04-14 14:28:47 UTC
xfce4-calculator-plugin-0.5.1-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-585d44b9db

Comment 10 Fedora Update System 2016-04-14 14:28:51 UTC
xfce4-calculator-plugin-0.5.1-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ecfd6df5ec

Comment 11 Fedora Update System 2016-04-15 08:32:02 UTC
xfce4-calculator-plugin-0.5.1-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-585d44b9db

Comment 12 Fedora Update System 2016-04-15 08:37:14 UTC
xfce4-calculator-plugin-0.5.1-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2bd13f1360

Comment 13 Fedora Update System 2016-04-15 12:47:03 UTC
xfce4-calculator-plugin-0.5.1-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ecfd6df5ec

Comment 14 Fedora Update System 2016-04-16 19:25:56 UTC
xfce4-calculator-plugin-0.5.1-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-22503799c6

Comment 15 Fedora Update System 2016-04-18 17:25:20 UTC
xfce4-calculator-plugin-0.5.1-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2016-04-18 22:52:04 UTC
xfwm4-themes-4.10.0-7.el7 xfce4-settings-4.12.0-7.el7 xfce4-xkb-plugin-0.7.1-4.el7 xfce4-smartbookmark-plugin-0.4.6-4.el7 xfce4-datetime-plugin-0.6.2-6.el7 xfce4-equake-plugin-1.3.8-1.el7 xfce4-fsguard-plugin-1.0.2-4.el7 xfce4-hamster-plugin-1.6.1-2.el7 xfce-polkit-0.2-5.el7 xfce4-wavelan-plugin-0.5.12-4.el7 xfce4-cpufreq-plugin-1.1.2-2.el7 xfce4-whiskermenu-plugin-1.5.3-1.el7 xfce4-battery-plugin-1.0.5-11.el7 xfdashboard-0.5.92-3.el7 xfce4-pulseaudio-plugin-0.2.4-4.el7 xfce4-diskperf-plugin-2.5.5-4.el7 xfce4-weather-plugin-0.8.6-3.el7 xfce4-eyes-plugin-4.4.4-3.el7 xfce4-netload-plugin-1.2.4-3.el7 xfce4-sensors-plugin-1.2.5-3.el7 xfce4-genmon-plugin-3.4.0-8.el7 xfce4-mount-plugin-0.6.7-5.el7 xfce4-systemload-plugin-1.1.2-3.el7 xfce4-time-out-plugin-1.0.1-9.el7 thunar-archive-plugin-0.3.1-6.el7 xfce4-cpugraph-plugin-1.0.5-8.el7 xfce4-verve-plugin-1.0.1-4.el7 xfce4-mailwatch-plugin-1.2.0-8.el7 xfce4-screenshooter-1.8.2-5.el7 xfce4-clipman-plugin-1.2.6-5.el7 thunar-volman-0.8.1-2.el7 ristretto-0.8.0-3.el7 parole-0.8.1-2.el7 xfce4-dict-0.7.1-3.el7 xfce4-calculator-plugin-0.5.1-3.el7 xfdesktop-4.12.3-2.el7 xfce4-power-manager-1.6.0-2.el7 xfce4-terminal-0.6.3-4.el7 orage-4.12.1-3.el7 xfce4-session-4.12.1-8.el7 Thunar-1.6.10-4.el7 xfce4-panel-4.12.0-4.el7 xfce4-appfinder-4.12.0-4.el7 xfce4-dev-tools-4.12.0-2.el7 xfce4-notifyd-0.2.4-8.el7 xfwm4-4.12.3-2.el7 garcon-0.4.0-3.el7 exo-0.10.7-1.el7 tumbler-0.1.31-2.el7 libxfce4ui-4.12.1-3.el7 xfconf-4.12.0-3.el7 libxfce4util-4.12.1-2.el7 gtk-xfce-engine-3.2.0-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-262a3f39e1

Comment 17 Fedora Update System 2016-04-24 20:52:36 UTC
xfce4-calculator-plugin-0.5.1-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.