Bug 1326929 - Branding plugin needs more unit test coverage
Summary: Branding plugin needs more unit test coverage
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Branding
Version: 6.1.7
Hardware: Unspecified
OS: Unspecified
unspecified
medium vote
Target Milestone: Unspecified
Assignee: satellite6-bugs
QA Contact: Katello QA List
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-13 19:07 UTC by Eric Helms
Modified: 2018-08-02 21:00 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-08-02 21:00:20 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Eric Helms 2016-04-13 19:07:02 UTC 
There are a few areas that could benefit from added unit tests to catch simple issues such as the helpers file to prevent things like:

<pre>
| ArgumentError: wrong number of arguments (2 for 0..1) | /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_theme_satellite-0.1.7/app/helpers/theme_application_helper.rb:46:in documentation_url'
 | /usr/share/foreman/app/helpers/application_helper.rb:407:indocumentation_button' | /usr/share/foreman/app/helpers/dashboard_helper.rb:21:in `dashboard_actions'
</pre>
Comment 1 Bryan Kearney 2016-07-26 18:59:33 UTC 
Moving 6.2 bugs out to sat-backlog.
Comment 3 Bryan Kearney 2018-08-02 21:00:20 UTC 
Thank you for your interest in Satellite 6. We have evaluated this request, and we do not expect this to be implemented in the product in the forseeable future. We are therefore closing this out as WONTFIX. If you have any concerns about this, please feel free to contact Rich Jerrido or Bryan Kearney. Thank you.
Note You need to log in before you can comment on or make changes to this bug.