Hide Forgot
Description of problem: Seeing rollback and revert option for snapshot, which seems to be same Version-Release number of selected component (if applicable): 10.1.1.1 How reproducible: NA [root@cephqe6 ~]# rbd help snap rollback usage: rbd snap rollback [--pool <pool>] [--image <image>] [--snap <snap>] [--no-progress] <snap-spec> Rollback image to snapshot. Positional arguments <snap-spec> snapshot specification (example: [<pool-name>/]<image-name>@<snapshot-name>) Optional arguments -p [ --pool ] arg pool name --image arg image name --snap arg snapshot name --no-progress disable progress output [root@cephqe6 ~]# rbd help snap revert usage: rbd snap rollback [--pool <pool>] [--image <image>] [--snap <snap>] [--no-progress] <snap-spec> Rollback image to snapshot. Positional arguments <snap-spec> snapshot specification (example: [<pool-name>/]<image-name>@<snapshot-name>) Optional arguments -p [ --pool ] arg pool name --image arg image name --snap arg snapshot name --no-progress disable progress output
This was a valid option in RHCS 1.2 and 1.3 -- there are several examples of commands with aliases. With the new RBD CLI, we denote the alias on the same line as the non-alias within parenthesis: https://github.com/ceph/ceph/blob/master/src/test/cli/rbd/help.t#L72 Did you think this should be changed to an [RFE] ticket to eliminate all aliases from the rbd CLI?
We are not going to be able to remove the aliases (they have existed since before RHCS 2.0). A contributor did ensure that the help message at least matches the alias when help is requested against the alias. Upstream PR: https://github.com/ceph/ceph/pull/8698
Jason, Yes that make sense lets remove all the aliases from RBD CLI, so that there won't be any duplicate command for same operations. I have modified the BUG Description.
If we are changing this to an RFE to remove the aliases, I am going to dev nack it.
Aliases have been supported since before RHCS 1.x -- we have no plans to remove them.