Bug 1327996 - config_opts['use_host_resolv'] is not set back to True if it was False before
Summary: config_opts['use_host_resolv'] is not set back to True if it was False before
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Copr
Classification: Community
Component: backend
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: clime
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-18 08:26 UTC by clime
Modified: 2016-05-05 13:06 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-05 13:06:25 UTC


Attachments (Terms of Use)

Description clime 2016-04-18 08:26:33 UTC
If you build with networking disabled, config_opts['use_host_resolv'] = False is placed into the respective mock chroot config. 

If you enable networking, it does not do anything with chroot configs because it assumes networking is enabled by default. That is not true though if the networking has been disabled before for a chroot config.

In other words, if you build on a builder with networking disabled, that builder will have networking disabled for all consecutive builds (in that build's chroots) and this state cannot be reverted.

Comment 1 clime 2016-04-18 08:35:05 UTC
Sorry, I forgot a reproducer with a package that needs networking enabled:

https://copr.fedorainfracloud.org/coprs/clime/spaceshiftx/build/176049/ -> networking disabled, build fails
https://copr.fedorainfracloud.org/coprs/clime/spaceshiftx/build/176050/ -> networking enabled, the same builder allocated, builds fails
https://copr.fedorainfracloud.org/coprs/clime/spaceshiftx/build/176054/ -> networking enabled, a different builder allocated, build succceeds

Comment 2 clime 2016-04-27 17:58:00 UTC
Fixed by github.com/fedora-copr/copr/commit/7e4f941a

Comment 3 Miroslav Suchý 2016-05-05 13:06:25 UTC
Package including this fix has been deployed on production instance of Copr.


Note You need to log in before you can comment on or make changes to this bug.