Bug 1328841 - ignore virbr0 interface in conncheck list
Summary: ignore virbr0 interface in conncheck list
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: libnice
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Brian Pepple
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-20 12:05 UTC by Fabrice Bellet
Modified: 2017-08-08 14:17 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-08-08 14:17:02 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
interfaces: ignore virbr0 (949 bytes, application/mbox)
2016-04-20 12:05 UTC, Fabrice Bellet
no flags Details

Description Fabrice Bellet 2016-04-20 12:05:30 UTC
Created attachment 1149050 [details]
interfaces: ignore virbr0

Hi!

The way libnice works by collecting local interfaces addresses and making candidate pairs with the list of remote addresses obtained from the remote peer makes it very sensitive to the number of local addresses collected. Roughly, every new local address multiply by two the number of candidate pairs to be checked. If you consider that the remote peer is in the same situation, you double again the number of candidates to be tested.

This has a direct impact on the delay required to establish a connection, because the ICE algorithm of libnice will test each pair at a fixed rate, so the more pairs are to be tested, the more time the algorithm will take to complete.

Pairs related to the virbr0 local interface can almost always (*) be ignored by the ICE algorithm. The virbr0 interface is created by the libvirtd daemon and allows access to the local virtual machines, if any. 

ICE connections between the host and other boxes on the internet have no interest in testing pairs related to this virbr0 interface, because its IP address is private, and outgoing traffic in nat-ted.

And even ICE connections between a host and its virtual machine will work when the virbr0 interface is ignored by the ICE algorithm : the virtual machine has no knowledge of this interface, so it is not concerned, and the host will connect to its virtual machine, (*) as long as it has another local network interface up, with an IP address that the virtual machine can connect to.

This patch is Fedora-specific, because other distros may choose to name this interface with a different name.

Comment 1 Philip Withnall 2016-04-20 14:16:23 UTC
This could be submitted upstream with an AC_ARG_WITH([virtual-bridge-interface-name],…) option added to configure.ac, which determines the name to use instead of virbr0. Distributions can then change their packaging to set --with-virtual-bridge-interface-name=myspecialsnowflakeiface0 in their packaging instead.

Comment 2 Fabrice Bellet 2016-04-21 18:15:33 UTC
Good idea, thanks!

Comment 3 Fedora End Of Life 2016-11-25 07:24:47 UTC
This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '23'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 23 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 4 Fedora End Of Life 2017-07-25 20:35:03 UTC
This message is a reminder that Fedora 24 is nearing its end of life.
Approximately 2 (two) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 24. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '24'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 24 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 5 Fedora End Of Life 2017-08-08 14:17:02 UTC
Fedora 24 changed to end-of-life (EOL) status on 2017-08-08. Fedora 24 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.