Bug 1329416 - Rename sddm fedora breeze variant theme and fix preview screenshot
Summary: Rename sddm fedora breeze variant theme and fix preview screenshot
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: sddm
Version: 23
Hardware: All
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Martin Bříza
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-21 20:57 UTC by Elia Devito
Modified: 2016-12-20 20:04 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-12-20 20:04:38 UTC
Type: Bug


Attachments (Terms of Use)
fedora-breeze screenshot preview (660.21 KB, image/png)
2016-04-21 20:57 UTC, Elia Devito
no flags Details
fedora-sddm (813.93 KB, image/png)
2016-04-21 21:01 UTC, Elia Devito
no flags Details
metadata.desktop for fedora-sddm theme (SOURCE14 on my previous post) (380 bytes, text/plain)
2016-04-22 23:08 UTC, Elia Devito
no flags Details
screenshot of potential fix (175.54 KB, image/png)
2016-04-22 23:12 UTC, Elia Devito
no flags Details

Description Elia Devito 2016-04-21 20:57:17 UTC
Created attachment 1149585 [details]
fedora-breeze screenshot preview

Description of problem:
sddm-kcm show two breeze theme with same screenshot preview

How reproducible:


Steps to Reproduce:
1. Open sddm-kcm

Actual results:
There is two breeze theme

Expected results:
breeze and fedora-breeze

Additional info:
I have maked a sheenshot of fedora-breeze

Comment 1 Elia Devito 2016-04-21 21:01:29 UTC
Created attachment 1149586 [details]
fedora-sddm

I have made a screenshot for old fedora sddm theme, if it helps

Comment 2 Rex Dieter 2016-04-22 02:27:22 UTC
Yeah, having 2 breeze's is probably something we'll have to live with at this point.  it's a consequence of making sure sddm prefers: 01-fedora-breeze (if sddm-breeze installed) and falls-back to using 02-fedora (if sddm-breeze is not installed).

Comment 3 Rex Dieter 2016-04-22 02:30:13 UTC
Ah, but I suppose we can fix the 02-fedora preview

Comment 4 Elia Devito 2016-04-22 23:06:02 UTC
sorry of insistence but I think that this can be fixed.
I have seen plasma-workspace spec file
on row 427 there is:
# make fedora-breeze sddm theme variant.  FIXME/TODO: corrected preview screenshot
cp -alf %{buildroot}%{_datadir}/sddm/themes/breeze/ \
        %{buildroot}%{_datadir}/sddm/themes/01-breeze-fedora
ln -sf  %{_datadir}/backgrounds/default.png \
        %{buildroot}%{_datadir}/sddm/themes/01-breeze-fedora/components/artwork/background.png

I have addedd:
rm -fv  %{buildroot}%{_datadir}/sddm/themes/01-breeze-fedora/metadata.desktop
rm -fv  %{buildroot}%{_datadir}/sddm/themes/01-breeze-fedora/breeze.jpg
install -m 0644 %{SOURCE14} %{buildroot}%{_datadir}/sddm/themes/01-breeze-fedora/metadata.desktop
install -m 0644 %{SOURCE15} %{buildroot}%{_datadir}/sddm/themes/01-breeze-fedora/breeze.jpg 

In this way the problem seem fixed, you can find a patched package on my copr repo:
https://copr.fedorainfracloud.org/coprs/scorpionit/tests/build/180002/

can be this a valid fix?

Comment 5 Elia Devito 2016-04-22 23:08:25 UTC
Created attachment 1149935 [details]
metadata.desktop for fedora-sddm theme (SOURCE14 on my previous post)

Comment 6 Elia Devito 2016-04-22 23:12:00 UTC
Created attachment 1149936 [details]
screenshot of potential fix

Comment 7 Rex Dieter 2016-04-22 23:56:05 UTC
replacing the .desktop file wholesale is possibly dangerous, in case upstream ever changes/fixes things or adds translations

Inserting a different preview risks getting stale or out-of-date too, but that's probably ok (having the right background is probably more important)

Comment 8 Rex Dieter 2016-04-22 23:58:13 UTC
That said, perhaps we could patch the metadata.desktop file or even use 'sed' to insert "Fedora Breeze" into all the Name= keys

(Your version loses all tranlations for example)

Comment 9 Elia Devito 2016-04-23 00:39:36 UTC
sed -i 's/Name\(\[[a-zA-Z\-\_@]*\]\)*=/&Fedora /' %{buildroot}%{_datadir}/sddm/themes/01-breeze-fedora/metadata.desktop
rm -fv  %{buildroot}%{_datadir}/sddm/themes/01-breeze-fedora/breeze.jpg
install -m 0644 %{SOURCE14} %{buildroot}%{_datadir}/sddm/themes/01-breeze-fedora/breeze.jpg 

like this?

Comment 10 Fedora End Of Life 2016-11-25 07:25:55 UTC
This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '23'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 23 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 11 Fedora End Of Life 2016-12-20 20:04:38 UTC
Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.