Bug 1329659 - python syntax error in /usr/sbin/firewalld [NEEDINFO]
Summary: python syntax error in /usr/sbin/firewalld
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: firewalld
Version: 23
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Thomas Woerner
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-22 13:59 UTC by George Kraft
Modified: 2016-07-15 15:57 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-15 15:57:33 UTC
Type: Bug
twoerner: needinfo? (gkraft4ibm)
twoerner: needinfo? (gkraft4ibm)


Attachments (Terms of Use)

Description George Kraft 2016-04-22 13:59:52 UTC
Description of problem:
The firewalld command and gui do not work due to a python syntax error in /usr/sbin/firwalld.  Line 128 had "os.mkdir(config.FIREWALLD_TEMPDIR, 0o770)".  The "o" is a definite mistake.  Secondly, the version of python on F23 does not like the mode argument, so I had to remove it.

Version-Release number of selected component (if applicable):

firewalld.noarch 0.4.0-2.fc23


How reproducible:

dnf install syslog-ng
systemctl start firewalld.service
systemctl enable vncserver@:1.service
cat /var/log/firewalld

Steps to Reproduce:
dnf install syslog-ng
firewall-cmd --permanent --zone=public --add-service vnc-server
firewall-cmd --permanent --zone=public --add-port=5900-5906/tcp
systemctl start firewalld.service
systemctl enable firewalld.service
systemctl start vncserver@:1.service
systemctl enable vncserver@:1.service
cat /var/log/firewalld

Actual results:

firewalld failed to start.  error messages in /var/log/firewalld

Expected results:


Additional info:

Comment 1 Thomas Woerner 2016-04-25 10:19:11 UTC
Which python version are you using on F-23?

Please have a look at:

$ pydoc3 os.mkdir
os.mkdir = mkdir(...)
    mkdir(path, mode=0o777, *, dir_fd=None)
    
    Create a directory.
    
    If dir_fd is not None, it should be a file descriptor open to a directory,
      and path should be relative; path will then be relative to that directory.
    dir_fd may not be implemented on your platform.
      If it is unavailable, using it will raise a NotImplementedError.
    
    The mode argument is ignored on Windows.

Comment 2 Thomas Woerner 2016-06-13 11:56:45 UTC
Is this still an issue for you? There have been an selinux-policy update also that touches this.


Note You need to log in before you can comment on or make changes to this bug.