Bug 1329705 - Catalog content has quick-start as instant-appp
Summary: Catalog content has quick-start as instant-appp
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Online
Classification: Red Hat
Component: Templates
Version: 3.x
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: ---
Assignee: Dan Mace
QA Contact: XiuJuan Wang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-22 16:08 UTC by Steve Speicher
Modified: 2016-06-23 17:32 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-23 17:32:17 UTC
Target Upstream Version:


Attachments (Terms of Use)
screenshot (57.79 KB, image/png)
2016-04-22 16:08 UTC, Steve Speicher
no flags Details

Description Steve Speicher 2016-04-22 16:08:33 UTC
Created attachment 1149837 [details]
screenshot

Description of problem:
Currently only see 2, need to remove nodejs-helloworld-sample

Version-Release number of selected component (if applicable):
hosted dev-preview-int.openshift.com
OpenShift Master:
v3.2.0.16
Kubernetes Master:
v1.2.0-36-g4a3f9c5

How reproducible:
Got to "Add to project" and observe "instant-app" content


Steps to Reproduce:
1. See above and screenshot

Actual results:
2 quick starts 

Expected results:
only 1 quick start (jenkins)

Additional info:

Comment 1 Dan Mace 2016-04-25 19:49:45 UTC
I'll take this one. The way we include the templates in Online currently relies on wildcards with a blacklist, which lets new unapproved templates creep in. We should switch the template script to use a whitelist.

Comment 2 Dan Mace 2016-04-25 19:50:19 UTC
Adding Gabe so he can review the work.

Comment 4 Dan Mace 2016-04-25 21:02:54 UTC
Will be fixed with https://github.com/openshift/online/pull/115

Comment 5 Gabe Montero 2016-04-26 14:15:37 UTC
In case it wasn't understood, the "nodejs-helloworld-sample" is the application sample included with the jenkins instant app.  Literally, the associated template is https://github.com/openshift/origin/blob/master/examples/jenkins/application-template.json

This template fuels the sample job included in the OpenShift Jenkins image.  Without this template, users will not be able to use the sample job.

Steve - are you comfortable with that?

Comment 6 XiuJuan Wang 2016-05-16 09:20:38 UTC
Check in dev-preview-stg (openshift master:v3.2.0.44).
Only jenkins-persistent template is in 'Instant Apps' catalog.
Move bug to verified.


Note You need to log in before you can comment on or make changes to this bug.