Bug 1330719
| Summary: | dpdk_nic_bind --bind=vfio-pci failed to bind mlx4 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Jean-Tsung Hsiao <jhsiao> | ||||||
| Component: | openvswitch-dpdk | Assignee: | Thadeu Lima de Souza Cascardo <cascardo> | ||||||
| Status: | CLOSED CANTFIX | QA Contact: | Jean-Tsung Hsiao <jhsiao> | ||||||
| Severity: | low | Docs Contact: | |||||||
| Priority: | low | ||||||||
| Version: | 7.3 | CC: | aconole, atragler, cascardo, fleitner, jhsiao, kzhang, osabart, rcain, rkhan, weiyongjun | ||||||
| Target Milestone: | rc | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | x86_64 | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2016-09-29 18:18:06 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Jean-Tsung Hsiao
2016-04-26 19:21:59 UTC
Hi, Jean-Tsung. What is the output of dpdk_nic_bind -s? Thanks. Cascardo. Please include the output of the following commands: lspci lspci -vt dmesg dpdk_nic_bind -s Thanks. Created attachment 1151087 [details]
lspci and dpdk_nic_bind -s
see attached log for lspci and "dpdk_nic_bind" info
Agh, I shouldn't have even needed that information. Sorry. We don't ship Mellanox with DPDK 2.2, because at that point in time it required non-upstream library changes. I don't know if that is still the case; I will ask and get back to you. Seems to be the case still, neither mlx4 nor mlx5 comes anywhere near compiling with libibverbs 1.2.0 which is supposed to be the latest version. ...but actually whether the PMD is shipped or not doesn't even come to play at this stage, dpdk_nic_bind knows nothing about the actual DPDK-side driver. The actual catch here is that dpdk_nic_bind thinks the Mellanox device doesn't even exist, or at least is not a NIC at all. From our POV it doesn't matter because it wouldn't work anyway but it does suggest there is a bug, perhaps in dpdk_nic_bind. OTOH if you use driverctl instead of dpdk_nic_bind such issues wont come to play because it doesn't try to be overly clever. Created attachment 1151603 [details]
allows any network class device to be consided by dpdk_nic_bind
This is just to show that we can make dpdk_nic_bind accept other devices as well. In this case, any network devices would be included. On a laptop, this would include a Wifi PCI board, for example. The Mellanox card is a single PCI function that also supports other functions like RoCE, so its configuration is not of an Ethernet class. This patch should work for it too.
As Panu has argued, there is not much point in preventing devices to be bound to vfio-pci. dpdk_nic_bind is just a nice wrapper to verify and change to which driver a device is bound. Binding it to vfio-pci could be done manually as well.
But, please, try this patch and see if it fixes the problem. Maybe it's something DPDK upstream would accept on the basis that mlx4 device requires it.
Cascardo.
Hi, Jean-Tsung. Can you apply the attached patch to the installed version of dpdk_nic_bind and see if that works for you. It's just two lines, you can edit it by hand as well. Thanks. Cascardo. (In reply to Thadeu Lima de Souza Cascardo from comment #9) > Hi, Jean-Tsung. > > Can you apply the attached patch to the installed version of dpdk_nic_bind > and see if that works for you. It's just two lines, you can edit it by hand > as well. > > Thanks. > Cascardo. Hi Cascardo, Yes, the patch works. But, like bnx2x its dpdk is rejected by ovs-dpdk bridge. Network devices using DPDK-compatible driver ============================================ 0000:03:00.0 'MT27520 Family [ConnectX-3 Pro]' drv=vfio-pci unused= ovs-vsctl: Error detected while setting up 'dpdk0'. See ovs-vswitchd log for details. 029d107c-e529-48cf-bca5-36b70b8e3eb8 Bridge "ovsbr0" Port "ovsbr0" Interface "ovsbr0" type: internal Port "dpdk0" Interface "dpdk0" type: dpdk error: "could not open network device dpdk0 (No such device)" Port "int0" Interface "int0" type: internal ovs_version: "2.5.0" OFPST_PORT reply (xid=0x2): 2 ports port LOCAL: rx pkts=0, bytes=0, drop=0, errs=0, frame=0, over=0, crc=0 tx pkts=2, bytes=150, drop=2, errs=0, coll=0 port 1: rx pkts=2, bytes=132, drop=0, errs=0, frame=0, over=0, crc=0 tx pkts=0, bytes=0, drop=0, errs=0, coll=0 As Aaron and Panu have pointed out, we don't ship the mlx4 driver because it requires unreleased software. Panu, do you think this patch could fly upstream? Or do you suggest we just ignore it and just recommend driverctl? Cascardo. Regardless of what we recommend, upstream ought to be interested in the patch because its preventing binding to an otherwise supported (I guess) adapter. Even if others dont care, Mellanox should! Whether its acceptable like or as an additional option to display all network class adapters instead of just ethernet ones I dunno, both seem quite reasonable to me. Submitted upstream. http://dpdk.org/ml/archives/dev/2016-May/038562.html Hi, My understanding is that driverctl can handle this correctly and Thadeu's patch fixing dpdk_nic_bind is merged upstream, so it will land in RHEL at some point. However, we can't enable mlx driver at this point so I am going to close this bug as I don't see anything else left for us to help. If any of you disagree please re-open it. Thanks, fbl |