Bug 1331456 - business-central editors includes "Delete" button for files which are already deleted
Summary: business-central editors includes "Delete" button for files which are already...
Keywords:
Status: CLOSED EOL
Alias: None
Product: JBoss BPMS Platform 6
Classification: Retired
Component: Business Central
Version: 6.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: Tihomir Surdilovic
QA Contact: Lukáš Petrovický
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-28 14:44 UTC by Anton Giertli
Modified: 2020-03-27 19:09 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-03-27 19:09:33 UTC
Type: Bug


Attachments (Terms of Use)
Buttons disabled (12.00 KB, image/png)
2016-04-29 14:42 UTC, manstis
no flags Details

Description Anton Giertli 2016-04-28 14:44:00 UTC
Description of problem:
If you reproduce the issue described here:
https://bugzilla.redhat.com/show_bug.cgi?id=1331452

You'll notice that the editor which attempted to display the given resources still contains "DELETE" button

https://ctrlv.cz/shots/2016/04/28/5Tnz.png

Version-Release number of selected component (if applicable):
BPM suite 6.2.2

How reproducible:
always

Steps to Reproduce:
Reproduce the issue by following steps outlined in
https://bugzilla.redhat.com/show_bug.cgi?id=1331452

Notice that the Web Designer, which is trying to open the deleted resources, still contains the "Delete" button
https://ctrlv.cz/shots/2016/04/28/5Tnz.png

This does not make sense, since clicking on it, another FileNotFound error will be displayed

Actual results:
Delete button is displayed in various editors, for resources which are already deleted

Expected results:
Either make sure that no editor will attempt to open a deleted file under any circumstances, OR make sure that when it does, there will not be any  "Delete" button display, when the resource is deleted as it does not make sense.
Simply including "Close" (X) button would be more suitable.

Additional info:

Comment 2 manstis 2016-04-29 14:42:13 UTC
I checked the Editors extending KieEditor and they already handle this correctly [1][2]. See the attached screen shot. It might be that Designer needs better handling of asset retrieval (when the FileSystem or File cannot be found) as Designer does not use Errai RPC.

[1] https://github.com/droolsjbpm/kie-wb-common/blob/master/kie-wb-common-widgets/kie-wb-metadata-widget/src/main/java/org/kie/workbench/common/widgets/metadata/client/KieEditor.java#L161

[2] https://github.com/droolsjbpm/drools-wb/blob/master/drools-wb-screens/drools-wb-drl-text-editor/drools-wb-drl-text-editor-client/src/main/java/org/drools/workbench/screens/drltext/client/editor/DRLEditorPresenter.java#L102

Comment 3 manstis 2016-04-29 14:42:32 UTC
Created attachment 1152340 [details]
Buttons disabled


Note You need to log in before you can comment on or make changes to this bug.