Hide Forgot
Created attachment 1152109 [details] Patching fixing zcurses and test suite issues. The zcurses module has a bug which prevents you from using "default/default" as a color pair, which is annoying (zsh-nagivation-tools comes up super bright, which is really jarring when I use solarized dark). There's a patch at http://www.zsh.org/mla/workers/2016/msg00889.html While testing this, I found that the test suite fails when I do a mockbuild. This is due to a bad test which tries to detect a noatime filesystem, but mock sets up the chroot such that there's no root filesystem visible in /proc/mounts or df. And even if I fixed that, the test still fails. I suspect that's because I build entirely in tmpfs, though I thought tmpfs supported atime properly. http://www.zsh.org/mla/workers/2016/msg00890.html I'll attach a patch which fixes both of these up and does some specfile cleanup. If you like, I can just commit it, or send a version without the cleanups.
Looks good to me. Feel free to commit it (preferably one commit per issue). However, from long term point of view it would be good to improve the test-suite patch to be acceptable by upstream. The test needs to be skipped if it runs on an unsupported file system *or* if the file system type is not available.
Yeah, I don't actually know why that test is failing for me. tmpfs should support atime just fine, and the filesystem is mounted with relatime just like pretty much every other Linux filesystem these days. But even if I just remove everything but the actual test in the else clause, it still fails. I guess I should print out a stat on each of those files. So far, no upstream response to my message about the broken test. BTW, that's not the only test at issue in C02cont.ztst; we patch two others out as well. I'm not sure how to even detect the situations where either of these tests will fail.
So I did get an update from upstream, and there's a committed fix. However, it turns out I don't need it because everything is just fine if I actually check my mock config and realize that I was building on a filesystem mounted with noatime instead of the tmpfs one I normally use. Oops. Since it doesn't really matter for Fedora I'll drop it for now and let the fix come in with 5.3 (whenever that happens). So really it's just down to the curses thing, which I could build locally, but would then have to deploy to every machine because otherwise znt is broken for me. I'll go ahead and push it later today.
(In reply to Jason Tibbitts from comment #2) > BTW, that's not the only test at issue in C02cont.ztst; we patch two others > out as well. Good point. I was about to drop zsh-test-C02-dev_fd-mock.patch. Does the patch still do anything useful? Do we have any reproducer for the problem that the patch is supposed to resolve?
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle. Changing version to '25'.
This message is a reminder that Fedora 25 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 25. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '25'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 25 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 25 changed to end-of-life (EOL) status on 2017-12-12. Fedora 25 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.