Bug 1331788 - [RFE-Reweight-by-utilization]:- Reweight-by-utilization command should accept parameterized arguments instead of positional parameters
Summary: [RFE-Reweight-by-utilization]:- Reweight-by-utilization command should accept...
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: Red Hat Ceph Storage
Classification: Red Hat
Component: RADOS
Version: 1.3.2
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: rc
: 3.*
Assignee: Sage Weil
QA Contact: ceph-qe-bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-29 13:53 UTC by shylesh
Modified: 2019-01-30 14:59 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-01-30 14:59:59 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description shylesh 2016-04-29 13:53:05 UTC
Description of problem:
As of now "ceph osd reweight-by-utilization" accepts positional parameter, in which argument order should be [oload,max_change, max_osd, --no-increasing].

If user has to specify max_osd then he has to specify max_change otherwise based on position command will assume it as max_change. ex: "ceph osd reweight-by-utilization 200 10"  will consider 10 as max_change while user might think it as max_osd. so if its like "ceph osd reweight-by-utilization --olad <val> --max_change <val> --max_osd <val> " would be better.

Version-Release number of selected component (if applicable):
1.3.2 Async

Comment 3 Sage Weil 2016-04-29 20:28:37 UTC
This is an artifact of the way the CLI works--it is always positional.  The mon protocol is structured in JSON, so the CLI could have a named argument mode, but currently that's not how it works.

Comment 6 Drew Harris 2019-01-30 14:59:59 UTC
I have closed this issue because it has been inactive for some time now. If you feel this still deserves attention feel free to reopen it.


Note You need to log in before you can comment on or make changes to this bug.