Bug 1332230 - storage-setup vars problems
Summary: storage-setup vars problems
Keywords:
Status: CLOSED DUPLICATE of bug 1331855
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: docker-latest
Version: 7.2
Hardware: x86_64
OS: Linux
high
high
Target Milestone: rc
: ---
Assignee: Lokesh Mandvekar
QA Contact: atomic-bugs@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-02 14:43 UTC by Qian Cai
Modified: 2016-05-04 02:31 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-03 15:35:44 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Qian Cai 2016-05-02 14:43:00 UTC
Description of problem:
We have blindly replace docker with docker-latest in /usr/bin/docker-latest-storage-setup even with bash variables. It looks like "-" is not an acceptable identifier in bash. Hence, we ran into troubles like,

May 02 10:30:09 rhel-k8s-storage-node.os1.phx2.redhat.com docker-latest-storage-setup[7853]: /usr/bin/docker-latest-storage-setup: line 372: local: `docker-latest_devmapper_meta_dir=/var/lib/docker-latest/devicemapper/metadata/': not a valid identifier

We need to audit to make sure "-" does not appear in any bash vars there.

Version-Release number of selected component (if applicable):
# rpm -qa | grep docker
docker-forward-journald-1.9.1-38.el7.x86_64
docker-selinux-1.9.1-38.el7.x86_64
docker-common-1.9.1-38.el7.x86_64
docker-rhel-push-plugin-1.10.3-19.el7.x86_64
docker-latest-1.10.3-19.el7.x86_64
docker-lvm-plugin-1.10.3-19.el7.x86_64
docker-1.9.1-38.el7.x86_64
docker-novolume-plugin-1.10.3-19.el7.x86_64

How reproducible:
always

Comment 1 Micah Abbott 2016-05-02 15:01:17 UTC
Looks like a duplicate of this 1331855

Comment 3 Lokesh Mandvekar 2016-05-03 15:35:44 UTC
fix pushed for Bug 1331855

*** This bug has been marked as a duplicate of bug 1331855 ***


Note You need to log in before you can comment on or make changes to this bug.