Bug 1332420 - [intservice_public_226] ServiceExternalIPs check passed when metrics route URL is not reachable
Summary: [intservice_public_226] ServiceExternalIPs check passed when metrics route UR...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: OKD
Classification: Red Hat
Component: oc
Version: 3.x
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Luke Meyer
QA Contact: Wei Sun
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-03 07:29 UTC by Xia Zhao
Modified: 2016-05-05 02:50 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-03 20:36:22 UTC
Target Upstream Version:


Attachments (Terms of Use)

Comment 1 Luke Meyer 2016-05-03 20:36:22 UTC
ServiceExternalIPs has nothing to do with metrics. It is really a regression test for a feature we restricted; you're unlikely to do anything to trigger it.

MetricsApiProxy is the diagnostic that checks the metrics route is working.

Comment 2 Xia Zhao 2016-05-04 06:48:16 UTC
@lmeyer  Since MetricsApiProxy can not tell the metrics route status outside openshift-infra namespace, I thought the option ServiceExternalIPs is used to do it...One thing I want to confirm is: Are we designed to not able to diagnostic the metrics route when metrics is NOT deployed in openshift-infra?

Comment 3 Luke Meyer 2016-05-04 13:59:45 UTC
Yeah, sorry for the confusion, but ServiceExternalIPs is completely unrelated, I just happened to add the two diagnostics in the same PR.

The main purpose of the MetricsApiProxy diagnostic is not testing metrics, but testing that the HPA can work. If metrics is not deployed in openshift-infra, we assume the user didn't want it there - either didn't want metrics at all, or didn't care about the HPA (which is the part that cares about it being in openshift-infra), so there is no point in nagging them via diagnostics.

Comment 4 Luke Meyer 2016-05-04 14:10:08 UTC
However, if we happen to have both the master config and cluster-admin context, it would probably be worthwhile to find the route configured for metrics in the master config (if it's not in openshift-infra) and test the deployment there as well. I created a Trello card for that enhancement https://trello.com/c/MkpqJU6O

Comment 5 Xia Zhao 2016-05-05 02:50:33 UTC
@lmeyer Thanks for the info. The new card looks pretty well! I'm accepting this completed trello cards.


Note You need to log in before you can comment on or make changes to this bug.