Bug 1335288 - Review Request: python3-pyudev - python binding for libudev (EPEL7/python3 only)
Summary: Review Request: python3-pyudev - python binding for libudev (EPEL7/python3 only)
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-11 19:14 UTC by mulhern
Modified: 2016-06-01 18:48 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-01 18:48:10 UTC
Type: ---
Embargoed:
gwync: fedora-review+


Attachments (Terms of Use)

Description mulhern 2016-05-11 19:14:36 UTC
Spec URL: http://mulhern.fedorapeople.org/python3-pyudev/python3-pyudev.spec
SRPM URL: http://mulhern.fedorapeople.org/python3-pyudev/python3-pyudev-0.20.0-1.el7.src.rpm
Description: python binding for libudev (EPEL7/python3 only)
Fedora Account System Username: mulhern

Koji build complete: http://koji.fedoraproject.org/koji/taskinfo?taskID=14013101

This is a minimal build that builds only the core pyudev package only for python 3. It is intended to be used only for branch EPEL 7. It should not conflict with RHEL 7 python-pyudev package, which builds only for python2. The already existing python-pyudev package is expected to continue to handle all non-EPEL 7 pyudev packaging matters.

Comment 1 Gwyn Ciesla 2016-05-12 13:24:52 UTC
Minor spec difference

[limb@tycho ~]$ diff python3-pyudev.spec rpmbuild/SPECS/python3-pyudev.spec 
13,14c13,14
< BuildRequires:    python34-devel
< BuildRequires:    python34-setuptools
---
> BuildRequires:    python3-devel
> BuildRequires:    python3-setuptools
20c20
< Requires:         python34-six
---
> Requires:         python3-six


I'll be reviewing the spec using python34.

Comment 2 Gwyn Ciesla 2016-05-12 13:44:26 UTC
Good:

- rpmlint checks return: 


python3-pyudev.src: W: spelling-error Summary(en_US) libudev -> Libreville
The value of this tag appears to be misspelled. Please double-check.

python3-pyudev.src: W: spelling-error %description -l en_US libudev -> Libreville
The value of this tag appears to be misspelled. Please double-check.

python3-pyudev.src: W: spelling-error %description -l en_US wxPython -> python, Python
The value of this tag appears to be misspelled. Please double-check.

python3-pyudev.src: W: spelling-error %description -l en_US udev -> dude
The value of this tag appears to be misspelled. Please double-check.

1 packages and 0 specfiles checked; 0 errors, 4 warnings.

Ignorable. . .


python3-pyudev.noarch: W: incoherent-version-in-changelog 0.20.0 ['0.20.0-1.fc23', '0.20.0-1']
The latest entry in %changelog contains a version identifier that is not
coherent with the epoch:version-release tuple of the package.

Add the release to the changelog, a la 0.20.0-1


- package meets naming guidelines
- package meets packaging guidelines
- license (LGPLv2+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 



Looks great, just fix the changelog NVR and you're good.

APPROVED.

Comment 3 mulhern 2016-05-12 14:41:36 UTC
Comment #2: thanks!

Comment 4 Gwyn Ciesla 2016-05-12 14:53:15 UTC
Anytime!

Comment 5 Fedora Update System 2016-05-12 19:22:56 UTC
python3-pyudev-0.20.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-3ad7519632

Comment 6 Fedora Update System 2016-05-15 06:25:14 UTC
python3-pyudev-0.20.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-3ad7519632

Comment 7 Fedora Update System 2016-06-01 18:48:08 UTC
python3-pyudev-0.20.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.