Bug 1335901 - Review Request: python-flask-ripozo - An extension for ripozo that brings HATEOAS/REST/Hypermedia APIs to Flask
Summary: Review Request: python-flask-ripozo - An extension for ripozo that brings HAT...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1335878
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-13 13:49 UTC by Miro Hrončok
Modified: 2017-03-23 15:39 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-03-23 15:39:10 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Miro Hrončok 2016-05-13 13:49:45 UTC
Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-flask-ripozo.spec
SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-flask-ripozo-1.0.4-1.fc23.src.rpm

Description:

This package provides a dispatcher for ripozo so that you can integrate ripozo
with Flask. As with all dispatchers it is simply for getting the request
arguments and appropriately routing them to the various resources for handling.

Fedora Account System Username: churchyard

Comment 1 Zbigniew Jędrzejewski-Szmek 2016-08-11 22:55:50 UTC
I'd suggest:
%global _description \
This package provides a dispatcher for ripozo so that you can integrate ripozo \
with Flask. As with all dispatchers it is simply for getting the request       \
arguments and appropriately routing them to the various resources for handling.

%description %_description
%description -n python2-%{pypi_name} %_description
etc.

You don't need to remove .egg-info, this guideline has been rescinded.

cd docs/; make … → make -C docs …
or even just "sphinx-build-3 docs docs/build"

+ package name is OK
+ license is acceptable (GPLv2+)
? license is specified correctly (see below)
+ latest version is packaged
+ modern python packaging template is used
+ %python_provide macro is used
+ P/R/BR look correct
+ no scriptlets necessary
+ %check is present

Why GPLv2+ as opposed to GPLv2? I don't see "or any later version" anywhere.

fedora-review says:
- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 1351680 bytes in 74 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation

Comment 2 Zbigniew Jędrzejewski-Szmek 2017-03-23 12:43:45 UTC
?

Comment 3 Miro Hrončok 2017-03-23 15:39:10 UTC
Oh, I forgot about this one. I'm afraid I don't have the interest for this package anymore and I lack the time to do it just for fun. Sorry about that.


Note You need to log in before you can comment on or make changes to this bug.