Bug 1340943 - Pyzor gives backtrace on UTF-8 errors
Summary: Pyzor gives backtrace on UTF-8 errors
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: pyzor
Version: 28
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-30 19:34 UTC by Göran Uddeborg
Modified: 2018-08-03 20:45 UTC (History)
3 users (show)

Fixed In Version: pyzor-1.0.0-16.20180724git2b8d76d.fc27 pyzor-1.0.0-16.20180724git2b8d76d.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-08-02 15:39:54 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
One triggering message (2.37 KB, application/mbox)
2016-05-30 19:34 UTC, Göran Uddeborg
no flags Details

Description Göran Uddeborg 2016-05-30 19:34:32 UTC
Created attachment 1162964 [details]
One triggering message

Description of problem:
I noticed some of my spamassassin runs gave the following message in the log

maj 30 20:42:09 mimmi spamd[6244]: pyzor: check failed: internal error, python traceback seen in response

I dug up the message that triggered this, and ran it on the command line.  It seems to be yet another instance of Python's problems with non-ascii.

Traceback (most recent call last):
  File "/usr/bin/pyzor", line 429, in <module>
    main()
  File "/usr/bin/pyzor", line 152, in main
    if not dispatch(client, servers, config):
  File "/usr/bin/pyzor", line 258, in check
    for digested in get_input_handler(style):
  File "/usr/bin/pyzor", line 174, in _get_input_msg
    msg = email.message_from_file(sys.stdin)
  File "/usr/lib64/python3.5/email/__init__.py", line 54, in message_from_file
    return Parser(*args, **kws).parse(fp)
  File "/usr/lib64/python3.5/email/parser.py", line 54, in parse
    data = fp.read(8192)
  File "/usr/lib64/python3.5/codecs.py", line 321, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xfa in position 1642: invalid start byte


Version-Release number of selected component (if applicable):
pyzor-1.0.0-8.20160210gitf16e1b6.fc24.noarch
system-python-libs-3.5.1-7.fc24.x86_64

How reproducible:
Every time for this message, but only some mails trigger the problem of course.


Steps to Reproduce:
1. pyzor check < attached-message


Actual results:
Backtrace as above.


Expected results:
No crash, just a result from the check.

Comment 1 Jason Tibbitts 2016-05-31 17:16:03 UTC
This is just another in a list of utf-8 errors that keep cropping up.  Upstream has said that at least some of these are fixed in the current git but there haven't really been many commits not relating to their test suite.

I'll import a new git snapshot and we'll see how it goes.

Comment 2 Fedora End Of Life 2017-07-25 20:56:51 UTC
This message is a reminder that Fedora 24 is nearing its end of life.
Approximately 2 (two) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 24. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '24'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 24 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 3 Göran Uddeborg 2017-07-27 14:14:29 UTC
Still a problem in F26

pyzor-1.0.0-11.20160210gitf16e1b6.fc26.noarch

Comment 4 Fedora End Of Life 2018-05-03 08:04:12 UTC
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 5 Göran Uddeborg 2018-05-08 13:12:08 UTC
The problem remains in F28, pyzor-1.0.0-13.20160210gitf16e1b6.fc28.noarch.

Comment 6 Fedora Update System 2018-07-24 17:35:29 UTC
pyzor-1.0.0-16.20180724git2b8d76d.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-71652c2fdf

Comment 7 Fedora Update System 2018-07-24 17:37:28 UTC
pyzor-1.0.0-16.20180724git2b8d76d.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-17a549ab26

Comment 8 Jason Tibbitts 2018-07-24 18:22:22 UTC
So the bottom line is that I'm pretty sure upstream is just gone at this point and there is no real hope for a release in the foreseeable future.  I pulled together the latest git snapshot and an open PR for a python3 fix and pushed the result to testing.  So far it seems to be better, though it's discouraging that the test suite never found any of these issues.

If problems with python 3.7 crop up, I will almost certainly drop this package from Fedora.  We can't maintain things downstream endlessly while upstream does nothing.

Comment 9 Fedora Update System 2018-07-25 19:13:18 UTC
pyzor-1.0.0-16.20180724git2b8d76d.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-17a549ab26

Comment 10 Fedora Update System 2018-07-25 19:36:16 UTC
pyzor-1.0.0-16.20180724git2b8d76d.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-71652c2fdf

Comment 11 Fedora Update System 2018-07-26 12:00:42 UTC
pyzor-1.0.0-16.20180724git2b8d76d.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-17a549ab26

Comment 12 Göran Uddeborg 2018-07-28 09:52:33 UTC
> If problems with python 3.7 crop up, I will almost certainly drop this package
> from Fedora.  We can't maintain things downstream endlessly while upstream does
> nothing.

It's a pity, but things like that happen.  After all, I'm not prepared to take over upstreams myself, so who am I to complain?

Thanks for your efforts until now!

Comment 13 Fedora Update System 2018-08-02 15:39:54 UTC
pyzor-1.0.0-16.20180724git2b8d76d.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2018-08-03 20:45:36 UTC
pyzor-1.0.0-16.20180724git2b8d76d.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.