Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/sagitter/crawl/crawl.git/plain/crawl.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/sagitter/crawl/fedora-rawhide-x86_64/00323471-crawl/crawl-0.18.1-2.fc25.src.rpm Description: Dungeon Crawl Stone Soup is a free roguelike game of exploration and treasure-hunting in dungeons filled with dangerous and unfriendly monsters in a quest for the mystifyingly fabulous Orb of Zot. Dungeon Crawl Stone Soup has diverse species and many different character backgrounds to choose from, deep tactical game-play, sophisticated magic, religion and skill systems, and a grand variety of monsters to fight and run from, making each game unique and challenging. Fedora Account System Username: sagitter
Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/sagitter/crawl/crawl.git/plain/crawl.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/sagitter/crawl/fedora-rawhide-x86_64/00329388-crawl/crawl-0.18.1-3.fc25.src.rpm - Add an appdata file
Sorry for the delay in getting to this one. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - There are unit tests available, is it feasible to run them? See here: https://github.com/crawl/crawl/blob/master/crawl-ref/docs/develop/testing.txt It may not be, though, because it seems you need to compile with some debugging options set. - According to licensecheck, there are also sources under the MIT license... some of these aren't used (e.g. MSVC/include/dirent.h), but json.cc and worley.cc seem to get built. So you should add "and MIT" to the license field. crawl-0.18.1/crawl-ref/crawl-tiles/MSVC/include/dirent.h crawl-0.18.1/crawl-ref/crawl-tiles/json.cc crawl-0.18.1/crawl-ref/crawl-tiles/json.h crawl-0.18.1/crawl-ref/crawl-tiles/webserver/static/scripts/contrib/jquery.cookie.js crawl-0.18.1/crawl-ref/crawl-tiles/webserver/static/scripts/contrib/jquery.tablesorter.js crawl-0.18.1/crawl-ref/crawl-tiles/worley.cc crawl-0.18.1/crawl-ref/crawl-tiles/worley.h crawl-0.18.1/crawl-ref/source/MSVC/include/dirent.h crawl-0.18.1/crawl-ref/source/json.cc crawl-0.18.1/crawl-ref/source/json.h crawl-0.18.1/crawl-ref/source/webserver/static/scripts/contrib/jquery.cookie.js crawl-0.18.1/crawl-ref/source/webserver/static/scripts/contrib/jquery.tablesorter.js crawl-0.18.1/crawl-ref/source/worley.cc crawl-0.18.1/crawl-ref/source/worley.h fedora-review automatically generated the following issues, but they appear to both be spurious, so I would ignore them: - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 (my comment: this isn't actually an issue, the guidelines have been reworded relatively recently to *not* say that you should assume a compiler is installed. So this isn't something I'd worry about). - gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in crawl-common-data See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache (my comment: they... are, I don't know what fedora-review is talking about here). ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later) (with incorrect FSF address)", "GPL (v3 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "BSD (2 clause)", "BSD (3 clause) GPL (v2 or later)", "*No copyright* MIT/X11 (BSD like)". 1507 files have unknown license. Detailed output of licensecheck in /home/bjr/Programming/fedora/1342743-crawl/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/512x512/apps, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor, /usr/share/icons/hicolor/512x512 These directories *do* have owners, hicolor-icon-theme, so this is not a problem. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 890880 bytes in 32 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in crawl- common-data , crawl-tiles , crawl-tiles-data , crawl-debuginfo (This is fine, the data packages are noarch, the requires appear to be correct). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: crawl-0.18.1-3.fc25.x86_64.rpm crawl-common-data-0.18.1-3.fc25.noarch.rpm crawl-tiles-0.18.1-3.fc25.x86_64.rpm crawl-tiles-data-0.18.1-3.fc25.noarch.rpm crawl-debuginfo-0.18.1-3.fc25.x86_64.rpm crawl-0.18.1-3.fc25.src.rpm crawl.x86_64: W: spelling-error Summary(en_US) Roguelike -> Rogue like, Rogue-like, Rogelio crawl.x86_64: W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses crawl.x86_64: W: spelling-error %description -l en_US roguelike -> rogue like, rogue-like, Rogelio crawl.x86_64: W: spelling-error %description -l en_US mystifyingly -> stiflingly crawl.x86_64: W: no-documentation crawl.x86_64: W: no-manual-page-for-binary crawl crawl-tiles.x86_64: W: spelling-error Summary(en_US) Roguelike -> Rogue like, Rogue-like, Rogelio crawl-tiles.x86_64: W: spelling-error %description -l en_US roguelike -> rogue like, rogue-like, Rogelio crawl-tiles.x86_64: W: spelling-error %description -l en_US mystifyingly -> stiflingly crawl-tiles.x86_64: W: no-documentation crawl-tiles.x86_64: W: no-manual-page-for-binary crawl-tiles crawl-tiles-data.noarch: W: no-documentation crawl-tiles-data.noarch: W: dangling-symlink /usr/share/crawl/dat/tiles/Vera.ttf /usr/share/fonts/bitstream-vera/Vera.ttf crawl-tiles-data.noarch: W: dangling-symlink /usr/share/crawl/dat/tiles/VeraMono.ttf /usr/share/fonts/bitstream-vera/VeraMono.ttf crawl-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/crawl-0.18.1/crawl-ref/crawl-tiles/decks.cc crawl-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/crawl-0.18.1/crawl-ref/source/decks.cc crawl.src: W: spelling-error Summary(en_US) Roguelike -> Rogue like, Rogue-like, Rogelio crawl.src: W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses crawl.src: W: spelling-error %description -l en_US roguelike -> rogue like, rogue-like, Rogelio crawl.src: W: spelling-error %description -l en_US mystifyingly -> stiflingly 6 packages and 0 specfiles checked; 2 errors, 18 warnings. Rpmlint (debuginfo) ------------------- Checking: crawl-debuginfo-0.18.1-3.fc25.x86_64.rpm crawl-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/crawl-0.18.1/crawl-ref/source/decks.cc crawl-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/crawl-0.18.1/crawl-ref/crawl-tiles/decks.cc 1 packages and 0 specfiles checked; 2 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- crawl-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/crawl-0.18.1/crawl-ref/crawl-tiles/decks.cc crawl-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/crawl-0.18.1/crawl-ref/source/decks.cc crawl-tiles-data.noarch: W: no-documentation crawl-tiles-data.noarch: W: dangling-symlink /usr/share/crawl/dat/tiles/VeraMono.ttf /usr/share/fonts/bitstream-vera/VeraMono.ttf crawl-tiles-data.noarch: W: dangling-symlink /usr/share/crawl/dat/tiles/Vera.ttf /usr/share/fonts/bitstream-vera/Vera.ttf crawl.x86_64: W: spelling-error Summary(en_US) Roguelike -> Rogue like, Rogue-like, Rogelio crawl.x86_64: W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses crawl.x86_64: W: spelling-error %description -l en_US roguelike -> rogue like, rogue-like, Rogelio crawl.x86_64: W: spelling-error %description -l en_US mystifyingly -> stiflingly crawl.x86_64: W: no-documentation crawl.x86_64: W: no-manual-page-for-binary crawl crawl-tiles.x86_64: W: spelling-error Summary(en_US) Roguelike -> Rogue like, Rogue-like, Rogelio crawl-tiles.x86_64: W: spelling-error %description -l en_US roguelike -> rogue like, rogue-like, Rogelio crawl-tiles.x86_64: W: spelling-error %description -l en_US mystifyingly -> stiflingly crawl-tiles.x86_64: W: no-documentation crawl-tiles.x86_64: W: no-manual-page-for-binary crawl-tiles 5 packages and 0 specfiles checked; 2 errors, 14 warnings. Requires -------- crawl-debuginfo (rpmlib, GLIBC filtered): crawl-tiles-data (rpmlib, GLIBC filtered): crawl-common-data crawl (rpmlib, GLIBC filtered): /bin/sh crawl-common-data hicolor-icon-theme libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) liblua-5.1.so()(64bit) libm.so.6()(64bit) libncursesw.so.6()(64bit) libpthread.so.0()(64bit) libsqlite3.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libtinfo.so.6()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) crawl-tiles (rpmlib, GLIBC filtered): crawl-tiles-data libGL.so.1()(64bit) libGLU.so.1()(64bit) libSDL2-2.0.so.0()(64bit) libSDL2_image-2.0.so.0()(64bit) libSDL2_mixer-2.0.so.0()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) liblua-5.1.so()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libsqlite3.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) crawl-common-data (rpmlib, GLIBC filtered): Provides -------- crawl-debuginfo: crawl-debuginfo crawl-debuginfo(x86-64) crawl-tiles-data: crawl-tiles-data crawl: crawl crawl(x86-64) crawl-tiles: appdata() appdata(crawl-tiles.appdata.xml) application() application(crawl-tiles.desktop) crawl-tiles crawl-tiles(x86-64) crawl-common-data: crawl-common-data Source checksums ---------------- https://github.com/crawl/crawl/archive/0.18.1.tar.gz#/crawl-0.18.1.tar.gz : CHECKSUM(SHA256) this package : a0e5f5f9c1d9eaf21574c7f6515b05c742d4885f6def2f588c2e013b858bef91 CHECKSUM(SHA256) upstream package : a0e5f5f9c1d9eaf21574c7f6515b05c742d4885f6def2f588c2e013b858bef91 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1342743 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(In reply to Ben Rosser from comment #2) > Sorry for the delay in getting to this one. > > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > ======= > > - There are unit tests available, is it feasible to run them? See here: > https://github.com/crawl/crawl/blob/master/crawl-ref/docs/develop/testing.txt > It may not be, though, because it seems you need to compile with some > debugging options set. It's for debugging only. > > - According to licensecheck, there are also sources under the MIT license... > some of these aren't used (e.g. MSVC/include/dirent.h), but json.cc and > worley.cc seem to get built. So you should add "and MIT" to the license > field. > > crawl-0.18.1/crawl-ref/crawl-tiles/MSVC/include/dirent.h > crawl-0.18.1/crawl-ref/crawl-tiles/json.cc > crawl-0.18.1/crawl-ref/crawl-tiles/json.h > crawl-0.18.1/crawl-ref/crawl-tiles/webserver/static/scripts/contrib/jquery. > cookie.js > crawl-0.18.1/crawl-ref/crawl-tiles/webserver/static/scripts/contrib/jquery. > tablesorter.js > crawl-0.18.1/crawl-ref/crawl-tiles/worley.cc > crawl-0.18.1/crawl-ref/crawl-tiles/worley.h > crawl-0.18.1/crawl-ref/source/MSVC/include/dirent.h > crawl-0.18.1/crawl-ref/source/json.cc > crawl-0.18.1/crawl-ref/source/json.h > crawl-0.18.1/crawl-ref/source/webserver/static/scripts/contrib/jquery.cookie. > js > crawl-0.18.1/crawl-ref/source/webserver/static/scripts/contrib/jquery. > tablesorter.js > crawl-0.18.1/crawl-ref/source/worley.cc > crawl-0.18.1/crawl-ref/source/worley.h Okay, fixed. > > fedora-review automatically generated the following issues, but they appear > to both be spurious, so I would ignore them: > > - All build dependencies are listed in BuildRequires, except for any that > are listed in the exceptions section of Packaging Guidelines. > Note: These BR are not needed: gcc-c++ > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 > > (my comment: this isn't actually an issue, the guidelines have been reworded > relatively recently to *not* say that you should assume a compiler is > installed. So this isn't something I'd worry about). > > - gtk-update-icon-cache is invoked in %postun and %posttrans if package > contains icons. > Note: icons in crawl-common-data > See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache > > (my comment: they... are, I don't know what fedora-review is talking about > here). > 'gtk-update-icon-cache' must be invoked for crawl-common-data sub-package that provides all icons. Fixed. Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/sagitter/crawl/crawl.git/plain/crawl.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/sagitter/crawl/fedora-rawhide-x86_64/00338976-crawl/crawl-0.18.1-4.fc25.src.rpm - Include MIT license - Fix scriptlets for icons
Besides running the unit tests after a package build, defing one of DEBUG, DEBUG_DIAGNOSTICS or DEBUG_TEST may help with further abrt reports, too. Please consider to do so, though I can't tell what's best for abrt, propably DEBUG is sufficient. > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "LGPL (v2.1 or later) (with incorrect FSF address)", "GPL (v3 > or later)", "Unknown or generated", "MIT/X11 (BSD like)", "BSD (2 > clause)", "BSD (3 clause) GPL (v2 or later)", "*No copyright* MIT/X11 > (BSD like)". 1507 files have unknown license. The combined license and the amount of unlicensed files let suspect bundled libraries. You MUST add a license breakdown as comment, what individual file is licensed how. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries
Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/sagitter/crawl/crawl.git/plain/crawl.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/sagitter/crawl/fedora-rawhide-x86_64/00341180-crawl/crawl-0.18.1-5.fc25.src.rpm - Remove unused/bundled files - License clarification - Compile debugging files and make Crawl tests Note. 'crawl -test' looks not playable at build time because the DATADIR directory is set for run-time use only. Also, I reported a presumed bug: https://crawl.develz.org/mantis/view.php?id=10499
I see; well, as the test suite cannot be run, the package is APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later) (with incorrect FSF address)", "GPL (v3 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "BSD (2 clause)", "BSD (3 clause) GPL (v2 or later)", "*No copyright* MIT/X11 (BSD like)". 1507 files have unknown license. Detailed output of licensecheck in /home/bjr/Programming/fedora/1342743-crawl/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/512x512/apps, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor, /usr/share/icons/hicolor/512x512 [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in crawl-common-data [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 890880 bytes in 32 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in crawl- common-data , crawl-tiles , crawl-tiles-data , crawl-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: crawl-0.18.1-5.fc25.x86_64.rpm crawl-common-data-0.18.1-5.fc25.noarch.rpm crawl-tiles-0.18.1-5.fc25.x86_64.rpm crawl-tiles-data-0.18.1-5.fc25.noarch.rpm crawl-debuginfo-0.18.1-5.fc25.x86_64.rpm crawl-0.18.1-5.fc25.src.rpm crawl.x86_64: W: spelling-error Summary(en_US) Roguelike -> Rogue like, Rogue-like, Rogelio crawl.x86_64: W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses crawl.x86_64: W: spelling-error %description -l en_US roguelike -> rogue like, rogue-like, Rogelio crawl.x86_64: W: spelling-error %description -l en_US mystifyingly -> stiflingly crawl.x86_64: W: no-documentation crawl.x86_64: W: no-manual-page-for-binary crawl crawl-tiles.x86_64: W: spelling-error Summary(en_US) Roguelike -> Rogue like, Rogue-like, Rogelio crawl-tiles.x86_64: W: spelling-error %description -l en_US roguelike -> rogue like, rogue-like, Rogelio crawl-tiles.x86_64: W: spelling-error %description -l en_US mystifyingly -> stiflingly crawl-tiles.x86_64: W: no-documentation crawl-tiles.x86_64: W: no-manual-page-for-binary crawl-tiles crawl-tiles-data.noarch: W: no-documentation crawl-tiles-data.noarch: W: dangling-symlink /usr/share/crawl/dat/tiles/Vera.ttf /usr/share/fonts/bitstream-vera/Vera.ttf crawl-tiles-data.noarch: W: dangling-symlink /usr/share/crawl/dat/tiles/VeraMono.ttf /usr/share/fonts/bitstream-vera/VeraMono.ttf crawl-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/crawl-0.18.1/crawl-ref/source/decks.cc crawl-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/crawl-0.18.1/crawl-ref/crawl-tiles/decks.cc crawl.src: W: spelling-error Summary(en_US) Roguelike -> Rogue like, Rogue-like, Rogelio crawl.src: W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses crawl.src: W: spelling-error %description -l en_US roguelike -> rogue like, rogue-like, Rogelio crawl.src: W: spelling-error %description -l en_US mystifyingly -> stiflingly 6 packages and 0 specfiles checked; 2 errors, 18 warnings. Rpmlint (debuginfo) ------------------- Checking: crawl-debuginfo-0.18.1-5.fc25.x86_64.rpm crawl-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/crawl-0.18.1/crawl-ref/source/decks.cc crawl-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/crawl-0.18.1/crawl-ref/crawl-tiles/decks.cc 1 packages and 0 specfiles checked; 2 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory crawl-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/crawl-0.18.1/crawl-ref/crawl-tiles/decks.cc crawl-debuginfo.x86_64: E: script-without-shebang /usr/src/debug/crawl-0.18.1/crawl-ref/source/decks.cc crawl-tiles-data.noarch: W: no-documentation crawl-tiles-data.noarch: W: dangling-symlink /usr/share/crawl/dat/tiles/VeraMono.ttf /usr/share/fonts/bitstream-vera/VeraMono.ttf crawl-tiles-data.noarch: W: dangling-symlink /usr/share/crawl/dat/tiles/Vera.ttf /usr/share/fonts/bitstream-vera/Vera.ttf crawl.x86_64: W: spelling-error Summary(en_US) Roguelike -> Rogue like, Rogue-like, Rogelio crawl.x86_64: W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses crawl.x86_64: W: spelling-error %description -l en_US roguelike -> rogue like, rogue-like, Rogelio crawl.x86_64: W: spelling-error %description -l en_US mystifyingly -> stiflingly crawl.x86_64: W: no-documentation crawl.x86_64: W: no-manual-page-for-binary crawl crawl-tiles.x86_64: W: spelling-error Summary(en_US) Roguelike -> Rogue like, Rogue-like, Rogelio crawl-tiles.x86_64: W: spelling-error %description -l en_US roguelike -> rogue like, rogue-like, Rogelio crawl-tiles.x86_64: W: spelling-error %description -l en_US mystifyingly -> stiflingly crawl-tiles.x86_64: W: no-documentation crawl-tiles.x86_64: W: no-manual-page-for-binary crawl-tiles 5 packages and 0 specfiles checked; 2 errors, 14 warnings. Requires -------- crawl-debuginfo (rpmlib, GLIBC filtered): crawl-tiles-data (rpmlib, GLIBC filtered): crawl-common-data crawl (rpmlib, GLIBC filtered): crawl-common-data hicolor-icon-theme libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) liblua-5.1.so()(64bit) libm.so.6()(64bit) libncursesw.so.6()(64bit) libpthread.so.0()(64bit) libsqlite3.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libtinfo.so.6()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) crawl-tiles (rpmlib, GLIBC filtered): crawl-tiles-data libGL.so.1()(64bit) libGLU.so.1()(64bit) libSDL2-2.0.so.0()(64bit) libSDL2_image-2.0.so.0()(64bit) libSDL2_mixer-2.0.so.0()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) liblua-5.1.so()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libsqlite3.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) crawl-common-data (rpmlib, GLIBC filtered): /bin/sh Provides -------- crawl-debuginfo: crawl-debuginfo crawl-debuginfo(x86-64) crawl-tiles-data: crawl-tiles-data crawl: crawl crawl(x86-64) crawl-tiles: appdata() appdata(crawl-tiles.appdata.xml) application() application(crawl-tiles.desktop) crawl-tiles crawl-tiles(x86-64) crawl-common-data: crawl-common-data Source checksums ---------------- https://github.com/crawl/crawl/archive/0.18.1.tar.gz#/crawl-0.18.1.tar.gz : CHECKSUM(SHA256) this package : a0e5f5f9c1d9eaf21574c7f6515b05c742d4885f6def2f588c2e013b858bef91 CHECKSUM(SHA256) upstream package : a0e5f5f9c1d9eaf21574c7f6515b05c742d4885f6def2f588c2e013b858bef91 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1342743 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/crawl
crawl-0.18.1-5.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-abd83ba897
crawl-0.18.1-5.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-124c422ef0
crawl-0.18.1-5.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-124c422ef0
crawl-0.18.1-5.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-abd83ba897
crawl-0.18.1-5.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
crawl-0.18.1-5.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.