Spec URL: https://bitbucket.org/abregman/bregman-rpms/downloads/python-xunitmerge.spec SRPM URL: https://bitbucket.org/abregman/bregman-rpms/downloads/python-xunitmerge-1.0-4.fc23.src.rpm Description: The primary purpose of xunitmerge is to be able to merge XUnit reports generated by nosetests (e.g. nosetests --with-xunit). This is especially useful when nosetests needs to be run multiple times for different parts of a project and then all reports need to be merged to a single report. Fedora Account System Username: abregman
Updated: Spec URL: https://bitbucket.org/abregman/bregman-rpms/downloads/python-xunitmerge.spec SRPM URL: https://bitbucket.org/abregman/bregman-rpms/downloads/python-xunitmerge-1.0-4.fc23.src.rpm
While running tests, I get the following error: ERROR: xunitmerge (unittest.loader._FailedTest) ---------------------------------------------------------------------- ImportError: Failed to import test module: xunitmerge Traceback (most recent call last): File "/usr/lib64/python3.5/unittest/loader.py", line 462, in _find_test_path package = self._get_module_from_name(name) File "/usr/lib64/python3.5/unittest/loader.py", line 369, in _get_module_from_name __import__(name) File "/builddir/build/BUILD/xunitmerge-1.0/xunitmerge/__init__.py", line 1, in <module> from xmerge import * ImportError: No module named 'xmerge' ---------------------------------------------------------------------- Ran 1 test in 0.000s FAILED (errors=1) RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.28f3WC (%check) Bad exit status from /var/tmp/rpm-tmp.28f3WC (%check) Child return code was: 1 EXCEPTION: [Error()] Traceback (most recent call last): File "/usr/lib/python3.5/site-packages/mockbuild/trace_decorator.py", line 88, in trace result = func(*args, **kw) File "/usr/lib/python3.5/site-packages/mockbuild/util.py", line 547, in do raise exception.Error("Command failed. See logs for output.\n # %s" % (command,), child.returncode) mockbuild.exception.Error: Command failed. See logs for output. # bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps /builddir/build/SPECS/python-xunitmerge.spec Mock Version: 1.2.17
Updated: Spec URL: https://bitbucket.org/abregman/bregman-rpms/downloads/python-xunitmerge-1.0.4-1.fc23.src.rpm SRPM URL: https://bitbucket.org/abregman/bregman-rpms/downloads/python-xunitmerge.spec
Could you please add BuildRequires: python-six BuildRequires: python-nose BuildRequires: python3-six BuildRequires: python3-nose and then for tests: %check %if 0%{?with_python3} nosetests-%{python3_version} --with-doctest %endif nosetests --with-doctest
Builds fine on koji: http://koji.fedoraproject.org/koji/watchlogs?taskID=14422509 The spec looks good to me, for completeness, *my* review is currently blocked by https://bugzilla.redhat.com/show_bug.cgi?id=1247644
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/mrunge/1343895-python- xunitmerge/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-xunitmerge-1.0.4-1.fc23.noarch.rpm python-xunitmerge-1.0.4-1.fc23.src.rpm python-xunitmerge.noarch: W: summary-ended-with-dot C Utility for merging multiple XUnit xml reports into a single xml report. python-xunitmerge.noarch: W: invalid-license Apache-2.0 python-xunitmerge.noarch: W: no-manual-page-for-binary xunitmerge python-xunitmerge.src: W: summary-ended-with-dot C Utility for merging multiple XUnit xml reports into a single xml report. python-xunitmerge.src: W: invalid-license Apache-2.0 2 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- python-xunitmerge.noarch: W: summary-ended-with-dot C Utility for merging multiple XUnit xml reports into a single xml report. python-xunitmerge.noarch: W: invalid-license Apache-2.0 python-xunitmerge.noarch: W: no-manual-page-for-binary xunitmerge 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Requires -------- python-xunitmerge (rpmlib, GLIBC filtered): /usr/bin/python2 python(abi) Provides -------- python-xunitmerge: python-xunitmerge Source checksums ---------------- https://github.com/miki725/xunitmerge/archive/1.0.4.tar.gz#/xunitmerge-1.0.4.tar.gz : CHECKSUM(SHA256) this package : 4f0cf057d253bb1d6f9f377e5299bff9e5aefeb1145840f06c296d45627eb8c5 CHECKSUM(SHA256) upstream package : 4f0cf057d253bb1d6f9f377e5299bff9e5aefeb1145840f06c296d45627eb8c5 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1343895 Buildroot used: fedora-23-armhfp Remaining issue: - the license is actually ASL 2.0 instead of Apache-2.0, see: https://fedoraproject.org/wiki/Licensing:Main#Software_License_List Please fix this and we're ready to go
Thank you. PACKAGE APPROVED You can now proceed and request a new package at https://admin.fedoraproject.org/pkgdb
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-xunitmerge
Package is included in Fedora. Closing this bug.