Bug 1344118 - Kicker icon is not Fedora logo (Rawhide)
Summary: Kicker icon is not Fedora logo (Rawhide)
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: f24-kde-theme
Version: rawhide
Hardware: x86_64
OS: All
unspecified
low
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-06-08 19:37 UTC by Adam Williamson
Modified: 2016-11-01 13:41 UTC (History)
3 users (show)

Fixed In Version: f24-kde-theme-24.5-1 f24-kde-theme-24.5-1.fc24
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-12 15:04:45 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Adam Williamson 2016-06-08 19:37:23 UTC
In current Fedora Rawhide, the KDE Kicker icon is not the Fedora logo as it should be, but some upstream icon. See e.g.:

https://openqa.stg.fedoraproject.org/tests/23268/modules/_graphical_wait_login/steps/8

note the kicker icon (bottom left). Filing on f24-kde-theme as there's no f25-kde-theme yet and I dunno where else to put this.

Comment 1 Rex Dieter 2016-06-09 13:15:31 UTC
This (f24-kde-theme) is the right place, now get to try to figure out why rawhide behaves differently in this regard :(

It's possible recent kf5-5.23.0 (came to rawhide the day before this bug was filed) may have introduced some regression.

Comment 2 Rex Dieter 2016-06-26 11:56:09 UTC
I was finally able to reproduce this testing kf5-5.23.0 on f24.  it appears something changed wrt icon inheritance.  The scriptlet setting application menu tries to use "start-here-kde-fedora" which is present only in oxygen icon theme (provided by fedora-logos).  Oxygen is apparently not (directly) used anymore because breeze is the default icon theme.

So, I'll investigate:
* oxygen/breeze inheritance changes
* consider using fedora-logo-icon (from hicolor) directly instead

Comment 3 Rex Dieter 2016-06-26 14:06:50 UTC
%changelog
* Sun Jun 26 2016 Rex Dieter <rdieter> - 24.5-1
- org.kde.plasma.kickoff.js: use 'start-here' (#1344118)

Comment 4 Fedora Update System 2016-06-26 14:32:00 UTC
f24-kde-theme-24.5-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-41a78a06f8

Comment 5 Fedora Update System 2016-06-26 14:32:58 UTC
kde-settings-23-12.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-abff7c6423

Comment 6 Fedora Update System 2016-06-26 19:24:02 UTC
kde-settings-23-12.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-abff7c6423

Comment 7 Fedora Update System 2016-06-26 19:26:01 UTC
f24-kde-theme-24.5-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-41a78a06f8

Comment 8 Fedora Update System 2016-06-27 18:24:37 UTC
f24-kde-theme-24.5-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2016-07-06 22:38:15 UTC
kde-settings-23-13.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-abff7c6423

Comment 10 Fedora Update System 2016-07-06 22:39:21 UTC
kde-settings-24-7.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b4f4a6efcf

Comment 11 Fedora Update System 2016-07-10 03:55:22 UTC
kde-settings-23-13.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-abff7c6423

Comment 12 Fedora Update System 2016-07-10 16:00:24 UTC
kde-settings-24-7.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b4f4a6efcf

Comment 13 Gerald Cox 2016-07-11 17:20:02 UTC
This update appears to change the kicker logo to the Fedora default for EVERYONE.  Was this the intent?

Comment 14 Rex Dieter 2016-07-11 17:22:02 UTC
The update is supposed to only set the initial default (the first time you use the widget), but any changes you make after that should stay.

Comment 15 Gerald Cox 2016-07-11 17:36:40 UTC
Fair enough... It may well be that breeze was the default when I upgraded - in any event I've changed it now - so will keep an eye out.  Thanks Rex.

Comment 16 Fedora Update System 2016-07-12 15:04:43 UTC
kde-settings-24-7.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2016-07-19 22:24:29 UTC
kde-settings-23-13.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 18 Kevin Kofler 2016-11-01 05:32:39 UTC
You broke remixes with that "fix". We used start-here-kde-fedora for a reason. The point is that start-here-kde-fedora falls back to start-here-kde on remixes that do not ship a start-here icon. Now you set start-here and the icon comes up blank in Kannolo.

Comment 19 Kevin Kofler 2016-11-01 05:35:29 UTC
The right fix is to revert to start-here-kde-fedora and change fedora-logos to also install start-here-kde-fedora to Breeze (on all supported releases, i.e., F23 onwards).

Comment 20 Kevin Kofler 2016-11-01 12:17:40 UTC
I can probably work around this in kannolo-logos with a really ugly hack (ship dangling symlinks start-here→start-here-kde in the Oxygen and Breeze themes that will happen to target the start-here-kde icons from those themes), but that will not fix remixes using generic-logos or their own set of logos.

Comment 21 Kevin Kofler 2016-11-01 12:23:48 UTC
Oh, actually, start-here-kde is now shipped in oxygen/base, so fedora-logos should install start-here-kde-fedora there rather than directly to oxygen, then start-here-kde-fedora will just work, and all that will be left to do is to make yet another change to the Plasma init scriptlets to revert this broken change.

Comment 22 Kevin Kofler 2016-11-01 12:26:28 UTC
Oops, I misspoke: Since Breeze also ships its own start-here-kde, the fd.o lookup algorithm will first fall back from start-here-kde-fedora to start-here-kde before trying the version in oxygen/base or anywhere else. So ignore comment #21, we need to implement comment #19 instead (install the icon to both Oxygen and Breeze).

Comment 23 Kevin Kofler 2016-11-01 12:30:32 UTC
(Sorry for the many comments, I am posting things as I find them.)

Another reason why comment #21 will not work is that Breeze does not actually inherit from Oxygen or even oxygen/base, oxygen/base is not a theme, those are just directories listed in the Oxygen index.theme. So comment #19 is the way to go.

Comment 24 Kevin Kofler 2016-11-01 12:34:57 UTC
And even my workaround from comment #20 can only really be done for Breeze. Oxygen ships its own start-here icon with the Oxygen logo. So if users use Oxygen, they will not get a blank icon, but I also cannot replace it with the KDE logo.

Really, there is a reason why we used that start-here-kde-fedora setup, changing it to start-here was completely the wrong thing to do.

Comment 25 Kevin Kofler 2016-11-01 12:47:08 UTC
And actually, you broke this for Oxygen users even on Fedora (non-remixed), they will get the Oxygen logo instead of the Fedora one!

Comment 26 Rex Dieter 2016-11-01 12:55:55 UTC
Please file a new bug.

That said, the existing javascript can/should be improved (perhaps to check if the icon exists first before trying to set it).

Comment 27 Kevin Kofler 2016-11-01 13:09:50 UTC
Hmmm, Breeze (or more likely, the code) seems to be doing some special magic to start-here-kde. I used this now: https://svn.calcforge.org/viewvc/kannolo/trunk/packages/kannolo-logos/kannolo-logos.spec?r1=205&r2=204&pathrev=205 and now I get a menu icon, but it is a generic icon, and in fact, if I look at the start-here-kde.svg files that Breeze ships, it is the generic icon. Yet, if I change the icon to start-here-kde, I get the KDE logo. Huh?!

So maybe there's more to it than icon theme inheritance.

Comment 28 Kevin Kofler 2016-11-01 13:41:43 UTC
Hmmm, maybe it is overridden by the Plasma theme? In the end, we may have to use different names, like start-here-fedora-kde for the KDE icon (installed by the Oxygen and Breeze theme packages' specfiles) and start-here-fedora-kde-fedora (sic) for the Fedora logo (installed by fedora-logos). What a mess!


Note You need to log in before you can comment on or make changes to this bug.