Bug 1346822 – Fix for 'ofport' query retries during neutron agent start

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1346822 - Fix for 'ofport' query retries during neutron agent start

Summary:	Fix for 'ofport' query retries during neutron agent start

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat OpenStack
Classification:	Red Hat
Component:	openstack-neutron (Show other bugs)
Sub Component:
Version:	9.0 (Mitaka)
Hardware:	Unspecified Unspecified

Priority	unspecified Severity medium
Target Milestone:	ga
Target Release:	9.0 (Mitaka)
Assigned To:	Hynek Mlnarik
QA Contact:	Toni Freger
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2016-06-15 08:05 EDT by Hynek Mlnarik
Modified:	2016-08-15 00:01 EDT (History)
CC List:	6 users (show)

See Also:
Fixed In Version:	openstack-neutron-8.1.2-1.el7ost
Doc Type:	Bug Fix
Doc Text:	Previously, when bridge ports were missing for br-int and br-tun during agent startup, it checked for the patch ports `int-br-ex` and `phy-br-ex` before adding them. However, the function used to check their existence was get_port_ofport(), which retried the check because of the @_ofport_retry decoration. Consequently, this caused the restart to become unnecessarily slow because of the retries. With this update, the existence of ports is checked with port_exists() instead of get_port_ofport(). As a result, no slowdown occurs on startup when the bridge ports are missing for br-int and br-tun.
Story Points:	---
Clone Of:
Environment:
Last Closed:	2016-08-11 08:26:09 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Launchpad	1579769	None	None	None	2016-06-15 08:05 EDT
OpenStack gerrit	319545	None	None	None	2016-06-15 10:25 EDT
Red Hat Product Errata	RHEA-2016:1597	normal	SHIPPED_LIVE	Red Hat OpenStack Platform 9 Release Candidate Advisory	2016-08-11 12:06:52 EDT

Groups: None (edit)

Description Hynek Mlnarik 2016-06-15 08:05:36 EDT

Description of problem:

When bridge ports are missing for br-int and br-tun and agent starts up, it checks for patch ports int-br-ex and phy-br-ex before adding those. But here the function used to check their existence is get_port_ofport() which retries it because of the @_ofport_retry decoration.
This causes the restart to become unnecessarily slow because of the retries. get_port_ofport() should be used only when the port is requested to be created, and the code waits for the ports to be created before proceeding further. We could've just checked for the port's existence with a call to port_exists() on the bridge.

Comment 1 Hynek Mlnarik 2016-07-21 09:47:45 EDT

This bug has been postponed until OSP-9 Neutron gets rebased to upstream stable version 8.1.2 (Mitaka) that includes this patch

Comment 2 Hynek Mlnarik 2016-07-22 02:47:54 EDT

OSP-9 was rebased onto 8.1.2 that includes patch fixing this bug.

Comment 4 Toni Freger 2016-07-27 03:07:49 EDT

Tested on latest OSP8 - openstack-neutron-8.1.2-1.el7ost.noarch
The code verified.

Comment 6 errata-xmlrpc 2016-08-11 08:26:09 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2016-1597.html

Note You need to log in before you can comment on or make changes to this bug.