Bug 1350252 - [REGRESSION] file-5.28 breaks builds
Summary: [REGRESSION] file-5.28 breaks builds
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: file
Version: rawhide
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: ---
Assignee: Kamil Dudka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-06-26 19:10 UTC by Igor Gnatenko
Modified: 2016-07-04 10:47 UTC (History)
5 users (show)

Fixed In Version: file-5.28-2.fc25
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-27 09:46:56 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
[PATCH] Fix crash during uncompression of zlib (RHBZ #1350252) (3.33 KB, patch)
2016-06-26 23:47 UTC, Igor Gnatenko
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1263875 0 unspecified CLOSED file-5.28 is available 2021-02-22 00:41:40 UTC

Internal Links: 1263875

Description Igor Gnatenko 2016-06-26 19:10:32 UTC
#0  0x00007fb37b309a74 in strlcpy (dst=<optimized out>, src=0x0, siz=siz@entry=1048576) at strlcpy.c:40
        d = 0x564679cb7f40 ""
        s = 0x0
        n = 1048575
#1  0x00007fb37b301bb5 in uncompresszlib (
    old=old@entry=0x564679ba0970 "x = fixed\np = partially\n- = not fixed\n\n>>> neurocyp asked if we could use the SF bug tracker from now onwards,\n\tso please use that now to record and manage bugs <<<\n\n[-] - The Original skin's robbo.tt"..., newch=newch@entry=0x7ffe6f4879d0, bytes_max=bytes_max@entry=1048576, n=n@entry=0x7ffe6f4879d8, 
    zlib=zlib@entry=1) at compress.c:520
        rc = <optimized out>
        z = {
          next_in = 0x564679ba0976 "xed\np = partially\n- = not fixed\n\n>>> neurocyp asked if we could use the SF bug tracker from now onwards,\n\tso please use that now to record and manage bugs <<<\n\n[-] - The Original skin's robbo.ttf does"..., avail_in = 11944, total_in = 0, next_out = 0x564679cb7f40 "", avail_out = 1048576, total_out = 0, 
          msg = 0x0, state = 0x564679db7f50, zalloc = 0x7fb37961d370 <zcalloc>, zfree = 0x7fb37961d380 <zcfree>, opaque = 0x0, data_type = 0, adler = 1025533545, 
          reserved = 94860689476488}
#2  0x00007fb37b30228d in uncompressbuf (n=0x7ffe6f4879d8, newch=0x7ffe6f4879d0, 
    old=0x564679ba0970 "x = fixed\np = partially\n- = not fixed\n\n>>> neurocyp asked if we could use the SF bug tracker from now onwards,\n\tso please use that now to record and manage bugs <<<\n\n[-] - The Original skin's robbo.tt"..., method=12, bytes_max=1048576, fd=3) at compress.c:664
        status = 32691
        rv = <optimized out>
        i = <optimized out>
        fdp = {{2043283904, 22086}, {2041469232, 22086}, {1867020912, 32766}}
        r = <optimized out>
#3  file_zmagic (ms=ms@entry=0x564679ae5930, fd=fd@entry=3, 
    name=name@entry=0x564679b20ab0 "/home/brain/rpmbuild/BUILDROOT/gnurobbo-0.68-2.20151113svn415.fc25.x86_64/usr/share/doc/gnurobbo/Bugs", 
    buf=buf@entry=0x564679ba0970 "x = fixed\np = partially\n- = not fixed\n\n>>> neurocyp asked if we could use the SF bug tracker from now onwards,\n\tso please use that now to record and manage bugs <<<\n\n[-] - The Original skin's robbo.tt"..., nbytes=nbytes@entry=11950) at compress.c:216
        zm = <optimized out>
        newbuf = 0x564679cb7f40 ""
        i = 12
        nsz = 11950
        rbuf = <optimized out>
        pb = <optimized out>
        prv = <optimized out>
        rv = 0
        mime = <optimized out>
        osigpipe = 0x1
#4  0x00007fb37b304e04 in file_buffer (ms=ms@entry=0x564679ae5930, fd=fd@entry=3, 
    inname=inname@entry=0x564679b20ab0 "/home/brain/rpmbuild/BUILDROOT/gnurobbo-0.68-2.20151113svn415.fc25.x86_64/usr/share/doc/gnurobbo/Bugs", buf=buf@entry=0x564679ba0970, 
    nb=11950) at funcs.c:222
        m = 0
        rv = 0
---Type <return> to continue, or q <return> to quit---
        looks_text = 1
        ubuf = 0x564679ba0970 "x = fixed\np = partially\n- = not fixed\n\n>>> neurocyp asked if we could use the SF bug tracker from now onwards,\n\tso please use that now to record and manage bugs <<<\n\n[-] - The Original skin's robbo.tt"...
        u8buf = 0x564679ca09c0
        ulen = 11949
        code = 0x7fb37b30c961 "UTF-8 Unicode"
        code_mime = 0x7fb37b30c95b "utf-8"
        type = 0x7fb37b30d9ff "application/octet-stream"
        def = 0x7fb37b30ccf0 "data"
        ftype = 0x7fb37b30c920 "text"
#5  0x00007fb37b2f7fc9 in file_or_fd (ms=ms@entry=0x564679ae5930, 
    inname=inname@entry=0x564679b20ab0 "/home/brain/rpmbuild/BUILDROOT/gnurobbo-0.68-2.20151113svn415.fc25.x86_64/usr/share/doc/gnurobbo/Bugs", fd=3, fd@entry=0)
    at magic.c:521
        rv = -1
        buf = 0x564679ba0970 "x = fixed\np = partially\n- = not fixed\n\n>>> neurocyp asked if we could use the SF bug tracker from now onwards,\n\tso please use that now to record and manage bugs <<<\n\n[-] - The Original skin's robbo.tt"...
        sb = {st_dev = 64771, st_ino = 2885756, st_nlink = 1, st_mode = 33188, st_uid = 1000, st_gid = 1000, __pad0 = 0, st_rdev = 0, st_size = 11950, st_blksize = 4096, 
          st_blocks = 24, st_atim = {tv_sec = 1466967788, tv_nsec = 438181716}, st_mtim = {tv_sec = 1261759985, tv_nsec = 0}, st_ctim = {tv_sec = 1466967788, 
            tv_nsec = 405180665}, __glibc_reserved = {0, 0, 0}}
        nbytes = <optimized out>
        ispipe = <optimized out>
        pos = -1
#6  0x00007fb37b2f84cc in magic_file (ms=ms@entry=0x564679ae5930, 
    inname=inname@entry=0x564679b20ab0 "/home/brain/rpmbuild/BUILDROOT/gnurobbo-0.68-2.20151113svn415.fc25.x86_64/usr/share/doc/gnurobbo/Bugs") at magic.c:399
No locals.
#7  0x00007fb37b7a080d in rpmfcClassify (fc=fc@entry=0x564679b27a30, argv=0x564679b30080, fmode=fmode@entry=0x564679b1fa30) at rpmfc.c:1081
        ftypeId = <optimized out>
        s = 0x564679b20ab0 "/home/brain/rpmbuild/BUILDROOT/gnurobbo-0.68-2.20151113svn415.fc25.x86_64/usr/share/doc/gnurobbo/Bugs"
        slen = <optimized out>
        is_executable = <optimized out>
        ftype = <optimized out>
        fcolor = 0
        mode = <optimized out>
        ix = 4
        ms = 0x564679ae5930
        rc = RPMRC_FAIL
#8  0x00007fb37b7a11ec in rpmfcGenerateDepends (spec=spec@entry=0x564679a4c5f0, pkg=pkg@entry=0x564679a79c20) at rpmfc.c:1376
        fi = <optimized out>
        fc = 0x564679b27a30
        fmode = 0x564679b1fa30
        ac = <optimized out>
---Type <return> to continue, or q <return> to quit---
        genConfigDeps = <optimized out>
        rc = RPMRC_OK
        idx = <optimized out>
        td = {tag = 2041773904, type = 22086, count = 2040923896, data = 0x564679a606e0, flags = 0, ix = 0, size = 2040921744}
#9  0x00007fb37b7938a8 in processBinaryFiles (spec=spec@entry=0x564679a4c5f0, pkgFlags=0, installSpecialDoc=installSpecialDoc@entry=4, test=test@entry=0) at files.c:2183
        nvr = <optimized out>
        a = <optimized out>
        header_color = <optimized out>
        arch_color = <optimized out>
        pkg = <optimized out>
        rc = <optimized out>
#10 0x00007fb37b78f591 in buildSpec (buildArgs=0x5646780ba980 <rpmBTArgs>, spec=0x564679a4c5f0, what=223) at build.c:254
        didBuild = 7
        rc = RPMRC_OK
        test = 0
        cookie = 0x0
#11 0x0000564677eb76ff in buildForTarget (ts=<optimized out>, arg=<optimized out>, ba=0x5646780ba980 <rpmBTArgs>) at rpmbuild.c:518
        buildAmount = 223
        buildRootURL = 0x0
        specFile = 0x564679a4c5b0 "/home/brain/git/fedora/gnurobbo/gnurobbo.spec"
        spec = 0x564679a4c5f0
        rc = 1
        justRm = 0
        specFlags = 0
        buildtree = 0x564677eb7e90 "%{_topdir}:%{_specdir}:%{_sourcedir}:%{_builddir}:%{_rpmdir}:%{_srcrpmdir}:%{_buildrootdir}"
        rootdir = <optimized out>
        st = {st_dev = 64771, st_ino = 1705510, st_nlink = 1, st_mode = 33204, st_uid = 1000, st_gid = 1000, __pad0 = 0, st_rdev = 0, st_size = 7426, st_blksize = 4096, 
          st_blocks = 16, st_atim = {tv_sec = 1466966437, tv_nsec = 98140883}, st_mtim = {tv_sec = 1466966431, tv_nsec = 469961623}, st_ctim = {tv_sec = 1466966431, 
            tv_nsec = 469961623}, __glibc_reserved = {0, 0, 0}}
#12 0x0000564677eb7a0b in build (ts=0x564679a4b830, arg=0x7ffe6f489411 "/home/brain/git/fedora/gnurobbo/gnurobbo.spec", rcfile=0x0, ba=0x5646780ba980 <rpmBTArgs>)
    at rpmbuild.c:551
        rc = 0
        targets = 0x0
        cleanFlags = 0
        vsflags = <optimized out>
        ovsflags = 0
#13 0x0000564677eb6a0b in main (argc=<optimized out>, argv=<optimized out>) at rpmbuild.c:692
        ts = 0x564679a4b830
        bigMode = <optimized out>
        ba = 0x5646780ba980 <rpmBTArgs>
        pkg = <optimized out>
---Type <return> to continue, or q <return> to quit---
        ec = 0
        optCon = 0x5646799fcfa0

Comment 1 Igor Gnatenko 2016-06-26 19:13:25 UTC
I'm bisecting it right now

Comment 2 Raphael Groner 2016-06-26 19:19:55 UTC
some modifications were made to downstream patches, see 
http://pkgs.fedoraproject.org/cgit/rpms/file.git/commit/?id=85d63d0c

Sample builds failing on koschei:
gnurobbo http://koji.fedoraproject.org/koji/taskinfo?taskID=14641354
antlr3   http://koji.fedoraproject.org/koji/taskinfo?taskID=14637400

Comment 3 Kamil Dudka 2016-06-26 20:24:50 UTC
Thanks for the report!  I will have a look at those builds on Monday.

Comment 4 Igor Gnatenko 2016-06-26 20:35:07 UTC
2.25 works fine.


2.26 breaks with:
    Recognition of file "/home/brain/rpmbuild/BUILDROOT/gnurobbo-0.68-2.20151113svn415.fc25.x86_64/usr/bin/gnurobbo" failed: mode 100755 (null)


2.27+ breaks without informative error.

Comment 5 Igor Gnatenko 2016-06-26 21:25:17 UTC
Looks like upstream doesn't test code at all. 80% of commits doesn't compile..

I did git-bisect and results are following.

The first bad commit could be any of:
dd5b22509186bd6ed39c425c09a5e90caf666dee
94da08a5af001db38f096ad7aded69b4815cc1d1
cf31e100e9335d84cc7f068834866cd5f9118ed3
d9e70c212540b39ff1b48b6599345ffedf6fd1f3

Comment 6 Igor Gnatenko 2016-06-26 21:27:28 UTC
Looking into commits only 2 could be case for RPM:
* cf31e100e9335d84cc7f068834866cd5f9118ed3
* d9e70c212540b39ff1b48b6599345ffedf6fd1f3

Comment 7 Igor Gnatenko 2016-06-26 21:32:54 UTC
Tried to revert d9e70c212540b39ff1b48b6599345ffedf6fd1f3 - still failing. So I think bad commit is cf31e100e9335d84cc7f068834866cd5f9118ed3.

Comment 8 Igor Gnatenko 2016-06-26 23:44:16 UTC
https://github.com/file/file/pull/8

Fix sent upstream.

Comment 9 Igor Gnatenko 2016-06-26 23:47:41 UTC
Created attachment 1172702 [details]
[PATCH] Fix crash during uncompression of zlib (RHBZ #1350252)

Use git-am please

Comment 10 Kamil Dudka 2016-06-27 08:10:55 UTC
(In reply to Igor Gnatenko from comment #9)
> Created attachment 1172702 [details]
> [PATCH] Fix crash during uncompression of zlib (RHBZ #1350252)

Thanks for the patch!  Pushed as:

http://pkgs.fedoraproject.org/cgit/rpms/file.git/commit/?id=8744d9e8

Comment 11 Raphael Groner 2016-06-27 08:57:52 UTC
gnurobbo fixed. Thanks!
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14670835

Comment 12 Raphael Groner 2016-06-27 09:24:32 UTC
antlr3 is fixed, too.
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14670988

Next koschei run should notice.

Comment 13 Kamil Dudka 2016-06-27 09:46:56 UTC
Thanks for the confirmation!  Closing...

Comment 14 Elan Ruusamäe 2016-06-27 13:06:27 UTC
> Igor Gnatenko:
> 80% of commits doesn't compile..

commits are compiled by travis
https://travis-ci.org/file/file/builds

the history looks pretty "green" to me

Comment 15 Kamil Dudka 2016-06-27 13:47:08 UTC
(In reply to Elan Ruusamäe from comment #14)
> > Igor Gnatenko:
> > 80% of commits doesn't compile..

It is not clear on which range of commits it was counted, so the number could be misleading.  Nevertheless, I agree with Igor that many of the commits that fail to build are unnecessary and should not have been pushed.

> commits are compiled by travis
> https://travis-ci.org/file/file/builds
> 
> the history looks pretty "green" to me

There are for instance 9 commits in a row that fail to build because of missing file der.h.  Are you aware of anybody from upstream actually watching the builds in Travis CI?

Comment 16 Elan Ruusamäe 2016-06-27 14:20:00 UTC
I'm not sure who follows them, I do hope Christos Zoulas looks at them before making release

Comment 17 Kamil Dudka 2016-06-28 21:46:33 UTC
upstream commit:
https://github.com/file/file/commit/1222ebc0

Comment 18 Igor Gnatenko 2016-06-29 07:05:25 UTC
(In reply to Kamil Dudka from comment #17)
> upstream commit:
> https://github.com/file/file/commit/1222ebc0

without description... reminds me vim.

Developers should learn how to use git.

Comment 19 Elan Ruusamäe 2016-07-04 10:47:07 UTC
agree commit messages should be more informative

aside: it's cvs mirror, not git. read the project description!


Note You need to log in before you can comment on or make changes to this bug.