Description of problem: engine-backup --help still shows options related for reports on 4.0, where reports are no longer available Version-Release number of selected component (if applicable): ovirt-engine-tools-backup-4.0.0.6-0.1.el7ev.noarch How reproducible: always Steps to Reproduce: 1. call engine-backup --help 2. 3. Actual results: it shows obsolete options related to reports Expected results: it should only show relevant options Additional info:
Please consider bug 1340810. A 4.0 engine-backup can restore a 3.6 backup that does include reports. Should we not provide relevant options? If we do, should they not appear in --help? Also, in principle it's possible to restore such a backup, and set up a remote 3.6 reports that uses the restored database. I'd personally close notabug.
Following a discussion last week: Perhaps we do want to do something for *backup*. That is, if you have a system upgraded or migrated from 3.6 with reports, and run engine-backup --mode=backup, do something: 1. Do not backup reports 2. Warn 3. Something else?
(In reply to Yedidyah Bar David from comment #3) > Following a discussion last week: Perhaps we do want to do something for > *backup*. That is, if you have a system upgraded or migrated from 3.6 with > reports, and run engine-backup --mode=backup, do something: > 1. Do not backup reports > 2. Warn > 3. Something else? Not really, the foot print of reports is too small to make a difference. Also someone may realize after upgrade he wants report and revert to backup. I'm moving this back since I think we should not list things in help that are not usable.
(In reply to Yaniv Dary from comment #4) > Not really, the foot print of reports is too small to make a difference. Fine with me. > Also someone may realize after upgrade he wants report and revert to backup. Irrelevant. Someone doing that will revert to 3.6, with the 3.6 code. > > I'm moving this back since I think we should not list things in help that > are not usable. Sorry, no idea what I should do then. Everything in '--help' is usable, if you consider a system upgraded/migrated/restored from a 3.6 backup. You can continue backing up reports, restoring that backup, setup a remote 3.6 reports to use the reports db, etc.
Understood. Moving out with different action item.
Restored summary line. We already have bug 1340810 for the code.
(In reply to Yedidyah Bar David from comment #7) > Restored summary line. We already have bug 1340810 for the code. 1340810 drops the restore, it doesn't remove the code.
(In reply to Yaniv Dary from comment #8) > 1340810 drops the restore, it doesn't remove the code. OK. Now pushed a patch for current bug to drop the Reports help text, and a patch to bug 1340810 to disable Reports backup and restore, with a TODO comment to drop the code in 4.1. I think that's enough for now - please move current bug back to 4.0.something as you see fit. Thanks.
Since the tooling is there for 4.0 and it works, I think we should keep it and remove all the code together in 4.1.
Closing old RFEs, please reopen if still needed. Patches are always welcome.