Bug 135386 - [PATCH] SII 3114 SATA support
Summary: [PATCH] SII 3114 SATA support
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 2.1
Classification: Red Hat
Component: kernel
Version: 2.1
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John W. Linville
QA Contact: Brian Brock
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2004-10-12 13:25 UTC by Bastien Nocera
Modified: 2007-11-30 22:06 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2004-10-19 14:51:09 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
kernel-2.4.21-15.EL-sii-3114.patch (1.55 KB, patch)
2004-10-12 13:27 UTC, Bastien Nocera
no flags Details | Diff

Description Bastien Nocera 2004-10-12 13:25:30 UTC
In linux/drivers/ide/pci/siimage.c
We'd need the addition of the 3114 controller, to be able to use the
SII 3114 as a normal IDE device.
Patch attached below.

In linux/drivers/ide/pci/siimage.c, in init_hwif_siimage(), there
seems to be a bug:
       if(is_sata(hwif) == PCI_DEVICE_ID_SII_3112)
               hwif->busproc   = &siimage_busproc;
is_sata returns an int, which is the return value of pdev_is_data, and
pdev_is_sata only returns 1 or 0.

The machine is a Fujitsu-Siemens v810.

Comment 1 Bastien Nocera 2004-10-12 13:27:27 UTC
Created attachment 105057 [details]
kernel-2.4.21-15.EL-sii-3114.patch

Comment 2 John W. Linville 2004-10-19 14:05:02 UTC
The defect is reported against RHEL 2.1 but the patch is for a RHEL 3
kernel.  Which release is desired?

Comment 4 John W. Linville 2004-10-19 14:51:09 UTC
I ping'ed Jeff Garzik about this:

<linville> there already seems to be some overlap between sata_sil and
siimage w.r.t the Sil 3112 -- any thoughts on whether or not to
continue that for Sil 3114?
<jgarzik> vetoed :)
<jgarzik> use sata_sil
<jgarzik> siimage is unmaintained


Note You need to log in before you can comment on or make changes to this bug.