Bug 13550 - control-panel writes out of bounds
Summary: control-panel writes out of bounds
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Red Hat Linux
Classification: Retired
Component: control-panel
Version: 6.2
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nalin Dahyabhai
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2000-07-06 20:47 UTC by Michal Jaegermann
Modified: 2008-05-01 15:37 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2000-07-06 20:51:18 UTC
Embargoed:


Attachments (Terms of Use)
fix to bad allocation size bug in control-panel (728 bytes, patch)
2000-07-06 20:51 UTC, Michal Jaegermann
no flags Details | Diff

Description Michal Jaegermann 2000-07-06 20:47:13 UTC
control-panel allocates 'buf' of stat_buf.st_size bytes and proceeds
to write at buf[stat_buf.st_size] location.

Attached patch fixes also a minor issue of a type conversion which
kicks in when sizeof(size_t) != sizeof(int).

I thought that I submitted that bug a long time ago but it is still
present in 3.13-1 and bugzilla claims that there are no bugs filed
against control-panel.

  Michal
  michal

Comment 1 Michal Jaegermann 2000-07-06 20:51:17 UTC
Created attachment 918 [details]
fix to bad allocation size bug in control-panel

Comment 2 Nalin Dahyabhai 2000-07-06 21:24:46 UTC
Thanks for the tip.  Some of these fixes had already been integrated into the
CVS tree, but I made another once-over the source file.


Note You need to log in before you can comment on or make changes to this bug.