According to Fedora Packaging Guidelines [1] it would be preferred to have no libraries shipped if they exist in Fedora already. Instead, usbguard should be build against Fedora packages and have a "Requires" in its spec file. This affects: json: Fedora package json spdlog: Fedora package spdlog usbmon: Fedora package usbmon? (unclear: different upstream URL) catch: Fedora package catch PEGTL: I couldn't find any package for that. Version-Release number of selected component (if applicable): 0.5.10 How reproducible: always due to packaging [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries
Hello, I think this is a NOTABUG. Please see the comments bellow. (In reply to Christian Stadelmann from comment #0) > According to Fedora Packaging Guidelines [1] it would be preferred to have > no libraries shipped if they exist in Fedora already. Instead, usbguard > should be build against Fedora packages and have a "Requires" in its spec > file. This affects: > json: Fedora package json > spdlog: Fedora package spdlog There's already: BuildRequires: json-static BuildRequires: spdlog-static --without-bundled-json \ --without-bundled-spdlog \ > usbmon: Fedora package usbmon? (unclear: different upstream URL) usbmon isn't part of the 0.5.10 tarball, is it? > catch: Fedora package catch This is used only at build time for make check. BuildRequires: catch-devel --without-bundled-catch \ > PEGTL: I couldn't find any package for that. Isn't used anywhere at this point. It will used be after I finish the rule parser refactoring at which point I will package PEGTL for fedora (as I did with json and spdlog)
I've seen that it has BuildRequires, but isn't json and spdlog used at runtime, compiled into usbguard? Ok, catch is of course not needed at runtime.
(In reply to Christian Stadelmann from comment #2) > I've seen that it has BuildRequires, but isn't json and spdlog used at > runtime, compiled into usbguard? Those are header-only C++ libraries so there's no .so file to be linked to. FYI: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Packaging_Header_Only_Libraries
Ok, I probably should understand C++ "header-only libraries" before filing bugs like this. Sorry for the noise.