Bug 136531 - initscripts parse ONBOOT and MASTER incorrectly
Summary: initscripts parse ONBOOT and MASTER incorrectly
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 3
Classification: Red Hat
Component: initscripts
Version: 3.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Bill Nottingham
QA Contact: Brock Organ
URL:
Whiteboard:
: 150710 (view as bug list)
Depends On:
Blocks: 132991 132992 137160
TreeView+ depends on / blocked
 
Reported: 2004-10-20 19:24 UTC by Chris Williams
Modified: 2014-03-17 02:49 UTC (History)
3 users (show)

Fixed In Version: RHBA-2005-129
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-04-28 15:21:45 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
ifup patch (1.89 KB, patch)
2004-10-20 19:27 UTC, Chris Williams
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2005:117 0 normal SHIPPED_LIVE initscripts bug fix update 2005-04-28 04:00:00 UTC
Red Hat Product Errata RHBA-2005:123 0 normal SHIPPED_LIVE initscripts bug fix update 2005-05-18 04:00:00 UTC
Red Hat Product Errata RHBA-2005:124 0 normal SHIPPED_LIVE initscripts bug fix update 2005-06-09 04:00:00 UTC
Red Hat Product Errata RHBA-2005:127 0 normal SHIPPED_LIVE hotplug bug fix update 2005-05-19 04:00:00 UTC
Red Hat Product Errata RHBA-2005:129 0 normal SHIPPED_LIVE hotplug bug fix update 2005-06-09 04:00:00 UTC

Description Chris Williams 2004-10-20 19:24:53 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3)
Gecko/20040922

Description of problem:
ifup script takes different paths depending on ONBOOT being set to "no"
vs
"NO." Changing
   if [ "foo$2" = "fooboot" -a "${ONBOOT}" = "no" -o "${ONBOOT}" = "NO"
]
to
   if [ "foo$2" = "fooboot" ] && [ "${ONBOOT}" = "no" -o "${ONBOOT}" =
"NO" ]
seemed to resolve it.

Also, commented lines in ifcfg-eth* files containing "#MASTER"
cause theinterface to be brought up. This is because "MASTER=${DEVICE}"
is grepped for which detects commented lines causing the interface to
be brought up when ifup is called without "boot" as the second
argument. Changing
   for device in `fgrep -l "MASTER=${DEVICE}" 
/etc/sysconfig/network-scripts/ifcfg-*` ; do
to
    for device in `grep -l "^[[:space:]]*MASTER=${DEVICE}" 
/etc/sysconfig/network-scripts/ifcfg-*` ; do
seems to resolve it.



Version-Release number of selected component (if applicable):
initscripts-7.31.16.EL-1

How reproducible:
Always

Steps to Reproduce:
Configure bonding. Try ONBOOT=on or ONBOT=ON in ifcfg-ethx.
Comment MASTER in ifcfg-ethx and bring up bond0.
    

Actual Results:  ONBOOT=on behaves differently than ONBOOT=ON.
Commented lines in ifcfg-ethx files containing "#MASTER"
cause theinterface to be brought up.

Expected Results:  ONBOOT=ON or on, should not be case sensative.
Commenting MASTER should prevent bonding of ethx to the bond interface.

Additional info:

Comment 1 Chris Williams 2004-10-20 19:27:06 UTC
Created attachment 105543 [details]
ifup patch

Comment 4 Bill Nottingham 2005-03-09 22:01:06 UTC
*** Bug 150710 has been marked as a duplicate of this bug. ***

Comment 5 Jay Turner 2005-03-17 13:43:12 UTC
Fixes confirmed in initscripts-7.93.13.EL-1.

Comment 6 Hubert Lin 2005-03-24 11:01:17 UTC
(In reply to comment #5)
> Fixes confirmed in initscripts-7.93.13.EL-1.

Will this fix be included in RHEL4 U1 as well as in RHEL3 U5?



Comment 7 Bill Nottingham 2005-03-24 18:39:09 UTC
It's planned, yes.

Comment 8 John Flanagan 2005-04-28 15:21:45 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2005-117.html


Comment 9 Tim Powers 2005-05-18 15:35:59 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2005-123.html



Note You need to log in before you can comment on or make changes to this bug.