Return back to ON_QA.

Hi Thomas, have you had a chance to verify this in the Alpha compose ?

Sorry, i dont have anymore access to highend hardware, otherwise i would have checked.

ALL TESTS PASSED

SanityOnly verified the patch is included in the freeipmi-1.2.1-9.el6 release as we do not have access to the hardware to verify:

[freeipmi]$ rhpkg switch-branch rhel-6.9
Switched to branch 'rhel-6.9'

[freeipmi]$ rhpkg prep
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.DvpXc8
+ umask 022
+ cd /home/rasibley/git-repo/freeipmi
+ cd /home/rasibley/git-repo/freeipmi
+ rm -rf freeipmi-1.2.1
+ /usr/bin/gzip -dc /home/rasibley/git-repo/freeipmi/freeipmi-1.2.1.tar.gz
+ /usr/bin/tar -xof -
+ STATUS=0
....

[freeipmi]$ git log --oneline --grep=1365477
46174d5 New release (0:1.2.1-9)

[freeipmi]$ git show 46174d5
commit 46174d5a9ed073f9315762d5ccb03f8d035a8363
Author: Boris Ranto <branto>
Date:   Tue Oct 4 22:07:29 2016 +0200

    New release (0:1.2.1-9)
   
    - Fix dereference error
   
    Resolves: rhbz#1365477

diff --git a/0006-Fix-dereference-error.patch b/0006-Fix-dereference-error.patch
new file mode 100644
index 0000000..fcb680a
--- /dev/null
+++ b/0006-Fix-dereference-error.patch
@@ -0,0 +1,43 @@
+From 60fb9d5f801eb7b2742451d04086f0a70f7333a7 Mon Sep 17 00:00:00 2001
+From: chu11 <chu11@f7bdd6f0-feb3-4745-876d-a5d75e847258>
+Date: Thu, 19 Dec 2013 19:33:14 +0000
+Subject: [PATCH] Fix dereference error
+
+---
+ ipmi-sensors/ipmi-sensors.c | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/ipmi-sensors/ipmi-sensors.c b/ipmi-sensors/ipmi-sensors.c
+index 2f0df3f..069c0ea 100644
+--- a/ipmi-sensors/ipmi-sensors.c
++++ b/ipmi-sensors/ipmi-sensors.c
+@@ -500,7 +500,7 @@ _calculate_record_ids (ipmi_sensors_state_data_t *state_data,
+           output_record_ids[(*output_record_ids_length)] = record_id;
+           (*output_record_ids_length)++;
+
+-        if (output_record_ids_length >= MAX_SENSOR_RECORD_IDS)
++        if ((*output_record_ids_length) >= MAX_SENSOR_RECORD_IDS)
+           {
+             pstdout_fprintf (state_data->pstate,
+                              stderr,
+@@ -567,7 +567,7 @@ _calculate_record_ids (ipmi_sensors_state_data_t *state_data,
+           output_record_ids[(*output_record_ids_length)] = state_data->prog_data->args->record_ids[i];
+           (*output_record_ids_length)++;
+
+-        if (output_record_ids_length >= MAX_SENSOR_RECORD_IDS)
++        if ((*output_record_ids_length) >= MAX_SENSOR_RECORD_IDS)
+           {
+             pstdout_fprintf (state_data->pstate,
+                              stderr,
+@@ -637,7 +637,7 @@ _calculate_record_ids (ipmi_sensors_state_data_t *state_data,
+           output_record_ids[(*output_record_ids_length)] = record_id;
+           (*output_record_ids_length)++;
+        
+-        if (output_record_ids_length >= MAX_SENSOR_RECORD_IDS)
++        if ((*output_record_ids_length) >= MAX_SENSOR_RECORD_IDS)
+           {
+             pstdout_fprintf (state_data->pstate,
+                              stderr,
+--
+2.7.4
+
diff --git a/freeipmi.spec b/freeipmi.spec
index 5c23616..c90028d 100644
--- a/freeipmi.spec
+++ b/freeipmi.spec
@@ -2,7 +2,7 @@
 # Copyright (c) 2003-2013 FreeIPMI Core Team
 #
 
-Release: 8%{?dist}
+Release: 9%{?dist}
 
 Name: freeipmi
 Version: 1.2.1
@@ -17,6 +17,7 @@ Patch2: freeipmi-1.2.1-revshortopt.patch
 Patch3: freeipmi-1.2.1-loop-on-select.patch
 Patch4: 0004-Check-record-counts-against-array-length-increase-MA.patch
 Patch5: 0005-Increase-max-record-ids-in-sensor-tools-to-4096.patch
+Patch6: 0006-Fix-dereference-error.patch
 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildRequires: libgcrypt-devel texinfo
 Requires: module-init-tools
@@ -72,6 +73,7 @@ provide data for a number of IPMI detection tools and features.
 %patch3 -p1 -b .looponselect
 %patch4 -p1
 %patch5 -p1
+%patch6 -p1
 
 %build
 export CFLAGS="-D_GNU_SOURCE $RPM_OPT_FLAGS"
@@ -366,6 +368,10 @@ fi
 %{_mandir}/man8/ipmidetectd.8*
 
 %changelog
+* Tue Oct 04 2016 Boris Ranto <branto> - 0:1.2.1-9
+- New release (0:1.2.1-9)
+- Fix dereference error
+
 * Tue Oct 04 2016 Boris Ranto <branto> - 0:1.2.1-8
 - New release (0:1.2.1-8)
 - Check record counts against array length

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2017-0657.html