Bug 1367407 - Review Request: golang-gopkg-go-macaroon-macaroon - A native Go implementation of macaroons
Review Request: golang-gopkg-go-macaroon-macaroon - A native Go implementatio...
Status: CLOSED ERRATA
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Neal Gompa
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2016-08-16 07:13 EDT by Zygmunt Krynicki
Modified: 2016-08-27 06:26 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2016-08-18 17:18:50 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ngompa13: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Zygmunt Krynicki 2016-08-16 07:13:27 EDT
Spec URL: https://fedorapeople.org/~zyga/golang-gopkg-go-macaroon-macaroon.spec
SRPM URL: https://fedorapeople.org/~zyga/golang-gopkg-go-macaroon-macaroon-0-0.1.gitd8fd13e.fc24.src.rpm
Description: 
The macaroon package implements macaroons as described in the paper
"Macaroons: Cookies with Contextual Caveats for Decentralized
Authorization in the Cloud"

Fedora Account System Username: zyga
Comment 1 Neal Gompa 2016-08-16 07:28:20 EDT
I would think that the version would technically be "1" for this, as the API version is 1.
Comment 2 Zygmunt Krynicki 2016-08-16 08:48:38 EDT
Sure. I can bump the version in the fedpkg upload
Comment 3 Zygmunt Krynicki 2016-08-16 08:51:49 EDT
The spec file has been updated to have Version: 1 now. I didn't re-upload the SRPM.

Spec URL: https://fedorapeople.org/~zyga/golang-gopkg-go-macaroon-macaroon.spec
Comment 4 Neal Gompa 2016-08-16 09:04:39 EDT
Taking the review.
Comment 5 Neal Gompa 2016-08-16 09:05:00 EDT
Package was generated through gofed, simplifying the review considerably.

- Conforms to packaging guidelines (gofed generated spec)
- license correct and valid
- only sources installed

Only issue I see is that the changelog entry needs to have the version bumped from "0" to "1", but I'm okay with you doing that on SRPM upload.

Package approved.
Comment 6 Gwyn Ciesla 2016-08-16 09:32:32 EDT
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-gopkg-go-macaroon-macaroon
Comment 7 Fedora Update System 2016-08-17 06:36:47 EDT
golang-gopkg-go-macaroon-macaroon-1-0.1.gitd8fd13e.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c152f91b75
Comment 8 Fedora Update System 2016-08-17 06:43:39 EDT
golang-gopkg-go-macaroon-macaroon-1-0.1.gitd8fd13e.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-212ad0b486
Comment 9 Fedora Update System 2016-08-17 06:45:37 EDT
golang-gopkg-go-macaroon-macaroon-1-0.1.gitd8fd13e.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b31332fa53
Comment 10 Fedora Update System 2016-08-17 15:53:33 EDT
golang-gopkg-go-macaroon-macaroon-1-0.1.gitd8fd13e.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b31332fa53
Comment 11 Fedora Update System 2016-08-17 21:51:17 EDT
golang-gopkg-go-macaroon-macaroon-1-0.1.gitd8fd13e.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c152f91b75
Comment 12 Fedora Update System 2016-08-17 21:51:58 EDT
golang-gopkg-go-macaroon-macaroon-1-0.1.gitd8fd13e.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-212ad0b486
Comment 13 Fedora Update System 2016-08-18 17:18:48 EDT
golang-gopkg-go-macaroon-macaroon-1-0.1.gitd8fd13e.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
Comment 14 Fedora Update System 2016-08-18 19:18:35 EDT
golang-gopkg-go-macaroon-macaroon-1-0.1.gitd8fd13e.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
Comment 15 Fedora Update System 2016-08-27 06:26:36 EDT
golang-gopkg-go-macaroon-macaroon-1-0.1.gitd8fd13e.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.