Created attachment 1191755 [details] Patch to honor smtp_host and not use localhost unless so configured. Description of problem: Despite the setting of smtp_host in /etc/koji-gc/koji-gc.conf or the --smtp-host option at the command-line, koji-gc always connects to the localhost. Version-Release number of selected component (if applicable): koji-utils-1.10.1-10.fc24.noarch How reproducible: always Steps to Reproduce: 1. tail -f /var/log/maillog 2. koji-gc --smtp-host host.domain.org Actual results: If the localhost isn't configured to deliver mail, the connection will eventually timeout and the mail will never be delivered. Expected results: Additional info: From /usr/sbin/koji-gc at line 435: s = smtplib.SMTP(options.smtp_host) This makes the connection to the specified host as it should, but the next line has "s.connect()" which is unnecessary and problematic because it ignores the host passed to SMTP() and will instead default to localhost, potentially causing a timeout and a failure to deliver. This can be clearly seen by looking at the module's source. The example given at https://docs.python.org/2.7/library/smtplib.html?highlight=smtplib#module-smtplib shows that calling connect() is unnecessary. Furthermore, it appears that calling quit() may be more appropriate than close(). The trivial patch attached works for me.
Looks good. Filed here for further review https://pagure.io/koji/pull-request/136
This message is a reminder that Fedora 24 is nearing its end of life. Approximately 2 (two) weeks from now Fedora will stop maintaining and issuing updates for Fedora 24. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '24'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 24 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 24 changed to end-of-life (EOL) status on 2017-08-08. Fedora 24 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.