Hide Forgot
Spec URL: https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-contracts.spec SRPM URL: https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-contracts-0.14.0-1.fc.src.rpm Description: This library provides contracts for Ruby. Contracts let you clearly express how your code behaves, and free you from writing tons of boilerplate, defensive code. Fedora Account System Username: mtasaka scratch build For F-26: http://koji.fedoraproject.org/koji/taskinfo?taskID=15291487
I'll take this for a review.
Generally, the package looks ok => I APPROVE the package. Nevertheless, there are few nits I'd like to clarify: * Integration test suite - Have you tried to execute the integration test suite? * Keeping the integration test suite around - You remove quite a lot of stuff from the package, including the test suite. Nevertheless, you keep around the test suite (features folder). I am wondering what is the reason for this?
Thank you for initial comments! * Integration test suite - Well, there is "rspec spec/" in spec file, do you mean other test suite here? * > you keep around the test suite (features folder) - Well, I think "features" directory explains the "feature" of this gem, i.e. quite similar with "examples". For example, "features/basics/simple_example.feature" explains the basic usage of this gem.
(In reply to Mamoru TASAKA from comment #3) > Thank you for initial comments! I said I approve the package but forgot to set review+, sorry ... > * Integration test suite > - Well, there is "rspec spec/" in spec file, do you mean other > test suite here? > > * > you keep around the test suite (features folder) > - Well, I think "features" directory explains the "feature" of this > gem, i.e. quite similar with "examples". > For example, "features/basics/simple_example.feature" explains the > basic usage of this gem. Actually, these two bullets are more or less one bullet then, since the features directory contains the test suite in question if I am not mistaken. That should be executable using Cucumber. In theory, calling "cucumber" command should be enough to execute it.
Okay, thank you. I will look at features/ directory later. And thank you for approving!
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-contracts
Imported into rawhide. thank you!