Hide Forgot
Description of problem: When click "Add environment variable", it often focus on the previous row, reproduces mostly on Firefox48 Version-Release number of selected component (if applicable): openshift v1.3.0-alpha.3+31f6add-dirty(commit 1c4709f) kubernetes v1.3.0+507d3a7 etcd 2.3.0+git How reproducible: Often on Firefox Steps to Reproduce: 1.Create app from image 2.Go to Builds Environment tab 3.Click "Add environment variable" Actual results: 3. After clicking "Add environment variable", it will focus on the previous row(refer to attachment) Expected results: 3. Should focus on the new added blank row Additional info:
Created attachment 1193158 [details] WrongFocus
PR https://github.com/openshift/origin-web-console/pull/465
Commit pushed to master at https://github.com/openshift/origin-web-console https://github.com/openshift/origin-web-console/commit/2207f9a24edfd817966fc7fead7a9a46769acc01 Update kve, fix bug #1369315, tested in Chrome, FF, Safari, IE
Found PR already merged in v3.3.0.30: [root@PC ~]$ cd ~/github.com/openshift/ose [root@PC ose]$ git log --pretty="%h %cd - %s" v3.3.0.30 | grep 'Bump' | head -n 5 efc0955 Thu Sep 1 11:58:10 2016 -0400 - Bump origin-web-console (7d59453) 929913a Tue Aug 30 17:56:10 2016 -0400 - Bump origin-web-console (39ffada) 1501117 Fri Aug 26 12:25:27 2016 -0400 - Bump origin-web-console (b0cc495) 0a43160 Thu Aug 25 15:21:14 2016 -0400 - Bump origin-web-console (98cd97c) 0f0228d Wed Aug 24 16:47:38 2016 -0400 - Bump origin-web-console (18a0d95) [root@PC ose]$ cd ~/github.com/openshift/origin-web-console [root@PC origin-web-console]$ git log --pretty="%h %cd - %s" 7d59453 | grep '2207f9a' 2207f9a Tue Aug 23 16:32:02 2016 -0400 - Update kve, fix bug #1369315, tested in Chrome, FF, Safari, IE From above, the commit in comment 3 is included in v3.3.0.30. But the problem is still reproduced in today v3.3.0.30 test
*** Bug 1448830 has been marked as a duplicate of this bug. ***
Is this still an exiting bug? I'm not seeing it on FireFox.
> How reproducible: > Often on Firefox As comment 0 says, it was "Often". I reviewed the draft before the reporter submitted the bug, I can remember it was indeed "Often". But now I only reproduced one time after many times try when I only click "Add Environment Variable" (when the bug was reported, it only has "Add Environment Variable") However, now console has "Add Environment Variable Using a Config Map or Secret", if I click it, the wrong focus can be easily *ALWAYS* reproduced, see following attachment
Created attachment 1294921 [details] Still_wrong_when_clicking_Add-Environment-Variable-Using-a-Config-Map
A PR opened to improve sorting behavior may also help this issue: https://github.com/openshift/origin-web-console/pull/1962
PR merged: https://github.com/openshift/origin-web-console/pull/1962 Xingxing, is it possible to evaluate this again & see if we have further reduced the often,always,rarely?
Ben, Clicking "Add Value" could always set correct focus. Clicking "Add Value from Config Map or Secret" could set correct focus except for the first time. The first time clicking on "Add Value from Config Map or Secret" will set focus on the previous key-value-editor entry. Could we fix the wrong focus when clicking the first time? Or should we leave it as it is?
Checked on v3.9.0-alpha.3+b41d1da-127
Hi Ben, could you help confirm comment 12?
I was able to reproduce this and definitely think we can take a look at getting it addressed. Moving it back to assigned.
Opened PR https://github.com/openshift/origin-web-console/pull/2726
We are no longer addressing bugs for 3.x versions unless there is an important security related issue.