Bug 1369725 - Build step 'tag openshift image' in webpage is close to right in jenkins webpage
Summary: Build step 'tag openshift image' in webpage is close to right in jenkins web...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: ImageStreams
Version: 3.3.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: ---
Assignee: Gabe Montero
QA Contact: Wang Haoran
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-24 08:49 UTC by wewang
Modified: 2017-03-08 18:26 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
undefined
Clone Of:
Environment:
Last Closed: 2016-09-27 09:10:37 UTC
Target Upstream Version:


Attachments (Terms of Use)
tag openshift image page (80.36 KB, image/png)
2016-08-24 08:50 UTC, wewang
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1937 0 normal SHIPPED_LIVE Red Hat OpenShift Enterprise Jenkins image bug fix and enhancement update 2016-09-27 13:05:12 UTC

Comment 1 wewang 2016-08-24 08:50:12 UTC
Created attachment 1193546 [details]
tag openshift image page

Comment 2 Gabe Montero 2016-08-24 16:45:34 UTC
This is because the jenkins taglibs scroll all the fields out right past the length of the longest field description.

In the case of tag images, this field description:

"The authorization token for the default service account of the project for the new tag (only needed if the new tag is targeted for a different project than the project containing the current tag)"

is fairly long with explanation / detail in the description itself (vs. in the help).  I went down this path because users were not thinking to read the field help or README and were getting hung up with this.

I'll experiment and see if I can add a newline to break up the length.  I'm hesitant to only have the details in the help, and am more inclined to favor helpfulness over look and feel, but we can discuss further if it comes to that decision.

Comment 3 Gabe Montero 2016-08-24 16:51:42 UTC
Adding a \n into the description did not break up the line.

I'll poll for some opinions on the pros/cons of changing the text as noted in #Comment 2

Comment 4 Gabe Montero 2016-08-24 18:14:21 UTC
OK, Ben and I discussed, and I'll remove some of the additional text in that one field description.

We briefly discussed adding a special warning for the field (so more yellow text below) ... I'll see about adding that.

Comment 5 Gabe Montero 2016-08-24 18:52:05 UTC
OK ... addressed with commit https://github.com/openshift/jenkins-plugin/commit/da456adb31811b54cc7fc01031e89e27d554bf8d

Will move onto QA when new plugin version / rpm / image is ready.

Comment 6 Gabe Montero 2016-08-25 23:42:49 UTC
brew pulp latest has v1.0.22 of the plugin

QE can attempt to verify

Comment 7 wewang 2016-08-26 02:44:02 UTC
verified in 
openshift3/jenkins-1-rhel7 023723e2e0ff

Comment 9 errata-xmlrpc 2016-09-27 09:10:37 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1937


Note You need to log in before you can comment on or make changes to this bug.