Bug 1369840 - different types returned as the Percent property of Job objects
Summary: different types returned as the Percent property of Job objects
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: LVM and device-mapper
Classification: Community
Component: lvm2
Version: 2.02.164
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: LVM and device-mapper development team
QA Contact: cluster-qe@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-24 14:18 UTC by Vratislav Podzimek
Modified: 2016-09-12 13:46 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-09-12 13:46:53 UTC
rule-engine: lvm-technical-solution?
rule-engine: lvm-test-coverage?

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Comment 2 Tony Asleson 2016-08-25 03:36:45 UTC 
The introspection actually is showing a 'y' == byte.  Unfortunately the python dbus library is picking the most appropriate type based on the value.  In some cases the value is faked because we don't have something returned from lvm and in other cases it's the actual value.

I will change it to always return a double.
Comment 3 Vratislav Podzimek 2016-08-25 11:27:50 UTC 
(In reply to Tony Asleson from comment #2)
> The introspection actually is showing a 'y' == byte.  Unfortunately the
> python dbus library is picking the most appropriate type based on the value.
Exactly, it for example returns '1' as "i" (i.e. INT32).

> In some cases the value is faked because we don't have something returned
> from lvm and in other cases it's the actual value.
Understood.

> 
> I will change it to always return a double.
Thanks!
Comment 4 Tony Asleson 2016-08-29 21:49:52 UTC 
Fixed upstream

https://lists.fedorahosted.org/archives/list/lvm2-commits@lists.fedorahosted.org/thread/FFQPGS5JEYRZH3GA3HXXQ45CPUMLPTC4/
Comment 5 Vratislav Podzimek 2016-08-31 06:28:28 UTC 
(In reply to Tony Asleson from comment #4)
> Fixed upstream
> 
> https://lists.fedorahosted.org/archives/list/lvm2-commits@lists.fedorahosted.
> org/thread/FFQPGS5JEYRZH3GA3HXXQ45CPUMLPTC4/

Looks good to me, thanks!
Note You need to log in before you can comment on or make changes to this bug.