Bug 1370213 - failed to attach data center with host 4.0 to master data storage domain (nfs)
Summary: failed to attach data center with host 4.0 to master data storage domain (nfs)
Keywords:
Status: CLOSED WORKSFORME
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.0.3
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified vote
Target Milestone: ovirt-4.0.6
: ---
Assignee: Liron Aravot
QA Contact: Natalie Gavrielov
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-25 14:31 UTC by Sharon Gratch
Modified: 2016-10-31 12:33 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-10-31 12:33:50 UTC
oVirt Team: Storage
amureini: ovirt-4.0.z?
rule-engine: planning_ack?
rule-engine: devel_ack?
rule-engine: testing_ack?


Attachments (Terms of Use)
engine log (2.98 MB, text/plain)
2016-08-25 14:31 UTC, Sharon Gratch
no flags Details
vdsm log of the SPM host (14.93 MB, text/plain)
2016-08-25 14:35 UTC, Sharon Gratch
no flags Details

Description Sharon Gratch 2016-08-25 14:31:45 UTC
Created attachment 1194045 [details]
engine log

Description of problem:
failed to attach new master storage domain (NFS) for data center 4.0 with host 4.0.
a null pointer exception appears in the engine log:
2016-08-25 16:58:08,946 ERROR [org.ovirt.engine.core.vdsbroker.irsbroker.IrsBrokerCommand] (default task-44) [67cb0a3c] ERROR, ActivateStorageDomainVDSCommand( ActivateStorageDomainVDSCommandParameters:{runAsync='true', storagePoolId='eabfb1fa-6b3c-4763-a30f-6324d5e8f33c', ignoreFailoverLimit='false', storageDomainId='6aed252d-394e-4a94-9437-9d130f3804af'}), exception: null, log id: 78b6c55f
2016-08-25 16:58:08,946 ERROR [org.ovirt.engine.core.vdsbroker.irsbroker.IrsBrokerCommand] (default task-44) [67cb0a3c] Exception: java.lang.NullPointerException
	at org.ovirt.vdsm.jsonrpc.client.ResponseDecomposer.decomposeResponse(ResponseDecomposer.java:58) [vdsm-jsonrpc-java-client.jar:]
	at org.ovirt.engine.core.vdsbroker.jsonrpc.FutureMap.populate(FutureMap.java:136) [vdsbroker.jar:]
	at org.ovirt.engine.core.vdsbroker.jsonrpc.FutureMap.lazyEval(FutureMap.java:112) [vdsbroker.jar:]
	at org.ovirt.engine.core.vdsbroker.jsonrpc.FutureMap.get(FutureMap.java:247) [vdsbroker.jar:]
	at org.ovirt.engine.core.vdsbroker.irsbroker.StorageStatusReturnForXmlRpc.<init>(StorageStatusReturnForXmlRpc.java:15) [vdsbroker.jar:]
	at org.ovirt.engine.core.vdsbroker.jsonrpc.JsonRpcIIrsServer.activateStorageDomain(JsonRpcIIrsServer.java:230) [vdsbroker.jar:]



How reproducible:
on my engine - 100%

Steps to Reproduce:
1.create a new dc with compatibility version = 4.0
2.add 4.0 host to this dc
3.create a new storage domain and attach it to the data center created in (1) and choose the host in (2) as spm

Actual results:
The new storage domain in initialized and the host is declared as spm but the storage domain become inactive and a null ptr exception appears in engine log

Expected results:
the storage domain should be active and attached to the data center.

Additional info:
vdsm and engine logs are attached

Comment 1 Sharon Gratch 2016-08-25 14:35:20 UTC
Created attachment 1194048 [details]
vdsm log of the SPM host

Comment 2 Allon Mureinik 2016-08-25 14:52:23 UTC
Liron, can you take a look please?
The NPE looks very familiar...

Comment 3 Liron Aravot 2016-08-30 14:15:13 UTC
Allon, we had BZ 1359788 recently but the issue there is different than on this bug.

Elad - can you check if that reproduces on your env? (I'm asking as that's an easy reproduction).
Sharon - Do you use that latest vdsm-jsonrpc-java-client? i suspect that that's the problem.

Comment 4 Sharon Gratch 2016-09-01 12:40:57 UTC
(In reply to Liron Aravot from comment #3)
> Sharon - Do you use that latest vdsm-jsonrpc-java-client? i suspect that
> that's the problem.

What do you mean by "latest"? The bug reproduced with host 4.0, 
vdsm-jsonrpc version:4.18.999 (release: 96.git658dc69.fc23).

Comment 5 Aharon Canan 2016-09-07 11:50:17 UTC
Restoring needinfo on QE following comment #3

Comment 6 Natalie Gavrielov 2016-09-07 14:37:59 UTC
(In reply to Aharon Canan from comment #5)
> Restoring needinfo on QE following comment #3

> Elad - can you check if that reproduces on your env? (I'm asking as that's
> an easy reproduction).

Not sure how relevant it is now, but I followed the steps to reproduce using 4.0.4, and was unable to reproduce.

Builds:
ovirt-engine-4.0.4-0.1.el7ev.noarch
vdsm-4.18.12-1.el7ev.x86_64
vdsm-jsonrpc-4.18.12-1.el7ev.noarch

Comment 7 Sharon Gratch 2016-09-11 12:53:48 UTC
I re-installed the vdsm on my machine using version vdsm-4.18.12-11 and it is not reproduced anymore. 

builds:
ovirt-engine-4.0.4
vdsm-4.18.12-11
vdsm-jsonrpc-4.18.12

So I guess there was a problem with the previous vdsm version installed on my machine (vdsm version:4.18.999 (release: 96.git658dc69.fc23).
Therefore, I'm not sure if it is a bug or maybe a problematic master version.

Comment 8 Allon Mureinik 2016-09-11 13:38:12 UTC
Nothing catches my eye in the git log between 658dc69 and v4.18.12, but the fact of the matter is that this upgrade seems to solve the issue.

Liron - please take a look. If there's nothing more we want to do here, feel free to close as CURRENT_RELEASE.

Sharon - Thanks for reporting this!

Comment 9 Liron Aravot 2016-09-11 14:00:42 UTC
Sharon, i was referring to the vdsm-jsonrpc-java-client jar, you can check the version in your maven repository.

(usually ~/.m2/repository/org/ovirt/vdsm-jsonrpc-java/vdsm-jsonrpc-java-client/).

Comment 10 Sharon Gratch 2016-09-13 10:04:08 UTC
(In reply to Liron Aravot from comment #9)
> Sharon, i was referring to the vdsm-jsonrpc-java-client jar, you can check
> the version in your maven repository.
> 
> (usually
> ~/.m2/repository/org/ovirt/vdsm-jsonrpc-java/vdsm-jsonrpc-java-client/).

The vdsm-jsonrpc-java-client jar version I an using is 1.2.5:
vdsm-jsonrpc-java-client-1.2.5.jar

Comment 11 Tal Nisan 2016-10-31 12:33:50 UTC
Seems like it only happened in a specific development environment and wasn't able to be reproduced by QE, closing.


Note You need to log in before you can comment on or make changes to this bug.