Spec URL: https://jorti.fedorapeople.org/python-fuse/python-fuse.spec SRPM URL: https://jorti.fedorapeople.org/python-fuse/python-fuse-2.0.4-1.fc24.src.rpm Description: fusepy is a Python module that provides a simple interface to FUSE and MacFUSE. It's just one file and is implemented using ctypes. Fedora Account System Username: jorti
Hi Juan, I have some recommendations for you. * Is there any reason for defining `commit` and `shortcommit` macros? I would be more benefitial to define `srcname` macro for "fuse". * The `Source0` url should create directory which is named `%{srcname}-%{version}.tar.gz`, not just `%{version}.tar.gz`. (You can just add `#/%{srcname}-%{version}.tar.gz` to your current url.) * You do not have to rewrite summary manually. Just reuse the first Summary tag with the %{summary} macro. * "If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it."
Hi, thanks for the comments. I've updated the macros as you said. I will ask upstream to include a license file. Spec URL: https://jorti.fedorapeople.org/python-fuse/python-fuse.spec SRPM URL: https://jorti.fedorapeople.org/python-fuse/python-fuse-2.0.4-2.fc25.src.rpm
This is the request to upstream to include the license text as a saparate file: https://github.com/terencehonles/fusepy/issues/59
+ latest version + package name is OK + license is acceptable (ISC) + license is specified correctly + standard python packaging template is used + %python_provide is present + provides/requires look OK + no scriptlets present or required Package is APPROVED.
Thank you. Just tell me if you want me to review one of yours.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-fuse