Hide Forgot
Spec URL: https://adelton.fedorapeople.org/perl-Test-Toolbox.spec SRPM URL: https://adelton.fedorapeople.org/perl-Test-Toolbox-0.4-1.fc24.src.rpm Description: Test::Toolbox provides tools for automated testing, much like other testing modules, such as Test::More and Test::Simple. Test::Toolbox provides a different flavor of tests. Fedora Account System Username: adelton
New version of String::Util seems to need Test::Toolbox for build time.
Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed FIX: Please add following build-requires - coreutils - perl-Test-Toolbox.spec:32 - perl(Exporter) - Test-Toolbox-0.4/lib/Test/Toolbox.pm:108 $ rpm -qp --requires perl-Test-Toolbox-0.4-1.fc26.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(Carp) 1 perl(Cwd) 1 perl(Exporter) 1 perl(Test::Builder::Module) 1 perl(base) 1 perl(strict) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Please add missing run-require perl(File::Basename) it is used in Test-Toolbox-0.4/lib/Test/Toolbox.pm:176 $ rpm -qp --provides perl-Test-Toolbox-0.4-1.fc26.noarch.rpm | sort | uniq -c 1 perl(Test::Toolbox) = 0.4 1 perl-Test-Toolbox = 0.4-1.fc26 Binary provides are Ok. $ rpmlint ./perl-Test-Toolbox* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR. FIX: Please replace my name by your name in changelog. Please correct all 'FIX' issues and consider fixing 'TODO' items and provide new spec file. Package is not approved.
Thank you for the review. New versions of .spec and .src.rpm were put to Spec URL: https://adelton.fedorapeople.org/perl-Test-Toolbox.spec SRPM URL: https://adelton.fedorapeople.org/perl-Test-Toolbox-0.4-1.fc24.src.rpm The .spec diff against the first take is --- perl-Test-Toolbox.spec.take1 2016-09-05 13:23:09.668485126 +0200 +++ perl-Test-Toolbox.spec 2016-09-06 16:45:46.474393197 +0200 @@ -8,17 +8,20 @@ Source0: http://www.cpan.org/modules/by-module/Test/Test-Toolbox-%{version}.tar.gz BuildArch: noarch +BuildRequires: coreutils BuildRequires: findutils BuildRequires: make BuildRequires: perl BuildRequires: perl(base) BuildRequires: perl(Carp) +BuildRequires: perl(Exporter) BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(strict) BuildRequires: perl(Test::Builder::Module) BuildRequires: perl(Cwd) BuildRequires: perl-generators +Requires: perl(File::Basename) Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) %description @@ -36,7 +39,7 @@ make %{?_smp_mflags} %install -make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT +make pure_install DESTDIR=%{buildroot} find $RPM_BUILD_ROOT -type f -name .packlist -delete @@ -52,5 +55,5 @@ %{_mandir}/man3/* %changelog -* Mon Sep 05 2016 Jitka Plesnikova <jplesnik> - 0.4-1 +* Mon Sep 05 2016 Jan Pazdziora <jpazdziora> - 0.4-1 - 1370828 dependency - Initial .spec for 0.4.
@@ -36,7 +39,7 @@ make %{?_smp_mflags} %install -make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT +make pure_install DESTDIR=%{buildroot} find $RPM_BUILD_ROOT -type f -name .packlist -delete FIX: Please replace '%{buildroot} by '$RPM_BUILD_ROOT' to be consistent and not use these two macros in one spec. Other changes are ok. Please correct the 'FIX' issue. Otherwise package looks good. Approved.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Test-Toolbox
perl-Test-Toolbox-0.4-1.fc25 perl-String-Util-1.26-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-86f77ef0ed
perl-String-Util-1.26-1.fc25, perl-Test-Toolbox-0.4-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-86f77ef0ed
perl-String-Util-1.26-1.fc25, perl-Test-Toolbox-0.4-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.