Bug 1374089 - Trivial tap script won't compile
Summary: Trivial tap script won't compile
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: systemtap
Version: 24
Hardware: Unspecified
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Frank Ch. Eigler
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-07 23:35 UTC by David Gibson
Modified: 2016-09-27 14:52 UTC (History)
8 users (show)

Fixed In Version: systemtap-3.0-4.fc24 systemtap-3.0-4.fc23
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-09-13 22:23:22 UTC
Type: Bug


Attachments (Terms of Use)

Description David Gibson 2016-09-07 23:35:56 UTC
Description of problem:

Running an systemtap script - even a trivial one - seems to just generate compile errors building the prove module.

Version-Release number of selected component (if applicable):

systemtap-3.0-3.fc24.x86_64
kernel-debuginfo-4.7.2-201.fc24.x86_64

How reproducible:

100%

Steps to Reproduce:
1.  Create trivial.stp with this contents:

    probe begin {
      printf("Trace begin...\n");
    }

2. Run stap trivial.stp

Actual results:

$ stap trivial.stp 
In file included from /usr/share/systemtap/runtime/linux/print.c:17:0,
                 from /usr/share/systemtap/runtime/print.c:17,
                 from /usr/share/systemtap/runtime/runtime_context.h:22,
                 from /tmp/stapMWkzhS/stap_4b9ee4e0e9a367524bd62b81d8ea8a46_823_src.c:50:
/usr/share/systemtap/runtime/transport/transport.c: In function ‘_stp_lock_inode’:
/usr/share/systemtap/runtime/transport/transport.c:494:19: error: ‘struct inode’ has no member named ‘i_mutex’; did you mean ‘i_mode’?
  mutex_lock(&inode->i_mutex);
                   ^~
/usr/share/systemtap/runtime/transport/transport.c: In function ‘_stp_unlock_inode’:
/usr/share/systemtap/runtime/transport/transport.c:503:21: error: ‘struct inode’ has no member named ‘i_mutex’; did you mean ‘i_mode’?
  mutex_unlock(&inode->i_mutex);
                     ^~
scripts/Makefile.build:289: recipe for target '/tmp/stapMWkzhS/stap_4b9ee4e0e9a367524bd62b81d8ea8a46_823_src.o' failed
make[1]: *** [/tmp/stapMWkzhS/stap_4b9ee4e0e9a367524bd62b81d8ea8a46_823_src.o] Error 1
Makefile:1461: recipe for target '_module_/tmp/stapMWkzhS' failed
make: *** [_module_/tmp/stapMWkzhS] Error 2
WARNING: kbuild exited with status: 2
Pass 4: compilation failed.  [man error::pass4]


Expected results:

Script runs and prints the begin message.

Additional info:

Comment 1 Frank Ch. Eigler 2016-09-07 23:39:36 UTC
Yeah, kernel 4.7 mandates a newer snapshot of git stap, or else https://sourceware.org/bugzilla/show_bug.cgi?id=20132 .

Comment 2 Frank Ch. Eigler 2016-09-08 00:03:34 UTC
Would you be able to test the builds for the backport option on your box?

https://koji.fedoraproject.org/koji/buildinfo?buildID=798612

Comment 3 David Gibson 2016-09-08 05:23:12 UTC
Thanks for the link.  I've tried the koji build and so far it's looking good.

Comment 4 Fedora Update System 2016-09-08 12:25:51 UTC
systemtap-3.0-4.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-32ee377ff2

Comment 5 Fedora Update System 2016-09-08 13:06:22 UTC
systemtap-3.0-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0ab60daf6d

Comment 6 Fedora Update System 2016-09-09 17:57:05 UTC
systemtap-3.0-4.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0ab60daf6d

Comment 7 Fedora Update System 2016-09-12 15:27:48 UTC
systemtap-3.0-4.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-32ee377ff2

Comment 8 Fedora Update System 2016-09-13 22:23:17 UTC
systemtap-3.0-4.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2016-09-27 14:52:17 UTC
systemtap-3.0-4.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.