Bug 1374830 - Toolbars: allow passing additional html attributes to button <a> tags.
Summary: Toolbars: allow passing additional html attributes to button <a> tags.
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.6.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: GA
: 5.7.0
Assignee: Martin Povolny
QA Contact: Matouš Mojžíš
URL:
Whiteboard: ui
Depends On:
Blocks: 1375614
TreeView+ depends on / blocked
 
Reported: 2016-09-09 18:34 UTC by John Prause
Modified: 2016-10-20 23:07 UTC (History)
7 users (show)

Fixed In Version: 5.7.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1375614 (view as bug list)
Environment:
Last Closed: 2016-09-29 20:08:50 UTC
Category: ---
Cloudforms Team: Unknown
Target Upstream Version:


Attachments (Terms of Use)

Description John Prause 2016-09-09 18:34:26 UTC
Issue for QE to test this PR merge.

Comment 2 John Prause 2016-09-09 18:36:29 UTC
Merged and darga/backported: https://github.com/ManageIQ/manageiq/pull/8079

Comment 4 Dave Johnson 2016-09-29 20:08:50 UTC
----- Original Message -----
> From: "Martin Povolny" <mpovolny>
> To: "Dave Johnson" <dajohnso>
> Cc: "Matous Mojzis" <mmojzis>, "Milan Falešník" <mfalesni>
> Sent: Thursday, September 29, 2016 2:38:00 PM
> Subject: Re: Skipping a BZ
> 
> Hi.
> 
> As I already wrote I have no idea how you want to test this and what would
> be the benefit of that.
> 
> The change was to support some toolbar feature that the container team
> needed for another feature.
> 
> The feature was not used so it had no effect. It's an internal thing.
> 
> Meanwhile the toolbars where rewritten and the feature in question has no
> longer any sense.
> 
> The PR that used the feature (make sure you have test coverage for that if
> you want this all to have any value):
> https://github.com/ManageIQ/manageiq/pull/9465
> 
> On Thu, Sep 29, 2016 at 6:42 PM, Dave Johnson <dajohnso> wrote:
> 
> > Martin, can you help us out here?  We are not sure how to verify.  From BZ
> > comment...
> >
> > Matouš Mojžíš 2016-09-20 11:12:40 EDT
> > What shall I verify?
> > That there is in <a> tag ng-click= attribute?
> > Or what?
> >
> > Thanks,
> > -Dave


Note You need to log in before you can comment on or make changes to this bug.