Spec URL: https://tc01.fedorapeople.org/quassel/quassel-irssi/libquasselc.spec SRPM URL: https://tc01.fedorapeople.org/quassel/quassel-irssi/libquasselc-0-0.1.20160909git.fc24.src.rpm Description: An implementation of the Quassel protocol in pure C. Fedora Account System Username: tc01
> Name: libquasselc I think we should take original name - quasselc or QuasselC (depending how upstream feel) > Release: 0.1.20160909git%{?dist} This is allowed, but I would prefer to have in format %{gitdate}git%{shortcommit} > License: GPLv3 GPLv3+ > Source0: libquassel-20160909git.tar.gz https://fedoraproject.org/wiki/Packaging:SourceURL#Commit_Revision
Whoops. I'd apparently forgotten that github URLs worked like that, my bad! Fixed, also added the hash to the release tag. Renamed to "quasselc" (upstream's makefile installs files into /usr/include/quasselc so this name is acceptable). I wasn't entirely sure which name would be better. Spec URL: https://tc01.fedorapeople.org/quassel/quassel-irssi/quasselc.spec SRPM URL: https://tc01.fedorapeople.org/quassel/quassel-irssi/quasselc-0-0.1.20160909gitfcd9669.fc24.src.rpm
Actually, now I'm not sure I've gotten the release tag correct. Is the leading zero required in this case, if Version: 0?
> BuildRequires: gcc, glib2 BuildRequires: gcc BuildRequires: pkgconfig(glib-2.0) * It even fails to build * Looks like missing BuildRequires: zlib-devel (LDLIBS:=$(shell pkg-config glib-2.0 --libs) -lz) it doesn't matter if you have leading zero or not.
My bad, fixed that (and removed the leading zero from Release). Let's try this again. :) Spec URL: https://tc01.fedorapeople.org/quassel/quassel-irssi/quasselc.spec SRPM URL: https://tc01.fedorapeople.org/quassel/quassel-irssi/quasselc-0-1.20160909gitfcd9669.fc24.src.rpm
Are you still interested in this review?
* %global shortcommit0 fcd9669 -> %global shortcommit0 %(c=%{commit0}; echo ${c:0:7}) quasselc.x86_64: W: shared-lib-calls-exit /usr/lib64/libquasselc.so.0 exit.5 -> worth reporting upstream quasselc.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquasselc.so.0 handle_backlog quasselc.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquasselc.so.0 handle_message quasselc.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquasselc.so.0 handle_sync quasselc.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquasselc.so.0 handle_event -> same
Thanks for the review! Upstream bugs filed: * https://github.com/phhusson/QuasselC/issues/4 * https://github.com/phhusson/QuasselC/issues/5
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/quasselc
quasselc-0-1.20160909gitfcd9669.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e77aa3e943
quasselc-0-1.20160909gitfcd9669.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-52876b00d4
quasselc-0-1.20160909gitfcd9669.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-944a599e8f
quasselc-0-1.20160909gitfcd9669.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-944a599e8f
quasselc-0-1.20160909gitfcd9669.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-52876b00d4
quasselc-0-1.20160909gitfcd9669.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e77aa3e943
quasselc-0-1.20160909gitfcd9669.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
quasselc-0-1.20160909gitfcd9669.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
quasselc-0-1.20160909gitfcd9669.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.