Bug 1375138 - Add empty tag for distro should raise warning message
Summary: Add empty tag for distro should raise warning message
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Beaker
Classification: Retired
Component: web UI
Version: develop
Hardware: Unspecified
OS: Unspecified
low
low vote
Target Milestone: ---
Assignee: beaker-dev-list
QA Contact: tools-bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-12 09:24 UTC by wangdong
Modified: 2020-06-02 12:01 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-06-02 11:59:03 UTC

Attachments (Terms of Use)
duplicate tag name (89.52 KB, image/png)
2016-09-14 08:13 UTC, wangdong 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Description wangdong 2016-09-12 09:24:05 UTC 
Description of problem:


Version-Release number of selected component (if applicable):
develop:Beaker 24.0.git.77.4e7fc33 

How reproducible:
easy

Steps to Reproduce:
1. Goto distro detail view page. https://beaker-devel.app.eng.bos.redhat.com/distros/view?id=11436
2. Click on Add button without input anything.
3.

Actual results:
Page show 'Added Tag ', but it's not real add a tag.

Expected results:
Page should tip user assign a tag name then click Add button.

Additional info:
Inconsistent comparison between WebUI & CLI.
In bkr command, it not allow user add a empty tag name.  Like below:

[root@dhcp-140-87 ~]# bkr distros-tag --name RHEL-7.3-20160909.n.0
Usage: bkr distros-tag [options] <tag>

bkr: error: Please specify a tag
Comment 1 wangdong 2016-09-13 09:49:22 UTC 
Also if I add a exist tag, it show add successful.
Try to fix this bug.
Comment 2 wangdong 2016-09-14 08:13:55 UTC 
Created attachment 1200754 [details]
duplicate tag name
Comment 4 Dan Callaghan 2016-09-15 00:00:19 UTC 
I wouldn't look too closely at the tagging stuff. It does have some problems but we are planning to get rid of it in favour of PDC metadata. And tags can only be added by admins as well. So this is quite low importance I think.
Comment 5 Martin Styk 2020-06-02 11:59:03 UTC 
Hello,

thank you for opening issue in Beaker project.
This issue was marked with component "web ui".
As we are not planning to address any further issues in current UI, due to technical stack and not being able to work with Python 3 codebase, I'm closing this issue as WONTFIX.
New UI will be reimplemented within new versions of Beaker.

If you have any questions feel free to reach out to me.

Best regards,
Martin <martin.styk>
Note You need to log in before you can comment on or make changes to this bug.