Bug 1375142 - Upgrading fedora-release creates an rpmsave file
Summary: Upgrading fedora-release creates an rpmsave file
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: fedora-release
Version: 25
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dennis Gilmore
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-12 09:39 UTC by Bastien Nocera
Modified: 2016-09-22 12:36 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-09-22 12:36:41 UTC
Type: Bug


Attachments (Terms of Use)

Description Bastien Nocera 2016-09-12 09:39:39 UTC
On a Fedora 24 system, I ran:
sudo rpm -Uvh fedora-release-25-0.11.noarch.rpm fedora-release-workstation-25-0.11.noarch.rpm fedora-repos-25-0.5.noarch.rpm 
Preparing...                          ################################# [100%]
Updating / installing...
   1:fedora-repos-25-0.5              ################################# [ 17%]
   2:fedora-release-25-0.11           ################################# [ 33%]
   3:fedora-release-workstation-25-0.1warning: /usr/lib/os.release.d/os-release-workstation saved as /usr/lib/os.release.d/os-release-workstation.rpmsave
################################# [ 50%]
Cleaning up / removing...
   4:fedora-release-workstation-24-2  ################################# [ 67%]
   5:fedora-repos-24-1                ################################# [ 83%]
   6:fedora-release-24-2              ################################# [100%]

The content was:
$ cat /usr/lib/os.release.d/os-release-workstation.rpmsave
NAME="Fedora"
VERSION="24 (Workstation Edition)"
ID=fedora
VERSION_ID=24
PRETTY_NAME="Fedora 24 (Workstation Edition)"
ANSI_COLOR="0;34"
CPE_NAME="cpe:/o:fedoraproject:fedora:24"
HOME_URL="https://fedoraproject.org/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=24
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=24
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="Workstation Edition"
VARIANT_ID=workstation

$ cat /usr/lib/os.release.d/os-release-workstation 
NAME=Fedora
VERSION="25 (Workstation Edition)"
ID=fedora
VERSION_ID=25
PRETTY_NAME="Fedora 25 (Workstation Edition)"
ANSI_COLOR="0;34"
CPE_NAME="cpe:/o:fedoraproject:fedora:25"
HOME_URL="https://fedoraproject.org/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=25
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=25
PRIVACY_POLICY_URL=https://fedoraproject.org/wiki/Legal:PrivacyPolicy
VARIANT="Workstation Edition"
VARIANT_ID=workstation

Why did it create a backup of this file?

Comment 1 Stephen Gallagher 2016-09-12 11:56:05 UTC
I have no idea why it would create a backup of that file unless it had been altered at some point since it was installed.

The only thing that looks odd is the quotes around the Privacy Policy link...

The original F24 file doesn't include those quotes. Maybe you (or some other process) manually added them at some point?

Comment 2 Dennis Gilmore 2016-09-12 13:41:55 UTC
The backup should have only been created if the file had been edited.

Comment 3 Bastien Nocera 2016-09-21 16:21:57 UTC
(In reply to Dennis Gilmore from comment #2)
> The backup should have only been created if the file had been edited.

Do you see any changes in the above?

Comment 4 Stephen Gallagher 2016-09-21 18:10:02 UTC
(In reply to Bastien Nocera from comment #3)
> Do you see any changes in the above?

(In reply to Stephen Gallagher from comment #1)
> The original F24 file doesn't include those quotes. Maybe you (or some other
> process) manually added them at some point?

So yes, that file was different from what the RPM had originally slapped down onto the disk. This is why you got an rpmsave file.

Comment 5 Bastien Nocera 2016-09-22 12:36:41 UTC
(In reply to Stephen Gallagher from comment #1)
<snip>
> The original F24 file doesn't include those quotes. Maybe you (or some other
> process) manually added them at some point?

Sorry, I missed that bit. My mistake, I was testing a patch upstream (which did use quotes, see https://bugzilla.gnome.org/show_bug.cgi?id=770260)

Thanks for the root causing as well.


Note You need to log in before you can comment on or make changes to this bug.