Hide Forgot
Spec URL: https://fedorapeople.org/~brouhaha/icestorm/icestorm.spec SRPM URL: https://fedorapeople.org/~brouhaha/icestorm/icestorm-0-0.1.20160904git0b4b038.fc24.src.rpm Description: Project IceStorm aims at documenting the bitstream format of Lattice iCE40 FPGAs and providing simple tools for analyzing and creating bitstream files. Fedora Account System Username: brouhaha
It is awesome, that you want to package this. Unfortunately I have found some issues at first glance: - The README file contains mostly the license, therefore IMHO it should be included with %license. - Have you considered shipping the examples and doc dirs as %doc? - iceboxdb.py seems to be a module and not a program, therefore it does not belong to /usr/bin but rather %python_sitelib I think. It might be a good idea to discuss the proper path with upstream. For future-proofness it might be a good idea to put it in a directory in %python_sitelib such as icebox and put it in a db.py file there. Having it in /usr/bin also creates the problem that it might create .pyc/.pyo files there, since iceboxdb.py is imported - Also the files in /usr/bin should not have a .py suffix
Actually icebox.py is also a module and not a proper script.
Spec URL: https://fedorapeople.org/~brouhaha/icestorm/icestorm.spec SRPM URL: https://fedorapeople.org/~brouhaha/icestorm/icestorm-0-0.2.20161101git01b9822.fc24.src.rpm Updated to latest upstream, and updated per comments #1 and #2.
* Package named correctly * License tag okay * License good for Fedora * SPEC file clean and legible, uses up to date macros * Filelist sane * Requires/provides look good * Uses proper compiler flags * Builds fine in mock 0.) Not packaging the latest version. Probably all right since upstream doesn't do formal releases, but please bump it to a later snapshot when importing, given how long has this review been stalled rpmlint is sort of happy, but there are points that should be addressed: 1.) version-control-internal-file /usr/share/doc/icestorm/examples/*/.gitignore Please %exclude or remove this 2.) wrong-file-end-of-line-encoding /usr/share/doc/icestorm/examples/icestick/icestick.pcf Please dos2unix this. We read the examples on Linux. The above is trivial enough to be addressed on import. This package is APPROVED
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/icestorm
icestorm-0-0.3.20170914git5c4d4db.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-918d1763f5
icestorm-0-0.3.20170914git5c4d4db.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-a8a9bc3bd3
icestorm-0-0.3.20170914git5c4d4db.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-a8a9bc3bd3
icestorm-0-0.3.20170914git5c4d4db.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-918d1763f5
icestorm-0-0.3.20170914git5c4d4db.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
icestorm-0-0.3.20170914git5c4d4db.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.