Bug 1375577 - DHCP agent still refers to deprecated dhcp_domain
Summary: DHCP agent still refers to deprecated dhcp_domain
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-neutron
Version: 8.0 (Liberty)
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 8.0 (Liberty)
Assignee: Brian Haley
QA Contact: Toni Freger
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-13 13:22 UTC by Robin Cernin
Modified: 2020-07-16 08:54 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-04-22 14:21:23 UTC
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1583769 0 None None None 2016-09-13 13:23:35 UTC
OpenStack gerrit 406243 0 None MERGED Remove deprecated dhcp_domain from dhcp_agent.ini 2020-09-24 09:36:07 UTC

Description Robin Cernin 2016-09-13 13:22:59 UTC
Description of problem:

We are hitting the same problem as described in https://bugs.launchpad.net/neutron/+bug/1583769

Version-Release number of selected component (if applicable):
openstack-neutron-7.0.1-15.el7ost.noarch
openstack-neutron-bigswitch-agent-2015.3.8-1.el7ost.noarch
openstack-neutron-bigswitch-lldp-2015.3.8-1.el7ost.noarch
openstack-neutron-common-7.0.1-15.el7ost.noarch
openstack-neutron-lbaas-7.0.0-2.el7ost.noarch
openstack-neutron-metering-agent-7.0.1-15.el7ost.noarch
openstack-neutron-ml2-7.0.1-15.el7ost.noarch
openstack-neutron-openvswitch-7.0.1-15.el7ost.noarch
python-neutron-7.0.1-15.el7ost.noarch
python-neutron-lbaas-7.0.0-2.el7ost.noarch
python-neutronclient-3.1.0-1.el7ost.noarch

How reproducible:

Steps to Reproduce:
1) dhcp_domain has default value "openstacklocal' in dhcp_agent.ini
2) redhat.com has been set as dns_domain in neutron.conf
3) instances have  $host.openstacklocal as fqdn


Actual results:


Expected results:


Additional info:

Comment 3 Assaf Muller 2016-09-13 19:01:54 UTC
I contacted folks upstream to speed this along.

Comment 8 Assaf Muller 2017-04-27 21:43:47 UTC
I see that the backports were abandoned upstream, can you comment on the feasibility of resolving this bug downstream somehow?

Comment 9 Brian Haley 2017-04-28 01:10:15 UTC
My first answer is we should set dhcp_domain in dhcp_agent.ini until we have Ocata code as that will fix the problem.  Is that possible?


The backports were abandoned since it was touching a configuration option, which can't be removed in a stable release.

I think there's two options:

1. Changing the stable DHCP code to do something like:

    domain = self.conf.dns_domain or self.conf.dhcp_domain

  So it prefers the new one in neutron.conf over the deprecated one.

2. Add this to neutron/conf/common.py in the dns_domain code:

    deprecated_name='dhcp_domain', deprecated_group='dhcp'


#2 would be preferred since it touches just one spot (hopefully).

The only problem is that it needs to merge to master first, then get backported, it can't go directly into stable.  So that essentially turns-into commit to master, cherry-pick to stable/*, revert master, but not the stable branches.

Comment 10 Brian Haley 2017-05-04 19:34:18 UTC
So after looking at this further, the only way to get the DHCP agent to honor dns_domain from neutron.conf in anything but Ocata+ is to target a change just at stable/newton, etc. since the agent code itself in those releases ignores the value.  The original deprecation code wasn't complete in this regards, and when I removed dhcp_domain in Ocata I created a flag day.

We can't go back in time, so I see the best option as just setting both values to be the same until Ocata/OSP11 arrives and we can remove dhcp_domain.

The other option is to create a one-off change for OSP10, etc that would allow us to only set dns_domain and have it work.  Assaf - I don't know the precedence for that, but it's been frowned-upon at a previous employer :)

Comment 11 Brian Haley 2017-11-09 21:02:26 UTC
https://code.engineering.redhat.com/gerrit/#/c/122901/ is an example of a possible downstream-only change to address this issue.

Comment 12 Brian Haley 2019-04-22 14:21:23 UTC
Closing as customer case is closed and OSP 8 is going EOL this week.


Note You need to log in before you can comment on or make changes to this bug.